Skip to content

Changed command for building node modules to npm ci - #2080

Merged
fhemberger merged 3 commits into
nodejs:masterfrom
ddc22:patch-1
Feb 15, 2019
Merged

Changed command for building node modules to npm ci#2080
fhemberger merged 3 commits into
nodejs:masterfrom
ddc22:patch-1

Conversation

@ddc22

@ddc22ddc22 commented Feb 15, 2019•
edited by fhemberger
Loading

Copy link
Copy Markdown
Contributor

To maintain the exact tree as committed in development npm has introduced the npm ci command which is meant to provide reproducible builds.
please take a look at the official documentation for more information.

@ddc22
Changed command for building node modules to npm ci
b744d7f
To maintain the exact tree as committed in development npm has introduced the npm ci command which is meant to provide reproducible builds.
please take a look at the [official documentation|https://docs.npmjs.com/cli/ci.html] for more information.
@fhemberger

fhemberger commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

Hi, thanks for your contribution!

There are a couple more instances of npm install which should be npm ci according to the definition. It would also be nice if you could add a sentence explaining the difference to npm install, as not everybody will be familiar with this command. A link to the npm docs would help as well.

@ddc22

ddc22 commented Feb 15, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Hi @fhemberger! Glad to contribute :). Please let me know if there should be any other additions.

ZYSzys
ZYSzys approved these changes Feb 15, 2019
View reviewed changes

@ZYSzysZYSzys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadlocale/en/docs/guides/nodejs-docker-webapp.md Outdated
fhemberger
fhemberger suggested changes Feb 15, 2019
View reviewed changes
Comment threadlocale/en/docs/guides/nodejs-docker-webapp.md
Comment threadlocale/en/docs/guides/nodejs-docker-webapp.md
@ZYSzys@ddc22
Update locale/en/docs/guides/nodejs-docker-webapp.md
77d474b
Added code formatting as suggested
Co-Authored-By: jdc91 <dehandecroos@gmail.com>
@fhemberger
fhemberger merged commit b6f51eb into nodejs:masterFeb 15, 2019
@fhemberger

fhemberger commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

Thank you!

@ghostghost mentioned this pull request Feb 16, 2019
Merged
@ghost

ghost commented Feb 16, 2019

Copy link
Copy Markdown

@nodejs/localization：Need to be translated for your own languages if possible and free for you.

ZYSzys pushed a commit that referenced this pull request Feb 16, 2019
Maledong@ZYSzys
zh-CN：Trans for 'nodejs-docker-webapp.md' (#2083)
8b27598
Ref：#2080.
yous added a commit to yous/nodejs.org that referenced this pull request Feb 16, 2019
@yous
ko: update translation of 'nodejs-docker-webapp.md'
d098c2c
Ref nodejs#1476, nodejs#2080.
@yousyous mentioned this pull request Feb 16, 2019
Merged
taggon pushed a commit that referenced this pull request Feb 18, 2019
@yous@taggon
ko: update translation of 'nodejs-docker-webapp.md' (#2084)
d6bc26b
* ko: update translation of 'nodejs-docker-webapp.md'
Ref #1476, #2080.
* ko: apply reviews
@kingjay66kingjay66 mentioned this pull request Oct 14, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZYSzysZYSzysZYSzys approved these changes
+2 more reviewers
@fhembergerfhembergerfhemberger approved these changes
@willinwillinwillin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ddc22@fhemberger@willin@ZYSzys