Skip to content

ko: update translation of 'nodejs-docker-webapp.md' - #2084

Merged
taggon merged 2 commits into
nodejs:masterfrom
yous:ko-docker-webapp
Feb 18, 2019
Merged

ko: update translation of 'nodejs-docker-webapp.md'#2084
taggon merged 2 commits into
nodejs:masterfrom
yous:ko-docker-webapp

Conversation

@yous

@yousyous commented Feb 16, 2019

Copy link
Copy Markdown
Contributor

Ref #1476, #2080.

You may want to view the whole file because the comments have been updated without the updates of translation.

@nodejs/nodejs-ko Review please.

@yous

yous commented Feb 16, 2019

Copy link
Copy Markdown
ContributorAuthor

I can't assign @nodejs/nodejs-ko as reviewers, are there some limitations?

@ghost
ghost requested review from jbottigliero and outsiderisFebruary 16, 2019 07:30
@yous

yous commented Feb 16, 2019

Copy link
Copy Markdown
ContributorAuthor

Actually I’m in the team now, but I’m not available to assign them as reviewers when I make a new PR.

@taggon

Copy link
Copy Markdown
Contributor

Can we use ‘작업 디렉터리’ instead of ‘워킹 디렉터리’?

@yous

yous commented Feb 18, 2019

Copy link
Copy Markdown
ContributorAuthor

Sure, I've updated.

@ghost

Copy link
Copy Markdown

@taggon:Can you confirm whether it's OK? You can merge it if possible :)

@taggontaggon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@taggon
taggon merged commit d6bc26b into nodejs:masterFeb 18, 2019
@yous
yous deleted the ko-docker-webapp branch February 18, 2019 15:34
@yous

yous commented Feb 18, 2019

Copy link
Copy Markdown
ContributorAuthor

Thanks all!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@yous@taggon@outsideris