Skip to content

Enable MD033 rule - #2382

Merged
MylesBorins merged 6 commits into
nodejs:masterfrom
nschonni:chore--Enable-MD033/no-inline-html
Aug 23, 2019
Merged

Enable MD033 rule#2382
MylesBorins merged 6 commits into
nodejs:masterfrom
nschonni:chore--Enable-MD033/no-inline-html

Conversation

@nschonni

@nschonninschonni commented Aug 10, 2019

Copy link
Copy Markdown
Member

No description provided.

@XhmikosR

XhmikosR commented Aug 15, 2019

Copy link
Copy Markdown
Contributor

@nschonni actually this PR changes more than h1s, don't forget to change the PR title and don't squash this.

We need this, along with my HTML validation fixes which flagged some of these.

@nschonninschonni changed the title fix: Replace multiple H1sEnable MD033 ruleAug 15, 2019
XhmikosR
XhmikosR reviewed Aug 15, 2019
View reviewed changes
Comment thread.markdownlint.json Outdated
XhmikosR
XhmikosR reviewed Aug 17, 2019
View reviewed changes
Comment threadlocale/en/blog/module/service-logging-in-json-with-bunyan.md Outdated
@nschonni
nschonniforce-pushed the chore--Enable-MD033/no-inline-html branch 2 times, most recently from 67368d3 to 5289a08CompareAugust 22, 2019 03:23
@XhmikosR

XhmikosR commented Aug 22, 2019

Copy link
Copy Markdown
Contributor

LGTM I also did the Markdown conversion in #2437, not by hand though.

@nschonni
chore: Enable MD033/no-inline-html
3ddd628
Suppress currently flagged elements
@nschonni
fix: Remove "ins" elements
0ef30ba
@nschonni
fix: Use Markdown blockquotes
66c9905
Converte the resto of http-server-security-vulnerability-please-upgrade-to-0-6-17.md to pure MD at the same time
@nschonni
fix: Escape "prot" for release log
c8e2357
Was swallowed as HTML before
@nschonni
fix: Replace multiple H1s
7dd651f
@nschonni
fix: Remove commented out "anonymous" tag
725348a
@nschonni
nschonniforce-pushed the chore--Enable-MD033/no-inline-html branch from 5289a08 to 725348aCompareAugust 23, 2019 04:33
MylesBorins
MylesBorins approved these changes Aug 23, 2019
View reviewed changes

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
MylesBorins merged commit 016c7ab into nodejs:masterAug 23, 2019
@nschonni
nschonni deleted the chore--Enable-MD033/no-inline-html branch August 23, 2019 16:10
@MarcelRaschkeMarcelRaschke mentioned this pull request Aug 19, 2022
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@XhmikosRXhmikosRXhmikosR approved these changes
@MylesBorinsMylesBorinsMylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nschonni@XhmikosR@MylesBorins