Skip to content

Convert a few posts to Markdown - #2437

Merged
1 commit merged into
nodejs:masterfrom
XhmikosR:master-xmr-markdownify
Sep 3, 2019
Merged

Convert a few posts to Markdown#2437
1 commit merged into
nodejs:masterfrom
XhmikosR:master-xmr-markdownify

Conversation

@XhmikosR

@XhmikosRXhmikosR commented Aug 21, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes a few HTML validation errors along the way.

Also remove the 404 images from /multi-server-continuous-deployment-with-fleet.md.

For npm's posts, I kept the old IDs for backward compatibility.

@XhmikosRXhmikosR changed the title Covert a few posts to MarkdownConvert a few posts to MarkdownAug 21, 2019
@XhmikosR
XhmikosR marked this pull request as ready for review August 21, 2019 15:08
@XhmikosRXhmikosR mentioned this pull request Aug 22, 2019
Merged
@XhmikosR

This comment has been minimized.

Sign in to view
XhmikosR
XhmikosR commented Aug 23, 2019
View reviewed changes
Comment threadlocale/en/blog/vulnerability/http-server-security-vulnerability-please-upgrade-to-0-6-17.md Outdated

@XhmikosRXhmikosRAug 23, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nschonni weird this wasn't caught :/

@nschonninschonniAug 24, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a bunch of the link checking is done through regex. Can't hurt to file an issue with the library though. Not sure if there is a rule that covers links or not

@XhmikosR

XhmikosR commented Aug 23, 2019

Copy link
Copy Markdown
ContributorAuthor

Alright, I went ahead and put back the old IDs for backward compatibility.

@XhmikosR

XhmikosR commented Aug 23, 2019

Copy link
Copy Markdown
ContributorAuthor

Alright, I believe this is ready for review. We could tweak these further later.

@XhmikosR

XhmikosR commented Aug 25, 2019

Copy link
Copy Markdown
ContributorAuthor

If it helps, to review you can check the rich diff for each file on GitHub.

@XhmikosRXhmikosR mentioned this pull request Aug 26, 2019
Merged
@XhmikosR
Convert most posts to Markdown.
1ada4be
Fixes a few HTML validation errors along the way.
Also remove the 404 images from /multi-server-continuous-deployment-with-fleet.md.
For npm's posts, I kept the old IDs for backward compatibility.
@XhmikosR

XhmikosR commented Sep 2, 2019

Copy link
Copy Markdown
ContributorAuthor

Can we get this merged? The plan is to convert most inline HTML to Markdown when possible so that we are consistent.

This also fixes 2 404 errors. There are a few mixed content errors I noticed too, and I'll fix them in another PR.

@XhmikosRXhmikosR mentioned this pull request Sep 2, 2019
Merged
@Trott

Trott commented Sep 3, 2019

Copy link
Copy Markdown
Member

@nodejs/website This needs reviews.

@ghost
ghost merged commit fe266f6 into nodejs:masterSep 3, 2019
@XhmikosR
XhmikosR deleted the master-xmr-markdownify branch September 3, 2019 14:01
@MrStepzMrStepz mentioned this pull request May 24, 2022
Open
This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aymen94aymen94aymen94 approved these changes
+2 more reviewers
@nschonninschonninschonni left review comments
@alexandrtovmachalexandrtovmachalexandrtovmach approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@XhmikosR@Trott@nschonni@aymen94@alexandrtovmach