Fix slashes on Windows.

[XhmikosR]

There's a bug somewhere which results in backslashes in paths when building on Windows.

Maybe the name should be normalize slashes or something? I just wanted to keep it short here.

Fixes#2396

[MylesBorins]

Is there anyone with a windows box who can verify?

[XhmikosR]

Here's the output without this patch (trimmed) to get an idea:

C:\Users\xmr\Desktop\nodejs.org>npm run test:html
> nodejs.org@ test:html C:\Users\xmr\Desktop\nodejs.org
> node scripts/vnu-jar.js
"file:/C:/Users/xmr/Desktop/nodejs.org/build/ar/docs/guides/abi-stability/index.html":32.3-32.80: error: Bad value "https://nodejs.org/ar/docs/guides\abi-stability/" for attribute "href" on element "link": Backslash ("\") used as path segment delimiter.
"file:/C:/Users/xmr/Desktop/nodejs.org/build/ar/docs/guides/anatomy-of-an-http-transaction/index.html":32.3-32.97: error: Bad value "https://nodejs.org/ar/docs/guides\anatomy-of-an-http-transaction/" for attribute "href" on element "link": Backslash ("\") used as path segment delimiter.
"file:/C:/Users/xmr/Desktop/nodejs.org/build/ar/docs/guides/debugging-getting-started/index.html":32.3-32.92: error: Bad value "https://nodejs.org/ar/docs/guides\debugging-getting-started/" for attribute "href" on element "link": Backslash ("\") used as path segment delimiter.
"file:/C:/Users/xmr/Desktop/nodejs.org/build/ar/docs/guides/getting-started-guide/index.html":32.3-32.88: error: Bad value "https://nodejs.org/ar/docs/guides\getting-started-guide/" for attribute "href" on element "link": Backslash ("\") used as path segment delimiter.
"file:/C:/Users/xmr/Desktop/nodejs.org/build/ar/docs/guides/index.html":32.3-32.66: error: Bad value "https://nodejs.org/ar/docs\guides/" for attribute "href" on element "link": Backslash ("\") used as path segment delimiter.
"file:/C:/Users/xmr/Desktop/nodejs.org/build/ar/docs/guides/publishing-napi-modules/index.html":32.3-32.90: error: Bad value "https://nodejs.org/ar/docs/guides\publishing-napi-modules/" for attribute "href" on element "link": Backslash ("\") used as path segment delimiter.
...

My main concern is that I don't know where this bug comes from. Is it from metalsmith itself?

[ghost]

@XhmikosR, Have you submitted test:html in the package.json?

[XhmikosR]

@MaledongGit: what do you mean? If you mean the vnu addition, that's in #2469, which isn't ready yet.

[ghost]

@XhmikosR ：Well……I fetched the latest version of codes and I cannot use test:html, I want to know whether this is already added in the package.json or not. Otherwises I'll merge it into the repository ;)

[XhmikosR]

If you mean the slashes PR, that's ready. The vnu PR is not ready,I list the TODO there.

…

On Tue, Sep 3, 2019, 14:38 Maledong ***@***.***> wrote: @XhmikosR <https://github.com/XhmikosR> ：Well……I fetched the latest version of codes and I cannot use test:html, I want to know whether this is already added in the package.json or not. Otherwises I'll merge it into the repository ;) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2423?email_source=notifications&email_token=AACVLNKGPOQNQHIEXVSUNMDQHZEDPA5CNFSM4IMOPPWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5X5BMQ#issuecomment-527421618>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACVLNIUGJKJJYGDQLZBHKDQHZEDPANCNFSM4IMOPPWA> .

[XhmikosR]

The process.platform check seems inconsistent now since in summary.js I don't do the same.