Uh oh!
There was an error while loading. Please reload this page.
Add vnu.jar support - #2469
Conversation
XhmikosR
commented
Sep 4, 2019
I think we should try fixing the table errors. I'm gonna revert the ignore so that we see the errors, and someone might be able to help fix those. I believe the wrong exit code comes from this for some reason. |
XhmikosR
commented
Sep 5, 2019
Alright, I don't know how to fix the table errors, so I have them ignored for now. This is ready for review. Note that on Windows there will be a failure due to #2422. This isn't triggered on nix, but I've yet to figure out the root cause (like I never managed to figure it out for the slashes, hence the workaround we have). |
XhmikosR
commented
Sep 6, 2019
After #2511 CI will be green. Generally that is why I insist that branches need to be up to date and we have the button. |
XhmikosR
commented
Sep 25, 2019
Can we move with this? |
Can I get some reviews please? This is the only proper way to make sure we are valid and we don't have issues like duplicate IDs and so on. Note that I intentionally skip the test if Java isn't available, and that I haven't added the script in On CI Java is present so this will run there. |
If Java isn't present, the test will be skipped. On CI Java is available, though.
Trott
commented
Oct 1, 2019
@nodejs/website |
This is WIP because there are some things that need to be addressed:
Note that this is how I noticed and fixed many of the issues so far, like bae664a, b533fcd, a714afc, ceee600 etc.
IMO this should definitely land as soon as we sort out the above points. Personally I'd remove htmllint too; I'm having issues with it on Windows and it just doesn't seem to catch any real issues.
Marking it as draft for further discussion and tweaks.
vnu.jar: https://github.com/validator/validator
Closes#2398