Skip to content

feat: migrate codebox component - #5330

Merged
ovflowd merged 50 commits into
nodejs:major/website-redesignfrom
araujogui:feat/codebox
May 18, 2023
Merged

feat: migrate codebox component#5330
ovflowd merged 50 commits into
nodejs:major/website-redesignfrom
araujogui:feat/codebox

Conversation

@araujogui

@araujoguiaraujogui commented Apr 25, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Issue #5242
Migrate Codebox component

@vercel

vercelBot commented Apr 25, 2023•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
nodejs-org✅ Ready (Inspect)Visit Preview💬 Add feedbackMay 18, 2023 3:31pm
nodejs-org-stories✅ Ready (Inspect)Visit PreviewMay 18, 2023 3:31pm

@vercel
vercelBot temporarily deployed to Preview – nodejs-org April 25, 2023 19:20 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories April 25, 2023 19:24 Inactive
@ovflowd

ovflowd commented Apr 25, 2023

Copy link
Copy Markdown
Member

@araujogui please run npx turbo lint your branch has linting issues 🤔

@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories April 25, 2023 20:40 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org April 25, 2023 20:41 Inactive
@araujogui
araujogui marked this pull request as ready for review April 26, 2023 18:50
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories April 26, 2023 18:54 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org April 26, 2023 18:54 Inactive
ovflowd
ovflowd reviewed Apr 27, 2023
View reviewed changes
Comment thread.storybook/preview.tsx
ovflowd
ovflowd reviewed Apr 27, 2023
View reviewed changes
Comment thread.browserslistrc
ovflowd
ovflowd reviewed Apr 27, 2023
View reviewed changes
Comment threadcomponents/Article/Codebox/InlineCode.tsx Outdated
ovflowd
ovflowd reviewed Apr 27, 2023
View reviewed changes
Comment threadcomponents/Article/Codebox/__tests__/index.test.tsx Outdated
ovflowd
ovflowd reviewed Apr 27, 2023
View reviewed changes
Comment threadcomponents/Article/Codebox/__tests__/index.test.tsx Outdated
ovflowd
ovflowd reviewed Apr 27, 2023
View reviewed changes
Comment threadcomponents/Article/Codebox/__tests__/index.test.tsx Outdated
ovflowd
ovflowd reviewed Apr 27, 2023
View reviewed changes
Comment threadcomponents/Article/Codebox/index.module.scss Outdated
ovflowd
ovflowd reviewed Apr 27, 2023
View reviewed changes
Comment threadcomponents/Article/Codebox/index.stories.tsx Outdated
ovflowd
ovflowd reviewed Apr 27, 2023
View reviewed changes
Comment threadcomponents/Article/Codebox/index.tsx
ovflowd
ovflowd reviewed Apr 27, 2023
View reviewed changes
Comment threadcomponents/Article/Codebox/index.tsx
ovflowd
ovflowd reviewed Apr 27, 2023
View reviewed changes
Comment threadhooks/useCopyToClipboard.ts Outdated
ovflowd
ovflowd reviewed Apr 27, 2023
View reviewed changes
Comment threadhooks/useCopyToClipboard.ts Outdated
ovflowd
ovflowd reviewed Apr 27, 2023
View reviewed changes
Comment threadhooks/useCopyToClipboard.ts Outdated
ovflowd
ovflowd reviewed Apr 27, 2023
View reviewed changes
Comment threadhooks/useCopyToClipboard.ts Outdated
ovflowd
ovflowd reviewed Apr 27, 2023
View reviewed changes
Comment threadhooks/useCopyToClipboard.ts Outdated
ovflowd
ovflowd reviewed Apr 27, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good stuff! Thank you for the contribution, @araujogui!!

Left a bunch of comments that I'd like to have them addressed before we proceed :)

@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories April 27, 2023 13:33 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org April 27, 2023 13:36 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories April 27, 2023 13:37 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org April 27, 2023 13:39 Inactive
araujoguiand others added 13 commits May 8, 2023 17:18
@araujogui
chore: revert .browserslistrc
9ee2cb1
@araujogui
test: fix tests
c9de0d2
@araujogui
chore: wip
7acf4d5
@araujogui
feat: use story component arg
0c0c41a
@araujogui
style: stories
d12e5ab
@araujogui
test: remove i18n from clipboard test
89b0e80
@ktssrTeja Sai Sandeep Reddy Konala
@ovflowdWai.Tung@araujogui
chore: migrate pagination component (nodejs#5331)
7b9d637
Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
Claudio Wunder@araujogui
chore: add a proper decorated component
88e69cc
@araujogui
refactor: decorated inline code
f2c19ff
@AugustinMauroy@ovflowd@araujogui
Chore(node feat) (nodejs#5338)
62e129b
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
@AugustinMauroy@manishprivet
@ovflowd@shanpriyan@mikeestoWai.Tung@araujogui
(website redesign) Feat(shellbox): migration (nodejs#5234)
acbf58f
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
@AugustinMauroy@shanpriyan
@ovflowd@araujogui
fix(i18n): translation key (nodejs#5347)
5072fce
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
@araujogui
feat: add hover states
78b6461
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 8, 2023 20:23 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 8, 2023 20:23 Inactive
@ovflowd

ovflowd commented May 11, 2023

Copy link
Copy Markdown
Member

@araujogui updates?

@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 15, 2023 19:09 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 15, 2023 19:11 Inactive
@ovflowd

ovflowd commented May 17, 2023

Copy link
Copy Markdown
Member

@araujogui can you run the linting commands and update the test snapshots here? @Harkunwar is anything else needed here? (Like Unit Tests or etc)

@ovflowd

ovflowd commented May 18, 2023

Copy link
Copy Markdown
Member

@araujogui can you please run build/lint/test before committing? PR is still failing (build failing) with missing types?

ovflowd
ovflowd reviewed May 18, 2023
View reviewed changes
Comment threadcomponents/Article/Codebox/__tests__/index.test.tsx Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ovflowdovflowdovflowd approved these changes
@aymen94aymen94aymen94 approved these changes
@mikeestomikeestomikeesto approved these changes
+1 more reviewer
@shanpriyanshanpriyanshanpriyan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@araujogui@ovflowd@mikeesto@aymen94@shanpriyan@ktssr@AugustinMauroy