Uh oh!
There was an error while loading. Please reload this page.
ci: release postject to npm on ci - #30
Conversation
7ac857d to
e15a9a2Comparef003901 to
9054aa2CompareUh oh!
There was an error while loading. Please reload this page.
Fixes: #14 Signed-off-by: Darshan Sen <raisinten@gmail.com>
9054aa2 to
78837e3CompareSigned-off-by: Darshan Sen <raisinten@gmail.com>
78837e3 to
a8bae4cComparedsanders11
commented
Sep 28, 2022
It seems like this will publish every commit to NPM, since it's just a new CI job? |
dsanders11
left a comment
There was a problem hiding this comment.
I think we should put a pin in this for the moment and stick to manually releasing for our immediate needs. There's a lot of sharp edges I want to make sure we wire up correctly so we shouldn't rush it.
Issues with the current state of this PR:
- It is publishing from all branches on all commits. That means this PR has actually published two releases while in PR state.
- It should do fan-in on the test jobs, otherwise it will publish releases only when the tests pass on the
linuxexecutor, regardless of the state of the other jobs - we want publish only on all green. - I believe the current setup means if I re-run the job with SSH access, I can go read out your personal NPM token.
Let's consider using semantic-release to make a more robust process and avoid the sharp edges. We can also evaluate @continuous-auth/semantic-release-npm for 2FA goodness.
| ## Install | ||
| ```sh | ||
| npm i postject |
There was a problem hiding this comment.
| npm i postject | |
| npm i -g postject |
There's a good chance users of the Postject CLI will be using it outside of a Node project, so I think installing it globally is the better option.
| matrix: | ||
| parameters: | ||
| os: [ linux ] |
There was a problem hiding this comment.
I don't think we need a matrix here, or parameters for the publish command further up in this config? We're just using the linux executor so we should be able to just use that one explicitly.
RaisinTen
commented
Sep 28, 2022
As discussed in DMs, we'll stick to doing releases manually. My main use for doing NPM releases on a PR was that it's easier to test changes that have not been merged on CI in other projects by just updating the package version but the solution we decided on was: |
Fixes: #14
Signed-off-by: Darshan Sen raisinten@gmail.com