Uh oh!
There was an error while loading. Please reload this page.
feat: compile to WebAssembly to eliminate native dependencies - #8
Conversation
563f4a7 to
5b95dfeComparedsanders11
commented
Sep 10, 2022
Some CI jobs are failing for various reasons currently:
|
dsanders11
commented
Sep 11, 2022
For testing this PR locally, it's useful to use |
RaisinTen
left a comment
There was a problem hiding this comment.
Is this going to enable us to generate a single postject.wasm file that would run on all platforms?
This change updates lief to lief-project/LIEF@b183666. This contains lief-project/LIEF#780, which is a requirement for #8. Signed-off-by: Darshan Sen <raisinten@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
This change updates lief to lief-project/LIEF@b183666. This contains lief-project/LIEF#780, which is a requirement for #8. Signed-off-by: Darshan Sen <raisinten@gmail.com>
This change updates lief to lief-project/LIEF@b183666. This contains lief-project/LIEF#780, which is a requirement for #8. Signed-off-by: Darshan Sen <raisinten@gmail.com>
dsanders11
commented
Sep 21, 2022
See these lines in |
Okay, I was wondering because we were generating separate |
0ddb353 to
22d52ccCompare22d52cc to
eb32debCompareUh oh!
There was an error while loading. Please reload this page.
RaisinTen
left a comment
There was a problem hiding this comment.
did a light round of review on things that are unlikely to drastically change in further commits
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
cf76258 to
ae6e5c9Comparedsanders11
commented
Sep 24, 2022
Ready for final review. A couple of things will be done in follow-up PRs:
|
RaisinTen
left a comment
There was a problem hiding this comment.
LGTM
@dsanders11 Can you respond to #8 (comment)?
RaisinTen
commented
Sep 26, 2022
This would be needed for #14, merging. Maybe my comment will get addressed while resolving that issue? |
dsanders11
commented
Sep 27, 2022
@RaisinTen, I'm not sure what the proposed "unifying" would look like - the build jobs are still going to generate the artifacts regardless. I don't think it hurts to publish them for all build jobs, and if there's ever a discrepancy between them it would be easy to compare. Since the artifacts are the same for all platforms, we should just publish from whichever platform is most convenient. |
RaisinTen
commented
Sep 27, 2022
@dsanders11 yes, that's exactly what I'm doing in #30. I chose linux. :) |
Still WIP, but this is a major rewrite of the project to use Emscripten to compile to WebAssembly and ship as an npm package. Roughly I'd say the current state is 80% there.
Needs
emsdkto be installed on the system to work. I considered adding it to thevendorpullconfig, but that repo is over a gigabyte so for now leaving it as an external development dependency.The basics machinery works, although it has only been tested on macOS so far
, and the test is currently failing. I think there may be a LIEF issue causing that, as there are some codepaths which trying to detect the system and use that to determine page size for example, but further investigation needs to be done to determine root cause.(Root cause was in LIEF, patch created and PR opened upstream).There's a couple of high level goals driving the decisions in this PR:
zxmodule instead)mochain this case) to allow for more detailed test coverageStill to do:
Closes#10, #15, #16, #17.