Skip to content

Add even more conditions - #296

Merged
svengreb merged 1 commit into
nordtheme:developfrom
jvoisin:speeeeeed
Apr 11, 2022
Merged

Add even more conditions#296
svengreb merged 1 commit into
nordtheme:developfrom
jvoisin:speeeeeed

Conversation

@jvoisin

Copy link
Copy Markdown
Contributor

No description provided.

@svengrebsvengreb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to #294

Hey @jvoisin, thanks again for extending #294 even more 🚀

@svengreb
svengreb merged commit 40e21f5 into nordtheme:developApr 11, 2022
@jvoisin
jvoisin deleted the speeeeeed branch April 11, 2022 14:11
@cristian-rivera

cristian-rivera commented Apr 11, 2022

Copy link
Copy Markdown

Hey, I just updated this plugin using vim-plug and now I'm receiving the following error upon launching vim which seems to be related to this PR.

I think exist should be exists! https://github.com/arcticicestudio/nord-vim/pull/296/files#diff-4a2da78e9170e9cba996ab45b000ac6bce8d74246cba502fae9cb36c8c43ed24R729

Error detected while processing /Users/cristian/.vimrc[157]../Users/cristian/.vim/bundle/nord-vim/colors/nord.vim:
line 729:
E117: Unknown function: exist
line 862:
E117: Unknown function: exist

Here is some info about my version of vim:

VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Apr 06 2022 16:59:21)
macOS version - x86_64
Included patches: 1-4700
Compiled by Homebrew

svengreb added a commit that referenced this pull request Apr 11, 2022
Fix syntax error in `exists` function
In GH-296 a syntax errors has crept in where the `exists` function was
missing the second `s` in two cases.
FixesGH-299GH-297
Co-authored-by: Julien Voisin <jvoisin@users.noreply.github.com>
Co-authored-by: Sven Greb <development@svengreb.de>
Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com>
@svengreb

Copy link
Copy Markdown
Member

@cristian-rivera Thanks for the report, this has been fixed in #297. Also see my comment in the PR about what can be learned from this.

@jvoisinjvoisin mentioned this pull request Apr 12, 2022
arcticicestudio pushed a commit that referenced this pull request May 14, 2022
This commit is a continuation of GH-294, see message and PR discussion
of commit `a4bf0a63e8e1e62e884eee9ec04d577105f58aa7` for details.
[1]: a4bf0a6
Related to GH-294GH-296
Co-authored-by: Julien Voisin <jvoisin@google.com>
Co-authored-by: Sven Greb <development@svengreb.de>
arcticicestudio added a commit that referenced this pull request May 14, 2022
Fix syntax error in `exists` function
In GH-296 a syntax errors has crept in where the `exists` function was
missing the second `s` in two cases.
FixesGH-299GH-297
Co-authored-by: Julien Voisin <jvoisin@users.noreply.github.com>
Co-authored-by: Sven Greb <development@svengreb.de>
Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jvoisin@cristian-rivera@svengreb@arcticicestudio