Uh oh!
There was an error while loading. Please reload this page.
Harden durable Yieldstar reconciliation - #37
Closed
djgrant wants to merge 1 commit into
Closed
Conversation
- Emit reconciler.drift.detected as a durable step before a drift-update decision, restoring event parity with the synchronous reconciler. - Emit a durable update skip lifecycle event when a resource has no update operation instead of returning silently. - Remove an unreachable dryRun check after the provider mutation. - Read store snapshots in one round trip in YieldStarStateBackend and treat a store deleted mid-read as resource absence, instead of listing every store before each get, update, and delete. - Return the committed store version from YieldStarStateBackend.update rather than a locally computed revision. - Test orphan deletion through the registry and drift repair with events on the durable path. - Document resuming a crashed deployment with the same execution ID to release deployment coordination through replay.
djgrant
commented
Jul 22, 2026
CollaboratorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #36. Review pass over the durable Yieldstar 0.5.0 integration, verified against the installed 0.5.0 runtime sources.
Fixes
reconciler.drift.detectedas a durable step before a drift-update decision, restoring event parity with the synchronous reconciler.update-not-implemented) when a resource has no update operation, instead of silently returning.dryRuncheck after the provider mutation.YieldstarStateBackendnow reads a store snapshot in one round trip and treats a store deleted mid-read as resource absence, instead of callinglistStoresbefore everyget,update, anddelete.YieldstarStateBackend.updatereturns the committed store version fromupdateStoreFromrather than a locally computed revision.Tests
reconciler.drift.detectedevent with the patch diff, onedrift-updatedecision, and one provider update call.Docs
Verified as sound
updateFrom/deleteFromwith the snapshot's UUIDv7instanceIdand version, withstepIdsupplied by the workflow store handle for exactly-once replay.reconcileWithYieldstardoes not use leases or the synchronous step runner; the synchronousReconcilerremains only as the documented CLI path for this release slice.Remaining for a later loop
Reconciler; moving them onto the resident workflow runtime is the next stacked phase per the RFC.docs/manual/reconciler.mdfailsprettier --checkbecause prettier rewraps markdown mid-sentence, which project docs style forbids; pre-existing on the parent branch.Checks run:
pnpm build(13/13),pnpm typecheck(11/11),pnpm test:once(109 passed, 4 skipped).