Uh oh!
There was an error while loading. Please reload this page.
Refactor range metadata - #728
Merged
Merged
Conversation
roji
commented
Dec 2, 2018
Member
Deferring on this until we decide on #685. |
austindrenskiforce-pushed
the
metadata-ranges
branch
2 times, most recently
from
December 2, 2018 16:00
dee74b9 to
d78eff9Compareaustindrenskiforce-pushed
the
metadata-ranges
branch
2 times, most recently
from
December 6, 2018 21:19
111ecdf to
78067afCompareaustindrenski
commented
Dec 6, 2018
ContributorAuthor
austindrenskiforce-pushed
the
metadata-ranges
branch
from
December 6, 2018 21:39
78067af to
a1b47a2Compareaustindrenski
commented
Dec 6, 2018
ContributorAuthor
Rebased for #685. |
roji
approved these changes
Dec 6, 2018
| /// </summary> | ||
| /// <param name="annotatable">The annotatable to search for the annotation.</param> | ||
| /// <param name="annotationName">The annotation name to search for in the annotatable.</param> | ||
| /// <exception cref="ArgumentNullException"><paramref name="annotatable"/></exception> |
Member
There was a problem hiding this comment.
I don't think these exception xmldocs have much value (not sure I've actually seen them specified in other projects etc.). I'm especially skeptical of documenting each and every internal method, it seems to bloat the source for very little gain...
But let's move on...
ContributorAuthor
There was a problem hiding this comment.
FWIW, they show up in the on-hover documentation, which is nice for a quick check on whether or not a null parameter is going to throw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #685.