Uh oh!
There was an error while loading. Please reload this page.
Refactor extension metadata - #729
Merged
Merged
Conversation
austindrenskiforce-pushed
the
metadata-extensions
branch
4 times, most recently
from
December 2, 2018 04:53
caf4a7e to
c625468Compareroji
commented
Dec 2, 2018
Member
Deferring on this until we decide on #685. |
austindrenskiforce-pushed
the
metadata-extensions
branch
from
December 2, 2018 16:10
c625468 to
0756586Compareaustindrenskiforce-pushed
the
metadata-extensions
branch
5 times, most recently
from
December 6, 2018 21:37
7ec2e9e to
9e0365eCompareaustindrenskiforce-pushed
the
metadata-extensions
branch
from
December 6, 2018 21:42
9e0365e to
60e713fCompareaustindrenski
commented
Dec 6, 2018
ContributorAuthor
Updated and rebased for #685. |
austindrenski
commented
Dec 6, 2018
ContributorAuthor
This is pretty close in implementation to #685 and #728, with the exception of adding some of the peripherals that were added in prior PRs for enums and ranges. One important note is that this drops |
roji
approved these changes
Dec 6, 2018
roji
left a comment
Member
There was a problem hiding this comment.
Looks good, let's wait and see what Appveyor thinks. Am OK with dropping IPostgresExtension, not sure what it was there for...
austindrenski
commented
Dec 6, 2018
ContributorAuthor
That looked like a transient failure, requeueing on AppVeyor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #685.