Uh oh!
There was an error while loading. Please reload this page.
Remove non-generic Npgsql-specific HasIndex extension method - #821
Merged
Conversation
khellang
requested review from
YohDeadfall, austindrenski and roji
as code ownersFebruary 18, 2019 19:22
YohDeadfall
approved these changes
Feb 18, 2019
khellang
commented
Feb 18, 2019
ContributorAuthor
I don't know what your routines are in terms of marking breaking changes and updating docs etc. Please let me know if there's anything more I should do. |
austindrenski
approved these changes
Feb 19, 2019
roji
commented
Feb 19, 2019
Member
We don't have very good routines yet :) I've added the breaking change label as a start. Ideally PRs should contain a note in doc/release-notes about the breaking change (and even just general documentation for the feature implemented), but I think in this case it's not really needed as the breaking change is following a general EF Core breaking change. We can always one later if we feel it's necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #813. Follows EF Core's lead; dotnet/efcore#14641.