Skip to content

Update docs following 821 - #828

Merged
austindrenski merged 3 commits into
npgsql:devfrom
KexyBiscuit:patch-1
Mar 3, 2019
Merged

Update docs following 821#828
austindrenski merged 3 commits into
npgsql:devfrom
KexyBiscuit:patch-1

Conversation

@KexyBiscuit

@KexyBiscuitKexyBiscuit commented Feb 20, 2019

Copy link
Copy Markdown
Contributor

HasIndex(Expression<Func<TEntity,Object>>) returns IndexBuilder instead of IndexBuilder<TEntity>, so no overload of ForNpgsqlInclude accept Expression<Func<TEntity, object>> now.

This could be merged after targeting a newer version of EFCore, which has the corresponding HasIndex() overload.

Comment threaddoc/modeling/indexes.md Outdated
@austindrenskiaustindrenski added the documentation Improvements or additions to documentation label Feb 20, 2019
@KexyBiscuit

KexyBiscuit commented Feb 20, 2019 via email

Copy link
Copy Markdown
ContributorAuthor

@austindrenski

Copy link
Copy Markdown
Contributor

That was explained in the PR summary, HasIndex returns non-generic IndexBuilder, but the expression-based overload accepts only generic IndexBuilder.

Right... but #821 is reacting to dotnet/efcore#14641 which generifiesHasIndex(...).

Since our release cadence follows the main EF Core project, the generic HasIndex(...) will be available by the time the documentation is published.

@KexyBiscuitKexyBiscuit changed the title Update doc as #821.[WIP] Update doc as #821.Feb 21, 2019
@KexyBiscuit

Copy link
Copy Markdown
ContributorAuthor

I'd like this to be merged after something like #833, since the latest CI version still doesn't support the generic HasIndex.

@roji

roji commented Mar 1, 2019

Copy link
Copy Markdown
Member

IIRC merging doc changes into dev doesn't make them live in any way - we generate docs from the master branch. So it should be fine to merge this to dev for 3.0 (I'll leave that to @austindrenski).

@austindrenski
austindrenski merged commit eea4af4 into npgsql:devMar 3, 2019
@austindrenskiaustindrenski changed the title [WIP] Update doc as #821.Update docs following 821Mar 3, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@KexyBiscuit@austindrenski@roji@khellang@YohDeadfall