Skip to content

fix: revert install-links default back to false - #6142

Merged
lukekarrys merged 1 commit into
latestfrom
nlf/revert-install-links
Feb 7, 2023
Merged

fix: revert install-links default back to false#6142
lukekarrys merged 1 commit into
latestfrom
nlf/revert-install-links

Conversation

@nlf

@nlfnlf commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

this new default was unintentionally breaking so we are reverting it as a bug fix, see nodejs/node#46542

note that this is technically a breaking change. however, since the new default was not delivered appropriately we are reverting this in a patch release as we consider it a bug fix.

if you have already updated to npm@9 and your project includes dependencies using the file: protocol, then it is possible that this change will cause the npm ci command to fail informing you that your package.json and package-lock.json are out of sync. if this happens, re-running npm install will correct the lockfile and cause the npm ci command to work again as expected.

this new default was unintentionally breaking so we are reverting it as a bug fix, see nodejs/node#46542
@nlf
nlf requested a review from a team as a code ownerFebruary 7, 2023 17:24
@nlf
nlf requested review from wraithgar and removed request for a teamFebruary 7, 2023 17:24
@npm-cli-bot

Copy link
Copy Markdown
Collaborator

no statistically significant performance changes detected

timing results
app-largecleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@843.418 ±7.2018.400 ±0.3217.055 ±0.1019.955 ±0.653.127 ±0.053.103 ±0.042.616 ±0.1211.919 ±0.262.545 ±0.094.003 ±0.11
#614244.560 ±4.7818.457 ±0.2416.924 ±0.3019.754 ±1.223.141 ±0.033.132 ±0.042.492 ±0.1111.815 ±0.152.388 ±0.173.727 ±0.37
app-mediumcleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@829.238 ±2.1414.663 ±0.0213.184 ±0.0514.015 ±0.282.827 ±0.062.791 ±0.012.601 ±0.019.139 ±0.002.392 ±0.035.059 ±2.35
#614230.964 ±1.9814.695 ±0.2413.110 ±0.0714.474 ±0.232.831 ±0.042.868 ±0.072.423 ±0.019.168 ±0.082.264 ±0.043.255 ±0.02

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukekarrys
lukekarrys merged commit d02da52 into latestFeb 7, 2023
@lukekarrys
lukekarrys deleted the nlf/revert-install-links branch February 7, 2023 20:28
@github-actionsgithub-actionsBot mentioned this pull request Feb 7, 2023
jhheider added a commit to pkgxdev/pantry.core that referenced this pull request Feb 7, 2023
@jhheiderjhheider mentioned this pull request Feb 7, 2023
jhheider added a commit to pkgxdev/pantry.core that referenced this pull request Feb 7, 2023
ascott18 added a commit to IntelliTect/Coalesce that referenced this pull request Feb 17, 2023
max-sixty added a commit to max-sixty/prql that referenced this pull request Sep 2, 2023
This is no longer needed; the npm change was reverted in `9.4.0`: npm/cli#6142
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nlf@npm-cli-bot@MylesBorins@lukekarrys