Skip to content
This repository was archived by the owner on Mar 15, 2023. It is now read-only.

fix(npm) - #216

Merged
jhheider merged 1 commit into
mainfrom
fix(npm)
Feb 7, 2023
Merged

fix(npm)#216
jhheider merged 1 commit into
mainfrom
fix(npm)

Conversation

@jhheider

@jhheiderjhheider commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

ref npm/cli#6142

fixes#213
fixes#214
fixes#215

@what-the-diff

Copy link
Copy Markdown
  • The test command was changed to include a pipe and two commands.
  • A new line of code was added that checks if npx is installed on the system, which it should be since we just ran npm install in the build step above.
  • Another new line of code lists all files in {{prefix}}/bin directory (which will contain our newly built tldr binary). This helps us verify that everything worked as expected during installation process by checking for presence of this file after running npm run test.

@jhheider
jhheiderforce-pushed the fix(npm) branch 3 times, most recently from b2d30fc to 25457d8CompareFebruary 7, 2023 21:47
@jhheider
jhheider merged commit 55f39f4 into mainFeb 7, 2023
@jhheider
jhheider deleted the fix(npm) branch February 7, 2023 22:30
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

1 participant

@jhheider