Skip to content

update: re-enable updating local packages - #73

Closed
larsgw wants to merge 16 commits into
npm:release-nextfrom
larsgw:patch-2
Closed

update: re-enable updating local packages#73
larsgw wants to merge 16 commits into
npm:release-nextfrom
larsgw:patch-2

Conversation

@larsgw

@larsgwlarsgw commented Oct 2, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

PR npm/npm#11584 removed the possibility of updating local packages (linked with symlinks) with npm update.
Reason was that this functionality didn't work in v3.6.0. However, the system behind local dependencies
has since changed, and I can't reproduce the original error anymore.

Reverts 53cdb96
See discussion in https://npm.community/t/1725

@larsgw
larsgw requested a review from a team as a code ownerOctober 2, 2018 18:28
@zkat
zkat changed the base branch from latest to release-nextNovember 13, 2018 15:00
@zkat

zkat commented Nov 13, 2018

Copy link
Copy Markdown
Contributor

I'd like an 👀 from @iarna on this one.

@jmfNodejsUser

jmfNodejsUser commented Jan 8, 2019

Copy link
Copy Markdown

Hello,
Is this correction now available in 6.4.1 ?

@iarna

iarna commented Jan 8, 2019

Copy link
Copy Markdown
Contributor

@jmfNodejsUser It is not, it's not yet been merged.

iarna
iarna suggested changes Jan 8, 2019
View reviewed changes

@iarnaiarna left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it took me a bit to wrap my head around what this was doing:

This is fixing a problem where npm update won't auto-heal missing links. (The work around is to run npm i instead, which will.)

I approve of this idea, but there are two things that need to be addressed before it lands:

  1. It needs a test (this would have helped us understand what the patch was hoping to achieve)
  2. With this patch and a file: type dep, npm outdated -l crashes, this'll need to be fixed.

@jmfNodejsUser

jmfNodejsUser commented Jan 9, 2019

Copy link
Copy Markdown

Thank you for the reply iarna.
How can I help to test this change? OR will somebody from the leader team test the modification?

Your suggestion to use npm i works and installs/links the first/primary dependency (local node module) in the main project. All sub dependencies of the local node modules are not installed/linked. Except when I delete the package-lock.json first and then run "npm i". In this case, it works and installs all primary and sub dependencies which are all local node modules(i.e. not from the npm registry)

@jmfNodejsUser

jmfNodejsUser commented Jan 10, 2019

Copy link
Copy Markdown

The problem with using "npm i" is the same mentioned in
https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754

@zkat
zkatforce-pushed the release-next branch 2 times, most recently from 6ca2f43 to 6d0cc95CompareJanuary 18, 2019 19:17
@larsgw

larsgw commented Jan 18, 2019

Copy link
Copy Markdown
ContributorAuthor

Sorry for the confusion. I added tests. As for the npm outdated -l crash, that should be fixed in #124.

@zkat
zkatforce-pushed the release-next branch 3 times, most recently from db63b89 to b09bc8cCompareJanuary 23, 2019 18:36
zkatand others added 14 commits January 24, 2019 11:24
@zkat
npm-registry-fetch@3.9.0
671cad1
Make sure publishing with legacy username:password _auth works again
@watildeAudrey Eschright
doc: use const in lib/fetch-package-metadata.md (npm#120)
89b23a5
PR-URL: npm#120
Credit: @watilde
Reviewed-By: @aeschright
@watilde@aeschright
misc: replace ronn with marked-man (npm#126)
4970d55
PR-URL: npm#126
Credit: @watilde
Reviewed-By: @aeschright
@elidoran@aeschright
Reduce work to test if executable ends with a 'g'. (npm#138)
d9b6090
PR-URL: npm#138
Credit: @elidoran
Reviewed-By: @aeschright
@larsgw@aeschright
test(maketest): Fix common.npm callback arguments (npm#144)
cdb0592
PR-URL: npm#144
Credit: @larsgw
Reviewed-By: @aeschright
@sokra@aeschright
install/dedupe: fix hoisting of packages with peerDeps (npm#147)
91314e7
PR-URL: npm#147
Fixes: https://npm.community/t/packages-with-peerdependencies-are-incorrectly-hoisted/4794
Credit: @sokra
Reviewed-By: @aeschright
@larsgw@aeschright
ls: show installed but unmet peer deps (npm#145)
25573e9
PR-URL: npm#145
Fixes: https://npm.community/t/4770
Credit: @larsgw
Reviewed-By: @aeschright
@greysteil@aeschright
doc: update package.json docs to include repository.directory details (…
3663cde
…npm#140)
PR-URL: npm#140
Credit: @greysteil
Reviewed-By: @aeschright
@zkat@aeschright
token: use figgy-config to make sure extra opts are there (npm#149)
ce2c4bd
PR-URL: npm#149
Credit: @zkat
Reviewed-By: @aeschright
Audrey Eschright
pacote@9.4.1
95ca1ae
Audrey Eschright
chore: add changelog for v6.8.0
dacc47d
Audrey Eschright
update AUTHORS
f28a94c
Audrey Eschright
6.8.0-next.0
309260d
@zkat@aeschright
access: ls-collaborators is ok with non-scoped (npm#151)
3c22d1a
PR-URL: npm#151
Fixes: https://npm.community/t/npm-6-6-0-breaks-access-to-ls-collaborators/5101
Credit: @zkat
Reviewed-By: @aeschright
@jmfNodejsUser

jmfNodejsUser commented Feb 5, 2019

Copy link
Copy Markdown

Hello @zkat , @iarna ,
Has this correction been merged into version 6.7.0 release?
I tried downloading version 6.7.0 and testing it.
The "npm update" still does not work for local node modules.

@larsgw ,
This problem started after npm version 5.6.0 and exists till now. So I think, that the change in v3.6.0 is probably not the reason for these problems since 5.6.0.
The workaround by using "npm install" still needs a deletion of the package-lock.json.

@larsgw
update: re-enable updating local packages
a853ac7
PR #11584 removed the possibility of updating local
packages (linked with symlinks) with `npm update`.
Reason was that this functionality didn't work in
v3.6.0. However, the system behind local dependencies
has since changed, and I can't reproduce the original
error anymore.
Reverts 59e5056
@larsgw
test: update & outdated local packages
4d16575
@zkatzkat added semver:patch semver patch level for changes and removed needs-discussion labels Feb 11, 2019
zkat
zkat approved these changes Feb 11, 2019
View reviewed changes

@zkatzkat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing things up. This looks like it fulfill's @iarna's requirements, so we're good to go. 👍

zkat pushed a commit that referenced this pull request Feb 18, 2019
@larsgw@zkat
update: re-enable updating local packages
e135c2b
PR #11584 removed the possibility of updating local
packages (linked with symlinks) with `npm update`.
Reason was that this functionality didn't work in
v3.6.0. However, the system behind local dependencies
has since changed, and I can't reproduce the original
error anymore.
Reverts 59e5056
Fixes: https://npm.community/t/1725?u=larsgw
PR-URL: #73
Credit: @larsgw
Reviewed-By: @iarna
Reviewed-By: @zkat
@zkat

zkat commented Feb 18, 2019

Copy link
Copy Markdown
Contributor

This has been merged by hand. Thanks again, @larsgw!

@zkatzkat closed this Feb 18, 2019
@snyk-botsnyk-bot mentioned this pull request Jun 16, 2022
Open
Jah-yee pushed a commit to Jah-yee/cli that referenced this pull request Apr 16, 2026
@Bortlesboat@claude
fix: filter alertcenter scopes from user OAuth login flow (npm#108)
a6994ad
* fix: filter alertcenter scopes from user OAuth login flow
The `apps.alerts` scope is restricted to service accounts with
domain-wide delegation and fails with `400 invalid_scope` when
used in the standard 3-legged OAuth consent flow. Filter it out
alongside the existing chat.app/chat.bot/keep exclusions.
Fixesnpm#73
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix: also filter apps.alerts in is_app_only_scope()
The scope filter exists in two locations: setup.rs (fetch_scopes_for_apis)
and auth_commands.rs (is_app_only_scope). Both need the apps.alerts
exclusion to prevent it from appearing in the interactive scope picker.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* chore: retrigger CLA check
* chore: retrigger CI after CLA signing
---------
Co-authored-by: Andrew Barnes <andrew.jaguars@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Jun 23, 2026
@github-actions
📊 대시보드 데이터 업데이트 (npm#73)
451e7c5
github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Jul 1, 2026
@github-actions
🤖 봇 응답 (npm#73)
506319d
github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Jul 10, 2026
@github-actions
🔧 자동 수리 완료 (npm#73)
4338f69
github-actionsBot added a commit to Kevinlee7250/cli that referenced this pull request Aug 1, 2026
@github-actions
🔥 트렌드 선점 후보 갱신 (npm#73)
8d35207
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@iarnaiarnaiarna requested changes
@zkatzkatzkat approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver:patchsemver patch level for changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@larsgw@zkat@jmfNodejsUser@iarna@watilde@elidoran@sokra@greysteil
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
update: re-enable updating local packages by larsgw · Pull Request #73 · npm/cli · GitHub
Skip to content
update: re-enable updating local packages - #73
Closed
larsgw wants to merge 16 commits into
npm:release-nextfrom 
larsgw:patch-2
Closed
update: re-enable updating local packages#73
larsgw wants to merge 16 commits into
npm:release-nextfrom 
larsgw:patch-2
Conversation
@larsgw
@larsgwlarsgw
commented
Oct 2, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
PR npm/npm#11584 removed the possibility of updating local packages (linked with symlinks) with npm update.

Reason was that this functionality didn't work in v3.6.0. However, the system behind local dependencies

has since changed, and I can't reproduce the original error anymore.
Reverts 53cdb96

See discussion in https://npm.community/t/1725
@larsgw
larsgw
requested a review
from a team
as a code ownerOctober 2, 2018 18:28
@zkat
zkat
changed the base branch from
latest
to
release-nextNovember 13, 2018 15:00
@zkat
zkat
commented
Nov 13, 2018

Copy link


Copy Markdown

Contributor
I'd like an 👀 from @iarna on this one.
@jmfNodejsUser
jmfNodejsUser
commented
Jan 8, 2019

Copy link


Copy Markdown

Hello,

Is this correction now available in 6.4.1 ?
@iarna
iarna
commented
Jan 8, 2019

Copy link


Copy Markdown

Contributor
@jmfNodejsUser It is not, it's not yet been merged.
iarna
iarna
suggested changes
Jan 8, 2019
View reviewed changes
@iarnaiarna
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it took me a bit to wrap my head around what this was doing:
This is fixing a problem where npm update won't auto-heal missing links. (The work around is to run npm i instead, which will.)
I approve of this idea, but there are two things that need to be addressed before it lands:
  1. It needs a test (this would have helped us understand what the patch was hoping to achieve)
  2. With this patch and a file: type dep, npm outdated -l crashes, this'll need to be fixed.
@jmfNodejsUser
jmfNodejsUser
commented
Jan 9, 2019

Copy link


Copy Markdown

Thank you for the reply iarna.

How can I help to test this change? OR will somebody from the leader team test the modification?
Your suggestion to use npm i works and installs/links the first/primary dependency (local node module) in the main project. All sub dependencies of the local node modules are not installed/linked. Except when I delete the package-lock.json first and then run "npm i". In this case, it works and installs all primary and sub dependencies which are all local node modules(i.e. not from the npm registry)
@jmfNodejsUser
jmfNodejsUser
commented
Jan 10, 2019

Copy link


Copy Markdown

The problem with using "npm i" is the same mentioned in
https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754
@zkat
zkatforce-pushed
the
release-next
branch
2 times, most recently
from
6ca2f43 to
6d0cc95CompareJanuary 18, 2019 19:17
@larsgw
larsgw
commented
Jan 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Sorry for the confusion. I added tests. As for the npm outdated -l crash, that should be fixed in #124.
@zkat
zkatforce-pushed
the
release-next
branch
3 times, most recently
from
db63b89 to
b09bc8cCompareJanuary 23, 2019 18:36
zkatand others
added 14 commits
January 24, 2019 11:24
@zkat
npm-registry-fetch@3.9.0
671cad1
Make sure publishing with legacy username:password _auth works again
@watildeAudrey Eschright
doc: use const in lib/fetch-package-metadata.md (npm#120)
89b23a5
PR-URL: npm#120
Credit: @watilde
Reviewed-By: @aeschright
@watilde@aeschright
misc: replace ronn with marked-man (npm#126)
4970d55
PR-URL: npm#126
Credit: @watilde
Reviewed-By: @aeschright
@elidoran@aeschright
Reduce work to test if executable ends with a 'g'. (npm#138)
d9b6090
PR-URL: npm#138
Credit: @elidoran
Reviewed-By: @aeschright
@larsgw@aeschright
test(maketest): Fix common.npm callback arguments (npm#144)
cdb0592
PR-URL: npm#144
Credit: @larsgw
Reviewed-By: @aeschright
@sokra@aeschright
install/dedupe: fix hoisting of packages with peerDeps (npm#147)
91314e7
PR-URL: npm#147
Fixes: https://npm.community/t/packages-with-peerdependencies-are-incorrectly-hoisted/4794
Credit: @sokra
Reviewed-By: @aeschright
@larsgw@aeschright
ls: show installed but unmet peer deps (npm#145)
25573e9
PR-URL: npm#145
Fixes: https://npm.community/t/4770
Credit: @larsgw
Reviewed-By: @aeschright
@greysteil@aeschright
doc: update package.json docs to include repository.directory details (…
3663cde
…npm#140)
PR-URL: npm#140
Credit: @greysteil
Reviewed-By: @aeschright
@zkat@aeschright
token: use figgy-config to make sure extra opts are there (npm#149)
ce2c4bd
PR-URL: npm#149
Credit: @zkat
Reviewed-By: @aeschright
Audrey Eschright
pacote@9.4.1
95ca1ae
Audrey Eschright
chore: add changelog for v6.8.0
dacc47d
Audrey Eschright
update AUTHORS
f28a94c
Audrey Eschright
6.8.0-next.0
309260d
@zkat@aeschright
access: ls-collaborators is ok with non-scoped (npm#151)
3c22d1a
PR-URL: npm#151
Fixes: https://npm.community/t/npm-6-6-0-breaks-access-to-ls-collaborators/5101
Credit: @zkat
Reviewed-By: @aeschright
@jmfNodejsUser
jmfNodejsUser
commented
Feb 5, 2019

Copy link


Copy Markdown

Hello @zkat , @iarna ,

Has this correction been merged into version 6.7.0 release?

I tried downloading version 6.7.0 and testing it.

The "npm update" still does not work for local node modules.
@larsgw ,

This problem started after npm version 5.6.0 and exists till now. So I think, that the change in v3.6.0 is probably not the reason for these problems since 5.6.0.

The workaround by using "npm install" still needs a deletion of the package-lock.json.
@larsgw
update: re-enable updating local packages
a853ac7
PR #11584 removed the possibility of updating local
packages (linked with symlinks) with `npm update`.
Reason was that this functionality didn't work in
v3.6.0. However, the system behind local dependencies
has since changed, and I can't reproduce the original
error anymore.
Reverts 59e5056
@larsgw
test: update & outdated local packages
4d16575
@zkatzkat
added

semver:patch
semver patch level for changes
and removed

needs-discussion

labels
Feb 11, 2019
zkat
zkat
approved these changes
Feb 11, 2019
View reviewed changes
@zkatzkat
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing things up. This looks like it fulfill's @iarna's requirements, so we're good to go. 👍
zkat pushed a commit
that referenced
this pull request
Feb 18, 2019
@larsgw@zkat
update: re-enable updating local packages
e135c2b
PR #11584 removed the possibility of updating local
packages (linked with symlinks) with `npm update`.
Reason was that this functionality didn't work in
v3.6.0. However, the system behind local dependencies
has since changed, and I can't reproduce the original
error anymore.
Reverts 59e5056
Fixes: https://npm.community/t/1725?u=larsgw
PR-URL: #73
Credit: @larsgw
Reviewed-By: @iarna
Reviewed-By: @zkat
@zkat
zkat
commented
Feb 18, 2019

Copy link


Copy Markdown

Contributor
This has been merged by hand. Thanks again, @larsgw!
@zkatzkat
closed this
Feb 18, 2019
@snyk-botsnyk-bot
mentioned this pull request
Jun 16, 2022
 Open

Jah-yee pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
@Bortlesboat@claude
fix: filter alertcenter scopes from user OAuth login flow (npm#108)
a6994ad
* fix: filter alertcenter scopes from user OAuth login flow
The `apps.alerts` scope is restricted to service accounts with
domain-wide delegation and fails with `400 invalid_scope` when
used in the standard 3-legged OAuth consent flow. Filter it out
alongside the existing chat.app/chat.bot/keep exclusions.
Fixesnpm#73
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix: also filter apps.alerts in is_app_only_scope()
The scope filter exists in two locations: setup.rs (fetch_scopes_for_apis)
and auth_commands.rs (is_app_only_scope). Both need the apps.alerts
exclusion to prevent it from appearing in the interactive scope picker.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* chore: retrigger CLA check
* chore: retrigger CI after CLA signing
---------
Co-authored-by: Andrew Barnes <andrew.jaguars@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jun 23, 2026
@github-actions
📊 대시보드 데이터 업데이트 (npm#73)
451e7c5
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jul 1, 2026
@github-actions
🤖 봇 응답 (npm#73)
506319d
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jul 10, 2026
@github-actions
🔧 자동 수리 완료 (npm#73)
4338f69
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Aug 1, 2026
@github-actions
🔥 트렌드 선점 후보 갱신 (npm#73)
8d35207
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@iarnaiarnaiarna requested changes
@zkatzkatzkat approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

semver:patchsemver patch level for changes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@larsgw@zkat@jmfNodejsUser@iarna@watilde@elidoran@sokra@greysteil

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
update: re-enable updating local packages by larsgw · Pull Request #73 · npm/cli · GitHub
Skip to content
update: re-enable updating local packages - #73
Closed
larsgw wants to merge 16 commits into
npm:release-nextfrom 
larsgw:patch-2
Closed
update: re-enable updating local packages#73
larsgw wants to merge 16 commits into
npm:release-nextfrom 
larsgw:patch-2
Conversation
@larsgw
@larsgwlarsgw
commented
Oct 2, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
PR npm/npm#11584 removed the possibility of updating local packages (linked with symlinks) with npm update.

Reason was that this functionality didn't work in v3.6.0. However, the system behind local dependencies

has since changed, and I can't reproduce the original error anymore.
Reverts 53cdb96

See discussion in https://npm.community/t/1725
@larsgw
larsgw
requested a review
from a team
as a code ownerOctober 2, 2018 18:28
@zkat
zkat
changed the base branch from
latest
to
release-nextNovember 13, 2018 15:00
@zkat
zkat
commented
Nov 13, 2018

Copy link


Copy Markdown

Contributor
I'd like an 👀 from @iarna on this one.
@jmfNodejsUser
jmfNodejsUser
commented
Jan 8, 2019

Copy link


Copy Markdown

Hello,

Is this correction now available in 6.4.1 ?
@iarna
iarna
commented
Jan 8, 2019

Copy link


Copy Markdown

Contributor
@jmfNodejsUser It is not, it's not yet been merged.
iarna
iarna
suggested changes
Jan 8, 2019
View reviewed changes
@iarnaiarna
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it took me a bit to wrap my head around what this was doing:
This is fixing a problem where npm update won't auto-heal missing links. (The work around is to run npm i instead, which will.)
I approve of this idea, but there are two things that need to be addressed before it lands:
  1. It needs a test (this would have helped us understand what the patch was hoping to achieve)
  2. With this patch and a file: type dep, npm outdated -l crashes, this'll need to be fixed.
@jmfNodejsUser
jmfNodejsUser
commented
Jan 9, 2019

Copy link


Copy Markdown

Thank you for the reply iarna.

How can I help to test this change? OR will somebody from the leader team test the modification?
Your suggestion to use npm i works and installs/links the first/primary dependency (local node module) in the main project. All sub dependencies of the local node modules are not installed/linked. Except when I delete the package-lock.json first and then run "npm i". In this case, it works and installs all primary and sub dependencies which are all local node modules(i.e. not from the npm registry)
@jmfNodejsUser
jmfNodejsUser
commented
Jan 10, 2019

Copy link


Copy Markdown

The problem with using "npm i" is the same mentioned in
https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754
@zkat
zkatforce-pushed
the
release-next
branch
2 times, most recently
from
6ca2f43 to
6d0cc95CompareJanuary 18, 2019 19:17
@larsgw
larsgw
commented
Jan 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Sorry for the confusion. I added tests. As for the npm outdated -l crash, that should be fixed in #124.
@zkat
zkatforce-pushed
the
release-next
branch
3 times, most recently
from
db63b89 to
b09bc8cCompareJanuary 23, 2019 18:36
zkatand others
added 14 commits
January 24, 2019 11:24
@zkat
npm-registry-fetch@3.9.0
671cad1
Make sure publishing with legacy username:password _auth works again
@watildeAudrey Eschright
doc: use const in lib/fetch-package-metadata.md (npm#120)
89b23a5
PR-URL: npm#120
Credit: @watilde
Reviewed-By: @aeschright
@watilde@aeschright
misc: replace ronn with marked-man (npm#126)
4970d55
PR-URL: npm#126
Credit: @watilde
Reviewed-By: @aeschright
@elidoran@aeschright
Reduce work to test if executable ends with a 'g'. (npm#138)
d9b6090
PR-URL: npm#138
Credit: @elidoran
Reviewed-By: @aeschright
@larsgw@aeschright
test(maketest): Fix common.npm callback arguments (npm#144)
cdb0592
PR-URL: npm#144
Credit: @larsgw
Reviewed-By: @aeschright
@sokra@aeschright
install/dedupe: fix hoisting of packages with peerDeps (npm#147)
91314e7
PR-URL: npm#147
Fixes: https://npm.community/t/packages-with-peerdependencies-are-incorrectly-hoisted/4794
Credit: @sokra
Reviewed-By: @aeschright
@larsgw@aeschright
ls: show installed but unmet peer deps (npm#145)
25573e9
PR-URL: npm#145
Fixes: https://npm.community/t/4770
Credit: @larsgw
Reviewed-By: @aeschright
@greysteil@aeschright
doc: update package.json docs to include repository.directory details (…
3663cde
…npm#140)
PR-URL: npm#140
Credit: @greysteil
Reviewed-By: @aeschright
@zkat@aeschright
token: use figgy-config to make sure extra opts are there (npm#149)
ce2c4bd
PR-URL: npm#149
Credit: @zkat
Reviewed-By: @aeschright
Audrey Eschright
pacote@9.4.1
95ca1ae
Audrey Eschright
chore: add changelog for v6.8.0
dacc47d
Audrey Eschright
update AUTHORS
f28a94c
Audrey Eschright
6.8.0-next.0
309260d
@zkat@aeschright
access: ls-collaborators is ok with non-scoped (npm#151)
3c22d1a
PR-URL: npm#151
Fixes: https://npm.community/t/npm-6-6-0-breaks-access-to-ls-collaborators/5101
Credit: @zkat
Reviewed-By: @aeschright
@jmfNodejsUser
jmfNodejsUser
commented
Feb 5, 2019

Copy link


Copy Markdown

Hello @zkat , @iarna ,

Has this correction been merged into version 6.7.0 release?

I tried downloading version 6.7.0 and testing it.

The "npm update" still does not work for local node modules.
@larsgw ,

This problem started after npm version 5.6.0 and exists till now. So I think, that the change in v3.6.0 is probably not the reason for these problems since 5.6.0.

The workaround by using "npm install" still needs a deletion of the package-lock.json.
@larsgw
update: re-enable updating local packages
a853ac7
PR #11584 removed the possibility of updating local
packages (linked with symlinks) with `npm update`.
Reason was that this functionality didn't work in
v3.6.0. However, the system behind local dependencies
has since changed, and I can't reproduce the original
error anymore.
Reverts 59e5056
@larsgw
test: update & outdated local packages
4d16575
@zkatzkat
added

semver:patch
semver patch level for changes
and removed

needs-discussion

labels
Feb 11, 2019
zkat
zkat
approved these changes
Feb 11, 2019
View reviewed changes
@zkatzkat
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing things up. This looks like it fulfill's @iarna's requirements, so we're good to go. 👍
zkat pushed a commit
that referenced
this pull request
Feb 18, 2019
@larsgw@zkat
update: re-enable updating local packages
e135c2b
PR #11584 removed the possibility of updating local
packages (linked with symlinks) with `npm update`.
Reason was that this functionality didn't work in
v3.6.0. However, the system behind local dependencies
has since changed, and I can't reproduce the original
error anymore.
Reverts 59e5056
Fixes: https://npm.community/t/1725?u=larsgw
PR-URL: #73
Credit: @larsgw
Reviewed-By: @iarna
Reviewed-By: @zkat
@zkat
zkat
commented
Feb 18, 2019

Copy link


Copy Markdown

Contributor
This has been merged by hand. Thanks again, @larsgw!
@zkatzkat
closed this
Feb 18, 2019
@snyk-botsnyk-bot
mentioned this pull request
Jun 16, 2022
 Open

Jah-yee pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
@Bortlesboat@claude
fix: filter alertcenter scopes from user OAuth login flow (npm#108)
a6994ad
* fix: filter alertcenter scopes from user OAuth login flow
The `apps.alerts` scope is restricted to service accounts with
domain-wide delegation and fails with `400 invalid_scope` when
used in the standard 3-legged OAuth consent flow. Filter it out
alongside the existing chat.app/chat.bot/keep exclusions.
Fixesnpm#73
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix: also filter apps.alerts in is_app_only_scope()
The scope filter exists in two locations: setup.rs (fetch_scopes_for_apis)
and auth_commands.rs (is_app_only_scope). Both need the apps.alerts
exclusion to prevent it from appearing in the interactive scope picker.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* chore: retrigger CLA check
* chore: retrigger CI after CLA signing
---------
Co-authored-by: Andrew Barnes <andrew.jaguars@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jun 23, 2026
@github-actions
📊 대시보드 데이터 업데이트 (npm#73)
451e7c5
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jul 1, 2026
@github-actions
🤖 봇 응답 (npm#73)
506319d
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jul 10, 2026
@github-actions
🔧 자동 수리 완료 (npm#73)
4338f69
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Aug 1, 2026
@github-actions
🔥 트렌드 선점 후보 갱신 (npm#73)
8d35207
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@iarnaiarnaiarna requested changes
@zkatzkatzkat approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

semver:patchsemver patch level for changes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@larsgw@zkat@jmfNodejsUser@iarna@watilde@elidoran@sokra@greysteil

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
update: re-enable updating local packages by larsgw · Pull Request #73 · npm/cli · GitHub
Skip to content
update: re-enable updating local packages - #73
Closed
larsgw wants to merge 16 commits into
npm:release-nextfrom 
larsgw:patch-2
Closed
update: re-enable updating local packages#73
larsgw wants to merge 16 commits into
npm:release-nextfrom 
larsgw:patch-2
Conversation
@larsgw
@larsgwlarsgw
commented
Oct 2, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
PR npm/npm#11584 removed the possibility of updating local packages (linked with symlinks) with npm update.

Reason was that this functionality didn't work in v3.6.0. However, the system behind local dependencies

has since changed, and I can't reproduce the original error anymore.
Reverts 53cdb96

See discussion in https://npm.community/t/1725
@larsgw
larsgw
requested a review
from a team
as a code ownerOctober 2, 2018 18:28
@zkat
zkat
changed the base branch from
latest
to
release-nextNovember 13, 2018 15:00
@zkat
zkat
commented
Nov 13, 2018

Copy link


Copy Markdown

Contributor
I'd like an 👀 from @iarna on this one.
@jmfNodejsUser
jmfNodejsUser
commented
Jan 8, 2019

Copy link


Copy Markdown

Hello,

Is this correction now available in 6.4.1 ?
@iarna
iarna
commented
Jan 8, 2019

Copy link


Copy Markdown

Contributor
@jmfNodejsUser It is not, it's not yet been merged.
iarna
iarna
suggested changes
Jan 8, 2019
View reviewed changes
@iarnaiarna
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it took me a bit to wrap my head around what this was doing:
This is fixing a problem where npm update won't auto-heal missing links. (The work around is to run npm i instead, which will.)
I approve of this idea, but there are two things that need to be addressed before it lands:
  1. It needs a test (this would have helped us understand what the patch was hoping to achieve)
  2. With this patch and a file: type dep, npm outdated -l crashes, this'll need to be fixed.
@jmfNodejsUser
jmfNodejsUser
commented
Jan 9, 2019

Copy link


Copy Markdown

Thank you for the reply iarna.

How can I help to test this change? OR will somebody from the leader team test the modification?
Your suggestion to use npm i works and installs/links the first/primary dependency (local node module) in the main project. All sub dependencies of the local node modules are not installed/linked. Except when I delete the package-lock.json first and then run "npm i". In this case, it works and installs all primary and sub dependencies which are all local node modules(i.e. not from the npm registry)
@jmfNodejsUser
jmfNodejsUser
commented
Jan 10, 2019

Copy link


Copy Markdown

The problem with using "npm i" is the same mentioned in
https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754
@zkat
zkatforce-pushed
the
release-next
branch
2 times, most recently
from
6ca2f43 to
6d0cc95CompareJanuary 18, 2019 19:17
@larsgw
larsgw
commented
Jan 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Sorry for the confusion. I added tests. As for the npm outdated -l crash, that should be fixed in #124.
@zkat
zkatforce-pushed
the
release-next
branch
3 times, most recently
from
db63b89 to
b09bc8cCompareJanuary 23, 2019 18:36
zkatand others
added 14 commits
January 24, 2019 11:24
@zkat
npm-registry-fetch@3.9.0
671cad1
Make sure publishing with legacy username:password _auth works again
@watildeAudrey Eschright
doc: use const in lib/fetch-package-metadata.md (npm#120)
89b23a5
PR-URL: npm#120
Credit: @watilde
Reviewed-By: @aeschright
@watilde@aeschright
misc: replace ronn with marked-man (npm#126)
4970d55
PR-URL: npm#126
Credit: @watilde
Reviewed-By: @aeschright
@elidoran@aeschright
Reduce work to test if executable ends with a 'g'. (npm#138)
d9b6090
PR-URL: npm#138
Credit: @elidoran
Reviewed-By: @aeschright
@larsgw@aeschright
test(maketest): Fix common.npm callback arguments (npm#144)
cdb0592
PR-URL: npm#144
Credit: @larsgw
Reviewed-By: @aeschright
@sokra@aeschright
install/dedupe: fix hoisting of packages with peerDeps (npm#147)
91314e7
PR-URL: npm#147
Fixes: https://npm.community/t/packages-with-peerdependencies-are-incorrectly-hoisted/4794
Credit: @sokra
Reviewed-By: @aeschright
@larsgw@aeschright
ls: show installed but unmet peer deps (npm#145)
25573e9
PR-URL: npm#145
Fixes: https://npm.community/t/4770
Credit: @larsgw
Reviewed-By: @aeschright
@greysteil@aeschright
doc: update package.json docs to include repository.directory details (…
3663cde
…npm#140)
PR-URL: npm#140
Credit: @greysteil
Reviewed-By: @aeschright
@zkat@aeschright
token: use figgy-config to make sure extra opts are there (npm#149)
ce2c4bd
PR-URL: npm#149
Credit: @zkat
Reviewed-By: @aeschright
Audrey Eschright
pacote@9.4.1
95ca1ae
Audrey Eschright
chore: add changelog for v6.8.0
dacc47d
Audrey Eschright
update AUTHORS
f28a94c
Audrey Eschright
6.8.0-next.0
309260d
@zkat@aeschright
access: ls-collaborators is ok with non-scoped (npm#151)
3c22d1a
PR-URL: npm#151
Fixes: https://npm.community/t/npm-6-6-0-breaks-access-to-ls-collaborators/5101
Credit: @zkat
Reviewed-By: @aeschright
@jmfNodejsUser
jmfNodejsUser
commented
Feb 5, 2019

Copy link


Copy Markdown

Hello @zkat , @iarna ,

Has this correction been merged into version 6.7.0 release?

I tried downloading version 6.7.0 and testing it.

The "npm update" still does not work for local node modules.
@larsgw ,

This problem started after npm version 5.6.0 and exists till now. So I think, that the change in v3.6.0 is probably not the reason for these problems since 5.6.0.

The workaround by using "npm install" still needs a deletion of the package-lock.json.
@larsgw
update: re-enable updating local packages
a853ac7
PR #11584 removed the possibility of updating local
packages (linked with symlinks) with `npm update`.
Reason was that this functionality didn't work in
v3.6.0. However, the system behind local dependencies
has since changed, and I can't reproduce the original
error anymore.
Reverts 59e5056
@larsgw
test: update & outdated local packages
4d16575
@zkatzkat
added

semver:patch
semver patch level for changes
and removed

needs-discussion

labels
Feb 11, 2019
zkat
zkat
approved these changes
Feb 11, 2019
View reviewed changes
@zkatzkat
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing things up. This looks like it fulfill's @iarna's requirements, so we're good to go. 👍
zkat pushed a commit
that referenced
this pull request
Feb 18, 2019
@larsgw@zkat
update: re-enable updating local packages
e135c2b
PR #11584 removed the possibility of updating local
packages (linked with symlinks) with `npm update`.
Reason was that this functionality didn't work in
v3.6.0. However, the system behind local dependencies
has since changed, and I can't reproduce the original
error anymore.
Reverts 59e5056
Fixes: https://npm.community/t/1725?u=larsgw
PR-URL: #73
Credit: @larsgw
Reviewed-By: @iarna
Reviewed-By: @zkat
@zkat
zkat
commented
Feb 18, 2019

Copy link


Copy Markdown

Contributor
This has been merged by hand. Thanks again, @larsgw!
@zkatzkat
closed this
Feb 18, 2019
@snyk-botsnyk-bot
mentioned this pull request
Jun 16, 2022
 Open

Jah-yee pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
@Bortlesboat@claude
fix: filter alertcenter scopes from user OAuth login flow (npm#108)
a6994ad
* fix: filter alertcenter scopes from user OAuth login flow
The `apps.alerts` scope is restricted to service accounts with
domain-wide delegation and fails with `400 invalid_scope` when
used in the standard 3-legged OAuth consent flow. Filter it out
alongside the existing chat.app/chat.bot/keep exclusions.
Fixesnpm#73
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix: also filter apps.alerts in is_app_only_scope()
The scope filter exists in two locations: setup.rs (fetch_scopes_for_apis)
and auth_commands.rs (is_app_only_scope). Both need the apps.alerts
exclusion to prevent it from appearing in the interactive scope picker.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* chore: retrigger CLA check
* chore: retrigger CI after CLA signing
---------
Co-authored-by: Andrew Barnes <andrew.jaguars@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jun 23, 2026
@github-actions
📊 대시보드 데이터 업데이트 (npm#73)
451e7c5
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jul 1, 2026
@github-actions
🤖 봇 응답 (npm#73)
506319d
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jul 10, 2026
@github-actions
🔧 자동 수리 완료 (npm#73)
4338f69
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Aug 1, 2026
@github-actions
🔥 트렌드 선점 후보 갱신 (npm#73)
8d35207
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@iarnaiarnaiarna requested changes
@zkatzkatzkat approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

semver:patchsemver patch level for changes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@larsgw@zkat@jmfNodejsUser@iarna@watilde@elidoran@sokra@greysteil

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
update: re-enable updating local packages by larsgw · Pull Request #73 · npm/cli · GitHub
Skip to content
update: re-enable updating local packages - #73
Closed
larsgw wants to merge 16 commits into
npm:release-nextfrom 
larsgw:patch-2
Closed
update: re-enable updating local packages#73
larsgw wants to merge 16 commits into
npm:release-nextfrom 
larsgw:patch-2
Conversation
@larsgw
@larsgwlarsgw
commented
Oct 2, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
PR npm/npm#11584 removed the possibility of updating local packages (linked with symlinks) with npm update.

Reason was that this functionality didn't work in v3.6.0. However, the system behind local dependencies

has since changed, and I can't reproduce the original error anymore.
Reverts 53cdb96

See discussion in https://npm.community/t/1725
@larsgw
larsgw
requested a review
from a team
as a code ownerOctober 2, 2018 18:28
@zkat
zkat
changed the base branch from
latest
to
release-nextNovember 13, 2018 15:00
@zkat
zkat
commented
Nov 13, 2018

Copy link


Copy Markdown

Contributor
I'd like an 👀 from @iarna on this one.
@jmfNodejsUser
jmfNodejsUser
commented
Jan 8, 2019

Copy link


Copy Markdown

Hello,

Is this correction now available in 6.4.1 ?
@iarna
iarna
commented
Jan 8, 2019

Copy link


Copy Markdown

Contributor
@jmfNodejsUser It is not, it's not yet been merged.
iarna
iarna
suggested changes
Jan 8, 2019
View reviewed changes
@iarnaiarna
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it took me a bit to wrap my head around what this was doing:
This is fixing a problem where npm update won't auto-heal missing links. (The work around is to run npm i instead, which will.)
I approve of this idea, but there are two things that need to be addressed before it lands:
  1. It needs a test (this would have helped us understand what the patch was hoping to achieve)
  2. With this patch and a file: type dep, npm outdated -l crashes, this'll need to be fixed.
@jmfNodejsUser
jmfNodejsUser
commented
Jan 9, 2019

Copy link


Copy Markdown

Thank you for the reply iarna.

How can I help to test this change? OR will somebody from the leader team test the modification?
Your suggestion to use npm i works and installs/links the first/primary dependency (local node module) in the main project. All sub dependencies of the local node modules are not installed/linked. Except when I delete the package-lock.json first and then run "npm i". In this case, it works and installs all primary and sub dependencies which are all local node modules(i.e. not from the npm registry)
@jmfNodejsUser
jmfNodejsUser
commented
Jan 10, 2019

Copy link


Copy Markdown

The problem with using "npm i" is the same mentioned in
https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754
@zkat
zkatforce-pushed
the
release-next
branch
2 times, most recently
from
6ca2f43 to
6d0cc95CompareJanuary 18, 2019 19:17
@larsgw
larsgw
commented
Jan 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Sorry for the confusion. I added tests. As for the npm outdated -l crash, that should be fixed in #124.
@zkat
zkatforce-pushed
the
release-next
branch
3 times, most recently
from
db63b89 to
b09bc8cCompareJanuary 23, 2019 18:36
zkatand others
added 14 commits
January 24, 2019 11:24
@zkat
npm-registry-fetch@3.9.0
671cad1
Make sure publishing with legacy username:password _auth works again
@watildeAudrey Eschright
doc: use const in lib/fetch-package-metadata.md (npm#120)
89b23a5
PR-URL: npm#120
Credit: @watilde
Reviewed-By: @aeschright
@watilde@aeschright
misc: replace ronn with marked-man (npm#126)
4970d55
PR-URL: npm#126
Credit: @watilde
Reviewed-By: @aeschright
@elidoran@aeschright
Reduce work to test if executable ends with a 'g'. (npm#138)
d9b6090
PR-URL: npm#138
Credit: @elidoran
Reviewed-By: @aeschright
@larsgw@aeschright
test(maketest): Fix common.npm callback arguments (npm#144)
cdb0592
PR-URL: npm#144
Credit: @larsgw
Reviewed-By: @aeschright
@sokra@aeschright
install/dedupe: fix hoisting of packages with peerDeps (npm#147)
91314e7
PR-URL: npm#147
Fixes: https://npm.community/t/packages-with-peerdependencies-are-incorrectly-hoisted/4794
Credit: @sokra
Reviewed-By: @aeschright
@larsgw@aeschright
ls: show installed but unmet peer deps (npm#145)
25573e9
PR-URL: npm#145
Fixes: https://npm.community/t/4770
Credit: @larsgw
Reviewed-By: @aeschright
@greysteil@aeschright
doc: update package.json docs to include repository.directory details (…
3663cde
…npm#140)
PR-URL: npm#140
Credit: @greysteil
Reviewed-By: @aeschright
@zkat@aeschright
token: use figgy-config to make sure extra opts are there (npm#149)
ce2c4bd
PR-URL: npm#149
Credit: @zkat
Reviewed-By: @aeschright
Audrey Eschright
pacote@9.4.1
95ca1ae
Audrey Eschright
chore: add changelog for v6.8.0
dacc47d
Audrey Eschright
update AUTHORS
f28a94c
Audrey Eschright
6.8.0-next.0
309260d
@zkat@aeschright
access: ls-collaborators is ok with non-scoped (npm#151)
3c22d1a
PR-URL: npm#151
Fixes: https://npm.community/t/npm-6-6-0-breaks-access-to-ls-collaborators/5101
Credit: @zkat
Reviewed-By: @aeschright
@jmfNodejsUser
jmfNodejsUser
commented
Feb 5, 2019

Copy link


Copy Markdown

Hello @zkat , @iarna ,

Has this correction been merged into version 6.7.0 release?

I tried downloading version 6.7.0 and testing it.

The "npm update" still does not work for local node modules.
@larsgw ,

This problem started after npm version 5.6.0 and exists till now. So I think, that the change in v3.6.0 is probably not the reason for these problems since 5.6.0.

The workaround by using "npm install" still needs a deletion of the package-lock.json.
@larsgw
update: re-enable updating local packages
a853ac7
PR #11584 removed the possibility of updating local
packages (linked with symlinks) with `npm update`.
Reason was that this functionality didn't work in
v3.6.0. However, the system behind local dependencies
has since changed, and I can't reproduce the original
error anymore.
Reverts 59e5056
@larsgw
test: update & outdated local packages
4d16575
@zkatzkat
added

semver:patch
semver patch level for changes
and removed

needs-discussion

labels
Feb 11, 2019
zkat
zkat
approved these changes
Feb 11, 2019
View reviewed changes
@zkatzkat
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing things up. This looks like it fulfill's @iarna's requirements, so we're good to go. 👍
zkat pushed a commit
that referenced
this pull request
Feb 18, 2019
@larsgw@zkat
update: re-enable updating local packages
e135c2b
PR #11584 removed the possibility of updating local
packages (linked with symlinks) with `npm update`.
Reason was that this functionality didn't work in
v3.6.0. However, the system behind local dependencies
has since changed, and I can't reproduce the original
error anymore.
Reverts 59e5056
Fixes: https://npm.community/t/1725?u=larsgw
PR-URL: #73
Credit: @larsgw
Reviewed-By: @iarna
Reviewed-By: @zkat
@zkat
zkat
commented
Feb 18, 2019

Copy link


Copy Markdown

Contributor
This has been merged by hand. Thanks again, @larsgw!
@zkatzkat
closed this
Feb 18, 2019
@snyk-botsnyk-bot
mentioned this pull request
Jun 16, 2022
 Open

Jah-yee pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
@Bortlesboat@claude
fix: filter alertcenter scopes from user OAuth login flow (npm#108)
a6994ad
* fix: filter alertcenter scopes from user OAuth login flow
The `apps.alerts` scope is restricted to service accounts with
domain-wide delegation and fails with `400 invalid_scope` when
used in the standard 3-legged OAuth consent flow. Filter it out
alongside the existing chat.app/chat.bot/keep exclusions.
Fixesnpm#73
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix: also filter apps.alerts in is_app_only_scope()
The scope filter exists in two locations: setup.rs (fetch_scopes_for_apis)
and auth_commands.rs (is_app_only_scope). Both need the apps.alerts
exclusion to prevent it from appearing in the interactive scope picker.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* chore: retrigger CLA check
* chore: retrigger CI after CLA signing
---------
Co-authored-by: Andrew Barnes <andrew.jaguars@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jun 23, 2026
@github-actions
📊 대시보드 데이터 업데이트 (npm#73)
451e7c5
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jul 1, 2026
@github-actions
🤖 봇 응답 (npm#73)
506319d
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jul 10, 2026
@github-actions
🔧 자동 수리 완료 (npm#73)
4338f69
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Aug 1, 2026
@github-actions
🔥 트렌드 선점 후보 갱신 (npm#73)
8d35207
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@iarnaiarnaiarna requested changes
@zkatzkatzkat approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

semver:patchsemver patch level for changes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@larsgw@zkat@jmfNodejsUser@iarna@watilde@elidoran@sokra@greysteil

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
update: re-enable updating local packages by larsgw · Pull Request #73 · npm/cli · GitHub
Skip to content
update: re-enable updating local packages - #73
Closed
larsgw wants to merge 16 commits into
npm:release-nextfrom 
larsgw:patch-2
Closed
update: re-enable updating local packages#73
larsgw wants to merge 16 commits into
npm:release-nextfrom 
larsgw:patch-2
Conversation
@larsgw
@larsgwlarsgw
commented
Oct 2, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
PR npm/npm#11584 removed the possibility of updating local packages (linked with symlinks) with npm update.

Reason was that this functionality didn't work in v3.6.0. However, the system behind local dependencies

has since changed, and I can't reproduce the original error anymore.
Reverts 53cdb96

See discussion in https://npm.community/t/1725
@larsgw
larsgw
requested a review
from a team
as a code ownerOctober 2, 2018 18:28
@zkat
zkat
changed the base branch from
latest
to
release-nextNovember 13, 2018 15:00
@zkat
zkat
commented
Nov 13, 2018

Copy link


Copy Markdown

Contributor
I'd like an 👀 from @iarna on this one.
@jmfNodejsUser
jmfNodejsUser
commented
Jan 8, 2019

Copy link


Copy Markdown

Hello,

Is this correction now available in 6.4.1 ?
@iarna
iarna
commented
Jan 8, 2019

Copy link


Copy Markdown

Contributor
@jmfNodejsUser It is not, it's not yet been merged.
iarna
iarna
suggested changes
Jan 8, 2019
View reviewed changes
@iarnaiarna
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it took me a bit to wrap my head around what this was doing:
This is fixing a problem where npm update won't auto-heal missing links. (The work around is to run npm i instead, which will.)
I approve of this idea, but there are two things that need to be addressed before it lands:
  1. It needs a test (this would have helped us understand what the patch was hoping to achieve)
  2. With this patch and a file: type dep, npm outdated -l crashes, this'll need to be fixed.
@jmfNodejsUser
jmfNodejsUser
commented
Jan 9, 2019

Copy link


Copy Markdown

Thank you for the reply iarna.

How can I help to test this change? OR will somebody from the leader team test the modification?
Your suggestion to use npm i works and installs/links the first/primary dependency (local node module) in the main project. All sub dependencies of the local node modules are not installed/linked. Except when I delete the package-lock.json first and then run "npm i". In this case, it works and installs all primary and sub dependencies which are all local node modules(i.e. not from the npm registry)
@jmfNodejsUser
jmfNodejsUser
commented
Jan 10, 2019

Copy link


Copy Markdown

The problem with using "npm i" is the same mentioned in
https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754
@zkat
zkatforce-pushed
the
release-next
branch
2 times, most recently
from
6ca2f43 to
6d0cc95CompareJanuary 18, 2019 19:17
@larsgw
larsgw
commented
Jan 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Sorry for the confusion. I added tests. As for the npm outdated -l crash, that should be fixed in #124.
@zkat
zkatforce-pushed
the
release-next
branch
3 times, most recently
from
db63b89 to
b09bc8cCompareJanuary 23, 2019 18:36
zkatand others
added 14 commits
January 24, 2019 11:24
@zkat
npm-registry-fetch@3.9.0
671cad1
Make sure publishing with legacy username:password _auth works again
@watildeAudrey Eschright
doc: use const in lib/fetch-package-metadata.md (npm#120)
89b23a5
PR-URL: npm#120
Credit: @watilde
Reviewed-By: @aeschright
@watilde@aeschright
misc: replace ronn with marked-man (npm#126)
4970d55
PR-URL: npm#126
Credit: @watilde
Reviewed-By: @aeschright
@elidoran@aeschright
Reduce work to test if executable ends with a 'g'. (npm#138)
d9b6090
PR-URL: npm#138
Credit: @elidoran
Reviewed-By: @aeschright
@larsgw@aeschright
test(maketest): Fix common.npm callback arguments (npm#144)
cdb0592
PR-URL: npm#144
Credit: @larsgw
Reviewed-By: @aeschright
@sokra@aeschright
install/dedupe: fix hoisting of packages with peerDeps (npm#147)
91314e7
PR-URL: npm#147
Fixes: https://npm.community/t/packages-with-peerdependencies-are-incorrectly-hoisted/4794
Credit: @sokra
Reviewed-By: @aeschright
@larsgw@aeschright
ls: show installed but unmet peer deps (npm#145)
25573e9
PR-URL: npm#145
Fixes: https://npm.community/t/4770
Credit: @larsgw
Reviewed-By: @aeschright
@greysteil@aeschright
doc: update package.json docs to include repository.directory details (…
3663cde
…npm#140)
PR-URL: npm#140
Credit: @greysteil
Reviewed-By: @aeschright
@zkat@aeschright
token: use figgy-config to make sure extra opts are there (npm#149)
ce2c4bd
PR-URL: npm#149
Credit: @zkat
Reviewed-By: @aeschright
Audrey Eschright
pacote@9.4.1
95ca1ae
Audrey Eschright
chore: add changelog for v6.8.0
dacc47d
Audrey Eschright
update AUTHORS
f28a94c
Audrey Eschright
6.8.0-next.0
309260d
@zkat@aeschright
access: ls-collaborators is ok with non-scoped (npm#151)
3c22d1a
PR-URL: npm#151
Fixes: https://npm.community/t/npm-6-6-0-breaks-access-to-ls-collaborators/5101
Credit: @zkat
Reviewed-By: @aeschright
@jmfNodejsUser
jmfNodejsUser
commented
Feb 5, 2019

Copy link


Copy Markdown

Hello @zkat , @iarna ,

Has this correction been merged into version 6.7.0 release?

I tried downloading version 6.7.0 and testing it.

The "npm update" still does not work for local node modules.
@larsgw ,

This problem started after npm version 5.6.0 and exists till now. So I think, that the change in v3.6.0 is probably not the reason for these problems since 5.6.0.

The workaround by using "npm install" still needs a deletion of the package-lock.json.
@larsgw
update: re-enable updating local packages
a853ac7
PR #11584 removed the possibility of updating local
packages (linked with symlinks) with `npm update`.
Reason was that this functionality didn't work in
v3.6.0. However, the system behind local dependencies
has since changed, and I can't reproduce the original
error anymore.
Reverts 59e5056
@larsgw
test: update & outdated local packages
4d16575
@zkatzkat
added

semver:patch
semver patch level for changes
and removed

needs-discussion

labels
Feb 11, 2019
zkat
zkat
approved these changes
Feb 11, 2019
View reviewed changes
@zkatzkat
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing things up. This looks like it fulfill's @iarna's requirements, so we're good to go. 👍
zkat pushed a commit
that referenced
this pull request
Feb 18, 2019
@larsgw@zkat
update: re-enable updating local packages
e135c2b
PR #11584 removed the possibility of updating local
packages (linked with symlinks) with `npm update`.
Reason was that this functionality didn't work in
v3.6.0. However, the system behind local dependencies
has since changed, and I can't reproduce the original
error anymore.
Reverts 59e5056
Fixes: https://npm.community/t/1725?u=larsgw
PR-URL: #73
Credit: @larsgw
Reviewed-By: @iarna
Reviewed-By: @zkat
@zkat
zkat
commented
Feb 18, 2019

Copy link


Copy Markdown

Contributor
This has been merged by hand. Thanks again, @larsgw!
@zkatzkat
closed this
Feb 18, 2019
@snyk-botsnyk-bot
mentioned this pull request
Jun 16, 2022
 Open

Jah-yee pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
@Bortlesboat@claude
fix: filter alertcenter scopes from user OAuth login flow (npm#108)
a6994ad
* fix: filter alertcenter scopes from user OAuth login flow
The `apps.alerts` scope is restricted to service accounts with
domain-wide delegation and fails with `400 invalid_scope` when
used in the standard 3-legged OAuth consent flow. Filter it out
alongside the existing chat.app/chat.bot/keep exclusions.
Fixesnpm#73
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix: also filter apps.alerts in is_app_only_scope()
The scope filter exists in two locations: setup.rs (fetch_scopes_for_apis)
and auth_commands.rs (is_app_only_scope). Both need the apps.alerts
exclusion to prevent it from appearing in the interactive scope picker.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* chore: retrigger CLA check
* chore: retrigger CI after CLA signing
---------
Co-authored-by: Andrew Barnes <andrew.jaguars@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jun 23, 2026
@github-actions
📊 대시보드 데이터 업데이트 (npm#73)
451e7c5
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jul 1, 2026
@github-actions
🤖 봇 응답 (npm#73)
506319d
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jul 10, 2026
@github-actions
🔧 자동 수리 완료 (npm#73)
4338f69
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Aug 1, 2026
@github-actions
🔥 트렌드 선점 후보 갱신 (npm#73)
8d35207
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@iarnaiarnaiarna requested changes
@zkatzkatzkat approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

semver:patchsemver patch level for changes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@larsgw@zkat@jmfNodejsUser@iarna@watilde@elidoran@sokra@greysteil

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
update: re-enable updating local packages by larsgw · Pull Request #73 · npm/cli · GitHub
Skip to content
update: re-enable updating local packages - #73
Closed
larsgw wants to merge 16 commits into
npm:release-nextfrom 
larsgw:patch-2
Closed
update: re-enable updating local packages#73
larsgw wants to merge 16 commits into
npm:release-nextfrom 
larsgw:patch-2
Conversation
@larsgw
@larsgwlarsgw
commented
Oct 2, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
PR npm/npm#11584 removed the possibility of updating local packages (linked with symlinks) with npm update.

Reason was that this functionality didn't work in v3.6.0. However, the system behind local dependencies

has since changed, and I can't reproduce the original error anymore.
Reverts 53cdb96

See discussion in https://npm.community/t/1725
@larsgw
larsgw
requested a review
from a team
as a code ownerOctober 2, 2018 18:28
@zkat
zkat
changed the base branch from
latest
to
release-nextNovember 13, 2018 15:00
@zkat
zkat
commented
Nov 13, 2018

Copy link


Copy Markdown

Contributor
I'd like an 👀 from @iarna on this one.
@jmfNodejsUser
jmfNodejsUser
commented
Jan 8, 2019

Copy link


Copy Markdown

Hello,

Is this correction now available in 6.4.1 ?
@iarna
iarna
commented
Jan 8, 2019

Copy link


Copy Markdown

Contributor
@jmfNodejsUser It is not, it's not yet been merged.
iarna
iarna
suggested changes
Jan 8, 2019
View reviewed changes
@iarnaiarna
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it took me a bit to wrap my head around what this was doing:
This is fixing a problem where npm update won't auto-heal missing links. (The work around is to run npm i instead, which will.)
I approve of this idea, but there are two things that need to be addressed before it lands:
  1. It needs a test (this would have helped us understand what the patch was hoping to achieve)
  2. With this patch and a file: type dep, npm outdated -l crashes, this'll need to be fixed.
@jmfNodejsUser
jmfNodejsUser
commented
Jan 9, 2019

Copy link


Copy Markdown

Thank you for the reply iarna.

How can I help to test this change? OR will somebody from the leader team test the modification?
Your suggestion to use npm i works and installs/links the first/primary dependency (local node module) in the main project. All sub dependencies of the local node modules are not installed/linked. Except when I delete the package-lock.json first and then run "npm i". In this case, it works and installs all primary and sub dependencies which are all local node modules(i.e. not from the npm registry)
@jmfNodejsUser
jmfNodejsUser
commented
Jan 10, 2019

Copy link


Copy Markdown

The problem with using "npm i" is the same mentioned in
https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754
@zkat
zkatforce-pushed
the
release-next
branch
2 times, most recently
from
6ca2f43 to
6d0cc95CompareJanuary 18, 2019 19:17
@larsgw
larsgw
commented
Jan 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Sorry for the confusion. I added tests. As for the npm outdated -l crash, that should be fixed in #124.
@zkat
zkatforce-pushed
the
release-next
branch
3 times, most recently
from
db63b89 to
b09bc8cCompareJanuary 23, 2019 18:36
zkatand others
added 14 commits
January 24, 2019 11:24
@zkat
npm-registry-fetch@3.9.0
671cad1
Make sure publishing with legacy username:password _auth works again
@watildeAudrey Eschright
doc: use const in lib/fetch-package-metadata.md (npm#120)
89b23a5
PR-URL: npm#120
Credit: @watilde
Reviewed-By: @aeschright
@watilde@aeschright
misc: replace ronn with marked-man (npm#126)
4970d55
PR-URL: npm#126
Credit: @watilde
Reviewed-By: @aeschright
@elidoran@aeschright
Reduce work to test if executable ends with a 'g'. (npm#138)
d9b6090
PR-URL: npm#138
Credit: @elidoran
Reviewed-By: @aeschright
@larsgw@aeschright
test(maketest): Fix common.npm callback arguments (npm#144)
cdb0592
PR-URL: npm#144
Credit: @larsgw
Reviewed-By: @aeschright
@sokra@aeschright
install/dedupe: fix hoisting of packages with peerDeps (npm#147)
91314e7
PR-URL: npm#147
Fixes: https://npm.community/t/packages-with-peerdependencies-are-incorrectly-hoisted/4794
Credit: @sokra
Reviewed-By: @aeschright
@larsgw@aeschright
ls: show installed but unmet peer deps (npm#145)
25573e9
PR-URL: npm#145
Fixes: https://npm.community/t/4770
Credit: @larsgw
Reviewed-By: @aeschright
@greysteil@aeschright
doc: update package.json docs to include repository.directory details (…
3663cde
…npm#140)
PR-URL: npm#140
Credit: @greysteil
Reviewed-By: @aeschright
@zkat@aeschright
token: use figgy-config to make sure extra opts are there (npm#149)
ce2c4bd
PR-URL: npm#149
Credit: @zkat
Reviewed-By: @aeschright
Audrey Eschright
pacote@9.4.1
95ca1ae
Audrey Eschright
chore: add changelog for v6.8.0
dacc47d
Audrey Eschright
update AUTHORS
f28a94c
Audrey Eschright
6.8.0-next.0
309260d
@zkat@aeschright
access: ls-collaborators is ok with non-scoped (npm#151)
3c22d1a
PR-URL: npm#151
Fixes: https://npm.community/t/npm-6-6-0-breaks-access-to-ls-collaborators/5101
Credit: @zkat
Reviewed-By: @aeschright
@jmfNodejsUser
jmfNodejsUser
commented
Feb 5, 2019

Copy link


Copy Markdown

Hello @zkat , @iarna ,

Has this correction been merged into version 6.7.0 release?

I tried downloading version 6.7.0 and testing it.

The "npm update" still does not work for local node modules.
@larsgw ,

This problem started after npm version 5.6.0 and exists till now. So I think, that the change in v3.6.0 is probably not the reason for these problems since 5.6.0.

The workaround by using "npm install" still needs a deletion of the package-lock.json.
@larsgw
update: re-enable updating local packages
a853ac7
PR #11584 removed the possibility of updating local
packages (linked with symlinks) with `npm update`.
Reason was that this functionality didn't work in
v3.6.0. However, the system behind local dependencies
has since changed, and I can't reproduce the original
error anymore.
Reverts 59e5056
@larsgw
test: update & outdated local packages
4d16575
@zkatzkat
added

semver:patch
semver patch level for changes
and removed

needs-discussion

labels
Feb 11, 2019
zkat
zkat
approved these changes
Feb 11, 2019
View reviewed changes
@zkatzkat
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing things up. This looks like it fulfill's @iarna's requirements, so we're good to go. 👍
zkat pushed a commit
that referenced
this pull request
Feb 18, 2019
@larsgw@zkat
update: re-enable updating local packages
e135c2b
PR #11584 removed the possibility of updating local
packages (linked with symlinks) with `npm update`.
Reason was that this functionality didn't work in
v3.6.0. However, the system behind local dependencies
has since changed, and I can't reproduce the original
error anymore.
Reverts 59e5056
Fixes: https://npm.community/t/1725?u=larsgw
PR-URL: #73
Credit: @larsgw
Reviewed-By: @iarna
Reviewed-By: @zkat
@zkat
zkat
commented
Feb 18, 2019

Copy link


Copy Markdown

Contributor
This has been merged by hand. Thanks again, @larsgw!
@zkatzkat
closed this
Feb 18, 2019
@snyk-botsnyk-bot
mentioned this pull request
Jun 16, 2022
 Open

Jah-yee pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
@Bortlesboat@claude
fix: filter alertcenter scopes from user OAuth login flow (npm#108)
a6994ad
* fix: filter alertcenter scopes from user OAuth login flow
The `apps.alerts` scope is restricted to service accounts with
domain-wide delegation and fails with `400 invalid_scope` when
used in the standard 3-legged OAuth consent flow. Filter it out
alongside the existing chat.app/chat.bot/keep exclusions.
Fixesnpm#73
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix: also filter apps.alerts in is_app_only_scope()
The scope filter exists in two locations: setup.rs (fetch_scopes_for_apis)
and auth_commands.rs (is_app_only_scope). Both need the apps.alerts
exclusion to prevent it from appearing in the interactive scope picker.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* chore: retrigger CLA check
* chore: retrigger CI after CLA signing
---------
Co-authored-by: Andrew Barnes <andrew.jaguars@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jun 23, 2026
@github-actions
📊 대시보드 데이터 업데이트 (npm#73)
451e7c5
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jul 1, 2026
@github-actions
🤖 봇 응답 (npm#73)
506319d
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jul 10, 2026
@github-actions
🔧 자동 수리 완료 (npm#73)
4338f69
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Aug 1, 2026
@github-actions
🔥 트렌드 선점 후보 갱신 (npm#73)
8d35207
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@iarnaiarnaiarna requested changes
@zkatzkatzkat approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

semver:patchsemver patch level for changes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@larsgw@zkat@jmfNodejsUser@iarna@watilde@elidoran@sokra@greysteil

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
update: re-enable updating local packages by larsgw · Pull Request #73 · npm/cli · GitHub
Skip to content
update: re-enable updating local packages - #73
Closed
larsgw wants to merge 16 commits into
npm:release-nextfrom 
larsgw:patch-2
Closed
update: re-enable updating local packages#73
larsgw wants to merge 16 commits into
npm:release-nextfrom 
larsgw:patch-2
Conversation
@larsgw
@larsgwlarsgw
commented
Oct 2, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
PR npm/npm#11584 removed the possibility of updating local packages (linked with symlinks) with npm update.

Reason was that this functionality didn't work in v3.6.0. However, the system behind local dependencies

has since changed, and I can't reproduce the original error anymore.
Reverts 53cdb96

See discussion in https://npm.community/t/1725
@larsgw
larsgw
requested a review
from a team
as a code ownerOctober 2, 2018 18:28
@zkat
zkat
changed the base branch from
latest
to
release-nextNovember 13, 2018 15:00
@zkat
zkat
commented
Nov 13, 2018

Copy link


Copy Markdown

Contributor
I'd like an 👀 from @iarna on this one.
@jmfNodejsUser
jmfNodejsUser
commented
Jan 8, 2019

Copy link


Copy Markdown

Hello,

Is this correction now available in 6.4.1 ?
@iarna
iarna
commented
Jan 8, 2019

Copy link


Copy Markdown

Contributor
@jmfNodejsUser It is not, it's not yet been merged.
iarna
iarna
suggested changes
Jan 8, 2019
View reviewed changes
@iarnaiarna
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it took me a bit to wrap my head around what this was doing:
This is fixing a problem where npm update won't auto-heal missing links. (The work around is to run npm i instead, which will.)
I approve of this idea, but there are two things that need to be addressed before it lands:
  1. It needs a test (this would have helped us understand what the patch was hoping to achieve)
  2. With this patch and a file: type dep, npm outdated -l crashes, this'll need to be fixed.
@jmfNodejsUser
jmfNodejsUser
commented
Jan 9, 2019

Copy link


Copy Markdown

Thank you for the reply iarna.

How can I help to test this change? OR will somebody from the leader team test the modification?
Your suggestion to use npm i works and installs/links the first/primary dependency (local node module) in the main project. All sub dependencies of the local node modules are not installed/linked. Except when I delete the package-lock.json first and then run "npm i". In this case, it works and installs all primary and sub dependencies which are all local node modules(i.e. not from the npm registry)
@jmfNodejsUser
jmfNodejsUser
commented
Jan 10, 2019

Copy link


Copy Markdown

The problem with using "npm i" is the same mentioned in
https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754
@zkat
zkatforce-pushed
the
release-next
branch
2 times, most recently
from
6ca2f43 to
6d0cc95CompareJanuary 18, 2019 19:17
@larsgw
larsgw
commented
Jan 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Sorry for the confusion. I added tests. As for the npm outdated -l crash, that should be fixed in #124.
@zkat
zkatforce-pushed
the
release-next
branch
3 times, most recently
from
db63b89 to
b09bc8cCompareJanuary 23, 2019 18:36
zkatand others
added 14 commits
January 24, 2019 11:24
@zkat
npm-registry-fetch@3.9.0
671cad1
Make sure publishing with legacy username:password _auth works again
@watildeAudrey Eschright
doc: use const in lib/fetch-package-metadata.md (npm#120)
89b23a5
PR-URL: npm#120
Credit: @watilde
Reviewed-By: @aeschright
@watilde@aeschright
misc: replace ronn with marked-man (npm#126)
4970d55
PR-URL: npm#126
Credit: @watilde
Reviewed-By: @aeschright
@elidoran@aeschright
Reduce work to test if executable ends with a 'g'. (npm#138)
d9b6090
PR-URL: npm#138
Credit: @elidoran
Reviewed-By: @aeschright
@larsgw@aeschright
test(maketest): Fix common.npm callback arguments (npm#144)
cdb0592
PR-URL: npm#144
Credit: @larsgw
Reviewed-By: @aeschright
@sokra@aeschright
install/dedupe: fix hoisting of packages with peerDeps (npm#147)
91314e7
PR-URL: npm#147
Fixes: https://npm.community/t/packages-with-peerdependencies-are-incorrectly-hoisted/4794
Credit: @sokra
Reviewed-By: @aeschright
@larsgw@aeschright
ls: show installed but unmet peer deps (npm#145)
25573e9
PR-URL: npm#145
Fixes: https://npm.community/t/4770
Credit: @larsgw
Reviewed-By: @aeschright
@greysteil@aeschright
doc: update package.json docs to include repository.directory details (…
3663cde
…npm#140)
PR-URL: npm#140
Credit: @greysteil
Reviewed-By: @aeschright
@zkat@aeschright
token: use figgy-config to make sure extra opts are there (npm#149)
ce2c4bd
PR-URL: npm#149
Credit: @zkat
Reviewed-By: @aeschright
Audrey Eschright
pacote@9.4.1
95ca1ae
Audrey Eschright
chore: add changelog for v6.8.0
dacc47d
Audrey Eschright
update AUTHORS
f28a94c
Audrey Eschright
6.8.0-next.0
309260d
@zkat@aeschright
access: ls-collaborators is ok with non-scoped (npm#151)
3c22d1a
PR-URL: npm#151
Fixes: https://npm.community/t/npm-6-6-0-breaks-access-to-ls-collaborators/5101
Credit: @zkat
Reviewed-By: @aeschright
@jmfNodejsUser
jmfNodejsUser
commented
Feb 5, 2019

Copy link


Copy Markdown

Hello @zkat , @iarna ,

Has this correction been merged into version 6.7.0 release?

I tried downloading version 6.7.0 and testing it.

The "npm update" still does not work for local node modules.
@larsgw ,

This problem started after npm version 5.6.0 and exists till now. So I think, that the change in v3.6.0 is probably not the reason for these problems since 5.6.0.

The workaround by using "npm install" still needs a deletion of the package-lock.json.
@larsgw
update: re-enable updating local packages
a853ac7
PR #11584 removed the possibility of updating local
packages (linked with symlinks) with `npm update`.
Reason was that this functionality didn't work in
v3.6.0. However, the system behind local dependencies
has since changed, and I can't reproduce the original
error anymore.
Reverts 59e5056
@larsgw
test: update & outdated local packages
4d16575
@zkatzkat
added

semver:patch
semver patch level for changes
and removed

needs-discussion

labels
Feb 11, 2019
zkat
zkat
approved these changes
Feb 11, 2019
View reviewed changes
@zkatzkat
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing things up. This looks like it fulfill's @iarna's requirements, so we're good to go. 👍
zkat pushed a commit
that referenced
this pull request
Feb 18, 2019
@larsgw@zkat
update: re-enable updating local packages
e135c2b
PR #11584 removed the possibility of updating local
packages (linked with symlinks) with `npm update`.
Reason was that this functionality didn't work in
v3.6.0. However, the system behind local dependencies
has since changed, and I can't reproduce the original
error anymore.
Reverts 59e5056
Fixes: https://npm.community/t/1725?u=larsgw
PR-URL: #73
Credit: @larsgw
Reviewed-By: @iarna
Reviewed-By: @zkat
@zkat
zkat
commented
Feb 18, 2019

Copy link


Copy Markdown

Contributor
This has been merged by hand. Thanks again, @larsgw!
@zkatzkat
closed this
Feb 18, 2019
@snyk-botsnyk-bot
mentioned this pull request
Jun 16, 2022
 Open

Jah-yee pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
@Bortlesboat@claude
fix: filter alertcenter scopes from user OAuth login flow (npm#108)
a6994ad
* fix: filter alertcenter scopes from user OAuth login flow
The `apps.alerts` scope is restricted to service accounts with
domain-wide delegation and fails with `400 invalid_scope` when
used in the standard 3-legged OAuth consent flow. Filter it out
alongside the existing chat.app/chat.bot/keep exclusions.
Fixesnpm#73
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix: also filter apps.alerts in is_app_only_scope()
The scope filter exists in two locations: setup.rs (fetch_scopes_for_apis)
and auth_commands.rs (is_app_only_scope). Both need the apps.alerts
exclusion to prevent it from appearing in the interactive scope picker.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* chore: retrigger CLA check
* chore: retrigger CI after CLA signing
---------
Co-authored-by: Andrew Barnes <andrew.jaguars@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jun 23, 2026
@github-actions
📊 대시보드 데이터 업데이트 (npm#73)
451e7c5
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jul 1, 2026
@github-actions
🤖 봇 응답 (npm#73)
506319d
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jul 10, 2026
@github-actions
🔧 자동 수리 완료 (npm#73)
4338f69
github-actionsBot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Aug 1, 2026
@github-actions
🔥 트렌드 선점 후보 갱신 (npm#73)
8d35207
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@iarnaiarnaiarna requested changes
@zkatzkatzkat approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

semver:patchsemver patch level for changes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@larsgw@zkat@jmfNodejsUser@iarna@watilde@elidoran@sokra@greysteil