Skip to content

feat: add subtle gradient on modal chart area - #1127

Merged
graphieros merged 2 commits into
npmx-dev:mainfrom
graphieros:main
Feb 7, 2026
Merged

feat: add subtle gradient on modal chart area#1127
graphieros merged 2 commits into
npmx-dev:mainfrom
graphieros:main

Conversation

@graphieros

@graphierosgraphieros commented Feb 7, 2026

Copy link
Copy Markdown
Member
  • Adds a subtle gradient to the modal chart.
    (Does not affect the chart of the compare page, where it is better to keep clear lines for multiple series)
Dark modeLight mode
imageimage
  • Bump vue-data-ui to 3.14.8 (no impact for our current usage)

@vercel

vercelBot commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devErrorErrorFeb 7, 2026 7:01am
npmx.devReadyReadyPreview, CommentFeb 7, 2026 7:01am
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
npmx-lunariaIgnoredIgnoredFeb 7, 2026 7:01am

Request Review

@codecov

codecovBot commented Feb 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
app/components/Package/DownloadAnalytics.vue0.00%1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitaiBot commented Feb 7, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The PR enables area fills for single-series charts in DownloadAnalytics by setting useArea: true on VueUiXyDatasetItems produced by formatXyDataset for weekly, daily, monthly and yearly granularities, and injects an area-gradient slot into the VueUiXy chart usage to render a gradient using the series colour.

Possibly related PRs

Suggested reviewers

  • danielroe
  • shuuji3
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description clearly relates to the changeset, describing the addition of a subtle gradient to the modal chart and the dependency bump.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroedanielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful!

@graphieros
graphieros added this pull request to the merge queueFeb 7, 2026
Merged via the queue into npmx-dev:main with commit 049b409Feb 7, 2026
16 of 18 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@graphieros@danielroe