Skip to content

chore: clean up and document - #950

Merged
43081j merged 1 commit into
npmx-dev:mainfrom
graphieros:main
Feb 4, 2026
Merged

chore: clean up and document#950
43081j merged 1 commit into
npmx-dev:mainfrom
graphieros:main

Conversation

@graphieros

Copy link
Copy Markdown
Member
  • clean up remaining dead code
  • DownloadAnalytics.vue contains a lot of complexity. Major functions with some amount of cognitive load are documented.

@vercel

vercelBot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentFeb 4, 2026 3:39pm

Request Review

@codecov

codecovBot commented Feb 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
app/components/Package/DownloadAnalytics.vue50.00%1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The changes refactor the DownloadAnalytics.vue component by introducing utility helpers for evolution data processing (formatXyDataset, extractSeriesPoints, and date-range initialisation functions) and restructuring the data flow logic. The shouldFetch flag has been replaced with direct watcher logic, a new chartConfig computed object manages component configuration, and chartData computation now uses the new formatting helpers to support both single- and multi-package data alignment. The template rendering has been updated to use the new chartConfig and chartData consistently, with additional JSDoc documentation added for clarity.

Possibly related PRs

  • npmx-dev/npmx.dev\feat: add charts to compare page #846: Modifies the same DownloadAnalytics.vue component to implement multi-package chart logic, dataset formatting, and date-range handling utilities.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description directly addresses the changeset, mentioning dead code cleanup and documentation of DownloadAnalytics.vue functions to reduce complexity.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Comment @coderabbitai help to get the list of available commands and usage tips.

@43081j
43081j added this pull request to the merge queueFeb 4, 2026
Merged via the queue into npmx-dev:main with commit 8ddceccFeb 4, 2026
13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@graphieros@43081j