Uh oh!
There was an error while loading. Please reload this page.
fix: consistent and likely safer regex escaping - #1439
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughAdds a TypeScript global augmentation declaring Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c5c880b to
4454fa9Compare
danielroe
left a comment
There was a problem hiding this comment.
I'm not sure that the benefit is worth the cost in terms of browser compatibility.
wdyt @ghostdevv?
yeaaa maybe, perhaps there is a minimal ponyfill that achieves the same result 🤔 (because we need something for this, and I'd like to avoid having multiple fns for it over the codebase) |
some initial findings, need to step away for a bit so will take another look later |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
wojtekmaj
commented
Feb 12, 2026
On the other hand, I don't think a large percentage of npmx audience is using IE or is 11 Chrome versions behind. |
danielroe
commented
Feb 12, 2026
regexp.escape won't work on iOS 17 devices. I agree we need a canonical single escape function but it's a tiny one-liner, for our purposes. (https://github.com/lionel-rowe/regexp-escape-polyfill (linked by @ghostdevv above) is just 498 B) |
ghostdevv
commented
Feb 13, 2026
updated to use |
ghostdevv
commented
Feb 13, 2026
For some reason the vercel preview is crashing when you access a package page directly 🤔 it doesn't happen in dev or local preview |
43081j
commented
Feb 24, 2026
i caught up from main, and the preview seems to work now too FYI |
# Conflicts: # app/composables/useMarkdown.ts # app/composables/useStructuredFilters.ts # package.json # pnpm-lock.yaml
Uh oh!
There was an error while loading. Please reload this page.
Replaces random regex escaping with
@li/regexp-escape-polyfill, a spec-compliant polyfill forRegExp.escape(). I searched for everyRegExpcall, and replaced the ones that needed them. Most didn't use any dynamic strings, but the couple that did are updated here or didn't need it