Skip to content

revert: revert "fix: consistent and likely safer regex escaping" - #2403

Merged
serhalp merged 1 commit into
mainfrom
revert-1439-gd/regex-escape
Apr 6, 2026
Merged

revert: revert "fix: consistent and likely safer regex escaping"#2403
serhalp merged 1 commit into
mainfrom
revert-1439-gd/regex-escape

Conversation

@serhalp

@serhalpserhalp commented Apr 6, 2026

Copy link
Copy Markdown
Member

Reverts #1439

main.npmx.dev and all new previews are broken at the moment. I bisected all the commits on main (https://github.com/npmx-dev/npmx.dev/pull/2354/commits) and this was unambiguously the culprit.

See also https://discord.com/channels/1464542801676206113/1490833925759701235.

I don't have access to the server logs, so I'm running blind here. Just reverting for now.

Repro 1

Visit /astro, see Vercel 500 crash page.

image

Repro 2

Visit /package/astro, see a dozen pieces of data "degrade gracefully".

Screenshot 2026-04-06 at 18 51 54

@vercel

vercelBot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devReadyReadyPreview, CommentApr 6, 2026 11:07pm
npmx.devReadyReadyPreview, CommentApr 6, 2026 11:07pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
npmx-lunariaIgnoredIgnoredApr 6, 2026 11:07pm

Request Review

@serhalp
serhalp enabled auto-merge April 6, 2026 23:09
@serhalp
serhalp requested a review from a teamApril 6, 2026 23:09
@codecov

codecovBot commented Apr 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@serhalp
serhalp added this pull request to the merge queueApr 6, 2026
Merged via the queue into main with commit 87cf141Apr 6, 2026
25 checks passed
@serhalp
serhalp deleted the revert-1439-gd/regex-escape branch April 6, 2026 23:20
@github-actionsgithub-actionsBot mentioned this pull request Apr 6, 2026
@ghostdevv

Copy link
Copy Markdown
Member

based

@ghostdevvghostdevv mentioned this pull request Apr 7, 2026
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@serhalp@ghostdevv@fatfingers23