Skip to content

chore: dark mode iconify logo - #1940

Merged
danielroe merged 1 commit into
npmx-dev:mainfrom
cyberalien:main
Mar 5, 2026
Merged

chore: dark mode iconify logo#1940
danielroe merged 1 commit into
npmx-dev:mainfrom
cyberalien:main

Conversation

@cyberalien

Copy link
Copy Markdown
Contributor

📚 Description

In logos/oss-partners Iconify logo is for light mode, this replaces it with a logo for dark mode.

@vercel

vercelBot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.dev (canary)ReadyReadyPreview, CommentMar 5, 2026 10:07am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewMar 5, 2026 10:07am
npmx-lunariaIgnoredIgnoredMar 5, 2026 10:07am

Request Review

@cyberaliencyberalien changed the title Dark mode iconify logochore: dark mode iconify logoMar 5, 2026
@codecov

codecovBot commented Mar 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

ghostdevv
ghostdevv previously requested changes Mar 5, 2026

@ghostdevvghostdevv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, should we remove the background from the svg entirely as then it'll blend with the main background of the page? or is it the logo supposed to have that bg?

@cyberalien

Copy link
Copy Markdown
ContributorAuthor

Logo contains elements that act as masks, drawing background color on top of few shapes, so if icon has the same background as website it all looks seamless.

Though I just noticed there is an option to change background color for website. In that case it might be better to quickly redo icon to have proper masks. I'll test that, will reply in 5 minutes.

@cyberaliencyberalien left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated logo with masked image

@userquin

userquin commented Mar 5, 2026

Copy link
Copy Markdown
Member

You need to add the dark variant at index.ts. uhmm, you just change it with transparent bg, we support both variant.

@cyberalien

Copy link
Copy Markdown
ContributorAuthor

Oh, I see. I'll fix that!

@userquin

Copy link
Copy Markdown
Member

Maybe you can add both with transparent bg color, we have both svg at icons-set nuxt app.

@cyberalien

Copy link
Copy Markdown
ContributorAuthor

Done. Also removed previous commits to clean up pull request

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3b06afd7-bb8a-467b-823d-6b9d3dd7baf9

📥 Commits

Reviewing files that changed from the base of the PR and between f9c8e9c and 686c042.

⛔ Files ignored due to path filters (2)
  • app/assets/logos/oss-partners/iconify-light.svg is excluded by !**/*.svg
  • app/assets/logos/oss-partners/iconify.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • app/assets/logos/oss-partners/index.ts

📝 Walkthrough

Walkthrough

This pull request modifies the OSS_PARTNERS configuration in app/assets/logos/oss-partners/index.ts to add dual-theme support for the Iconify partner logo. A new light-theme logo import is introduced, and the Iconify partner entry's logo field is updated from a single logo reference to an object containing separate dark and light theme variants. This changes the public data structure of the OSS_PARTNERS constant.

Possibly related PRs

  • chore: add oss partners #1853: Directly related as it adds the initial Iconify entry to OSS_PARTNERS, whilst this PR extends it to support dark and light theme variants.
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe PR description accurately relates to the changeset, describing the addition of dark mode support for the Iconify logo in the oss-partners directory.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe
danielroe enabled auto-merge March 5, 2026 11:37
@danielroe
danielroe added this pull request to the merge queueMar 5, 2026
Merged via the queue into npmx-dev:main with commit 6a78b90Mar 5, 2026
19 checks passed
@github-actions

Copy link
Copy Markdown

Thanks for your first contribution, @cyberalien! 🎉

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

@github-actionsgithub-actionsBot mentioned this pull request Mar 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@cyberalien@userquin@danielroe@ghostdevv