Skip to content

fix: add top margin to show more/fewer maintainers button - #2262

Merged
ghostdevv merged 2 commits into
npmx-dev:mainfrom
iiio2:style/add-top-margin-to-show-more/fewer-button
Mar 24, 2026
Merged

fix: add top margin to show more/fewer maintainers button#2262
ghostdevv merged 2 commits into
npmx-dev:mainfrom
iiio2:style/add-top-margin-to-show-more/fewer-button

Conversation

@iiio2

@iiio2iiio2 commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

The "show more" / "show fewer" button in the Maintainers section had no top margin, so it appeared visually cramped directly against the last maintainer in the list. Adding mt-2 gives it breathing room from the list above.

BeforeAfterAfter
oldnew-morenew-fewer

@vercel

vercelBot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentMar 24, 2026 3:39pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewMar 24, 2026 3:39pm
npmx-lunariaIgnoredIgnoredMar 24, 2026 3:39pm

Request Review

@codecov

codecovBot commented Mar 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: df7a5eeb-e177-4553-93a1-ab9817fec890

📥 Commits

Reviewing files that changed from the base of the PR and between 6ead0a8 and 31dee4e.

📒 Files selected for processing (1)
  • app/components/Package/Maintainers.vue

📝 Walkthrough

Walkthrough

This pull request adds a class="mt-2" styling attribute to a "Show more/less" button toggle in the Maintainers component. The styling attribute applies only when the button is visible under the condition !canManageOwners && hiddenMaintainersCount > 0. The change is purely presentational and does not modify any logic, state management, or control flow.

Suggested reviewers

  • danielroe
  • alexdln
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description clearly explains the change: adding mt-2 margin to the show more/fewer button for better visual spacing, with before/after images demonstrating the improvement.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ghostdevv
ghostdevv enabled auto-merge March 24, 2026 15:38
@ghostdevv
ghostdevv disabled auto-merge March 24, 2026 15:38
@ghostdevvghostdevv changed the title style: add top margin to show more/fewer buttonfix: add top margin to show more/fewer button on package pageMar 24, 2026
@ghostdevvghostdevv changed the title fix: add top margin to show more/fewer button on package pagefix: add top margin to show more/fewer maintainers buttonMar 24, 2026
@ghostdevv
ghostdevv enabled auto-merge March 24, 2026 15:39
@ghostdevv
ghostdevv added this pull request to the merge queueMar 24, 2026
Merged via the queue into npmx-dev:main with commit 781b407Mar 24, 2026
22 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Mar 24, 2026
@iiio2

Copy link
Copy Markdown
ContributorAuthor

Thanks.

@iiio2
iiio2 deleted the style/add-top-margin-to-show-more/fewer-button branch March 24, 2026 15:49
ghostdevv added a commit that referenced this pull request Mar 29, 2026
Co-authored-by: Willow (GHOST) <git@willow.sh>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@iiio2@ghostdevv@MathurAditya724