Skip to content

fix: add missing token to first-time contributor welcome workflow - #2264

Merged
ghostdevv merged 1 commit into
npmx-dev:mainfrom
MathurAditya724:patch-6
Mar 24, 2026
Merged

fix: add missing token to first-time contributor welcome workflow#2264
ghostdevv merged 1 commit into
npmx-dev:mainfrom
MathurAditya724:patch-6

Conversation

@MathurAditya724

@MathurAditya724MathurAditya724 commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

🔗 Linked issue

N/A — discovered from a failing CI job on #2262

🧭 Context

The "Greet First-Time Contributors" workflow (added in #2236) fails on every new contributor's PR because a required action input is missing.

📚 Description

The zephyrproject-rtos/action-first-interaction action requires a repo-token input to authenticate with the GitHub API, but it wasn't being supplied. This adds repo-token: ${{ secrets.GITHUB_TOKEN }} to the workflow. The workflow already has permissions: pull-requests: write so no additional permission changes are needed.

Failing job: https://github.com/npmx-dev/npmx.dev/actions/runs/23489827599/job/68354800411?pr=2262

@vercel

vercelBot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentMar 24, 2026 2:48pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredMar 24, 2026 2:48pm
npmx-lunariaIgnoredIgnoredMar 24, 2026 2:48pm

Request Review

@codecov

codecovBot commented Mar 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@MathurAditya724MathurAditya724 changed the title fix(ci): add missing repo-token to first-time contributor greeting workflowfix: add missing repo-token to first-time contributor greeting workflowMar 24, 2026
@ghostdevv
ghostdevv self-requested a review March 24, 2026 15:22

@trueberrylesstrueberryless left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Thanks, I missed that in #2236

@ghostdevvghostdevv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still broken but maybe merging will help 🤔

@ghostdevvghostdevv changed the title fix: add missing repo-token to first-time contributor greeting workflowfix: add missing repo-token to first-time contributor welcome workflowMar 24, 2026
@ghostdevvghostdevv changed the title fix: add missing repo-token to first-time contributor welcome workflowfix: add missing token to first-time contributor welcome workflowMar 24, 2026
@ghostdevv
ghostdevv added this pull request to the merge queueMar 24, 2026
Merged via the queue into npmx-dev:main with commit 6ead0a8Mar 24, 2026
22 of 25 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Mar 24, 2026
@trueberryless

Copy link
Copy Markdown
Member

It's still broken but maybe merging will help 🤔

Yes, that's expected because the trigger is pull_request_target which will read the main branch, and since it was not merged when the PR is created, it reads the old action. 👍

@ghostdevv

Copy link
Copy Markdown
Member

It's still broken but maybe merging will help 🤔

Yes, that's expected because the trigger is pull_request_target which will read the main branch, and since it was not merged when the PR is created, it reads the old action. 👍

ahhh TIL

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MathurAditya724@trueberryless@ghostdevv