Skip to content

feat: add tetris and pride noodles - #2855

Merged
alexdln merged 2 commits into
npmx-dev:mainfrom
alexdln:feat/june-noodles
Jun 5, 2026
Merged

feat: add tetris and pride noodles#2855
alexdln merged 2 commits into
npmx-dev:mainfrom
alexdln:feat/june-noodles

Conversation

@alexdln

@alexdlnalexdln commented Jun 5, 2026

Copy link
Copy Markdown
Member

🧭 Context

More noodles 🍜

Screenshotsimageimageimage

@vercel

vercelBot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentJun 5, 2026 1:28pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewJun 5, 2026 1:28pm
npmx-lunariaIgnoredIgnoredJun 5, 2026 1:28pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a15003f5-518a-4ee6-a27c-9aba2914c740

📥 Commits

Reviewing files that changed from the base of the PR and between aa131c1 and 25a399e.

📒 Files selected for processing (1)
  • test/nuxt/a11y.spec.ts

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Added new seasonal themed logos celebrating Pride Month and Tetris Day, featuring custom tooltip messages and associated imagery.
    • Expanded logo scheduling system to support multiple concurrent seasonal celebrations with improved timezone handling.
  • Tests

    • Extended accessibility compliance testing to verify all new themed logo components meet accessibility standards.

Walkthrough

Adds three new themed logo Vue components (Pride2, Pride3, Tetris), registers them in ACTIVE_NOODLES with date ranges and timezone, and extends accessibility tests to include the new logos.

Changes

Noodle theme expansion

Layer / File(s)Summary
New logo components
app/components/Noodle/Pride2/Logo.vue, app/components/Noodle/Pride3/Logo.vue, app/components/Noodle/Tetris/Logo.vue
Three new template-only Vue components render TooltipApp elements with Pride Month and World Tetris Day messaging; each includes an image with i18n-translated alt text.
Noodle registration and scheduling
app/components/Noodle/index.ts
New logo imports are added; ACTIVE_NOODLES array is updated to register tetris, pride-2, and pride-3 entries with their date/dateTo, timezone: 'auto', and tagline configuration; pride-1's dateTo is adjusted.
Accessibility tests
test/nuxt/a11y.spec.ts
The components import list and the Noodles accessibility tests are extended to mount and run axe checks for NoodlePride2Logo, NoodlePride3Logo, and NoodleTetrisLogo.

Possibly related PRs

Suggested reviewers

  • ghostdevv
  • graphieros
  • danielroe
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe pull request title accurately and concisely describes the main changes—adding Tetris and Pride noodles to the application, which aligns with the changeset that adds three new noodle logo components and updates the noodles configuration.
Description check✅ PassedThe pull request description is directly related to the changeset, mentioning 'More noodles' and providing screenshots that showcase the new noodle designs (Tetris and Pride variants) being added to the application.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecovBot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
app/components/Noodle/Pride2/Logo.vue66.66%0 Missing and 1 partial ⚠️
app/components/Noodle/Pride3/Logo.vue66.66%0 Missing and 1 partial ⚠️
app/components/Noodle/Tetris/Logo.vue66.66%0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@graphierosgraphieros left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 🌿

@alexdln
alexdln added this pull request to the merge queueJun 5, 2026
Merged via the queue into npmx-dev:main with commit ccec4aeJun 5, 2026
24 checks passed
@alexdln
alexdln deleted the feat/june-noodles branch June 5, 2026 15:21
@github-actionsgithub-actionsBot mentioned this pull request Jun 5, 2026
kimkanu pushed a commit to kimkanu/npmx.dev that referenced this pull request Jun 6, 2026
kimkanu pushed a commit to kimkanu/npmx.dev that referenced this pull request Jun 6, 2026
kimkanu pushed a commit to kimkanu/npmx.dev that referenced this pull request Jun 6, 2026
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexdln@graphieros