Skip to content

feat: pride noodle - #2826

Merged
ghostdevv merged 4 commits into
npmx-dev:mainfrom
alexdln:feat/pride-noodle
May 31, 2026
Merged

feat: pride noodle#2826
ghostdevv merged 4 commits into
npmx-dev:mainfrom
alexdln:feat/pride-noodle

Conversation

@alexdln

@alexdlnalexdln commented May 31, 2026

Copy link
Copy Markdown
Member

🧭 Context

New noodle 🎉

📚 Description

Preview with active noodle - https://npmx-l2zigx3fh-npmx.vercel.app/

Screenshotsimageimage

@vercel

vercelBot commented May 31, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentMay 31, 2026 6:26pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewMay 31, 2026 6:26pm
npmx-lunariaIgnoredIgnoredMay 31, 2026 6:26pm

Request Review

@coderabbitai

coderabbitaiBot commented May 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0b0fccde-5ed2-4118-b4eb-03841a21384f

📥 Commits

Reviewing files that changed from the base of the PR and between 2d01062 and c37c1c9.

📒 Files selected for processing (1)
  • test/e2e/noodle.spec.ts
💤 Files with no reviewable changes (1)
  • test/e2e/noodle.spec.ts

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Added a Pride Month logo component configured to display during June 2026.
  • Tests

    • Added an accessibility audit for the new Pride logo.
    • Updated end-to-end tests to reflect the new logo display and placeholder handling.
  • Chores

    • Updated tooling ignore rules to account for legacy logo files.

Walkthrough

This PR swaps the active noodle logo from Node.js to Pride 1 for June 2026, adds a new Pride 1 Vue component, marks the superseded Nodejs logo ignored, adds an accessibility test for the new component, and updates E2E noodle mocks and assertions to use placeholder keys.

Changes

Pride 1 Logo Implementation

Layer / File(s)Summary
Pride 1 Logo Component
app/components/Noodle/Pride1/Logo.vue
New Vue SFC renders a tooltip-wrapped Pride logo image (/extra/pride-1.svg) with i18n-backed alt text and sizing/layout classes.
Active Noodles Registry and Cleanup
app/components/Noodle/index.ts, knip.ts
Import changed to Pride1 logo; ACTIVE_NOODLES updated to replace Node.js entry with pride-1 including June 2026 date/dateTo; Nodejs logo added to Knip ignore list.
Accessibility Test Coverage
test/nuxt/a11y.spec.ts
Adds NoodlePride1Logo to test imports and a new axe audit test that mounts the component and expects no accessibility violations.
E2E noodle mocks and assertions
test/e2e/noodle.spec.ts
Adds noodlePlaceholders helper, injects per-noodle placeholder DOM nodes into mocked landing HTML, encodes data-active-noodles/data-permanent-noodles, and updates multiple E2E assertions to use test-active/test-permanent placeholders across scenarios and timezone tests.

Possibly related PRs

  • npmx-dev/npmx.dev#2778: Also swaps active noodle entry/logo wiring and updates related tests.
  • npmx-dev/npmx.dev#2808: Overlaps E2E and noodle date handling changes that affect landing intro header and date-check logic.
  • npmx-dev/npmx.dev#2666: Similar updates to ACTIVE_NOODLES entries and a11y test adjustments for added logo components.

Suggested reviewers

  • danielroe
  • graphieros
  • gameroman
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title 'feat: pride noodle' directly and specifically describes the main change—adding a new Pride-themed noodle component to the project.
Description check✅ PassedThe description is related to the changeset, providing context ('New noodle 🎉'), a preview link, and screenshots demonstrating the Pride noodle rendered on the homepage in both themes.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecovBot commented May 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
app/components/Noodle/Pride1/Logo.vue66.66%0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@alexdln

alexdln commented May 31, 2026

Copy link
Copy Markdown
MemberAuthor

Oops, working on it
UPD: still working...

@alexdln

Copy link
Copy Markdown
MemberAuthor

Okay, so I'm not a good person since I deleted the test. I added this test in the previous pr, but it's linked to real data, and attempts to mock the data don't really work since the page is static, and the logic is inside prehydrate (that is, it is also impossible to move the logic into a separate function)

I hope we can bring back the test later, but for now it doesn't seem worth wasting time on it (@gameroman, @ghostdevv fyi)

@ghostdevvghostdevv mentioned this pull request May 31, 2026
@ghostdevv
ghostdevv added this pull request to the merge queueMay 31, 2026
Merged via the queue into npmx-dev:main with commit 082a321May 31, 2026
24 checks passed
@github-actionsgithub-actionsBot mentioned this pull request May 31, 2026
@alexdln
alexdln deleted the feat/pride-noodle branch May 31, 2026 19:19
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexdln@ghostdevv