Skip to content

fix(ui): add missing AppTooltip usages - #883

Merged
danielroe merged 3 commits into
npmx-dev:mainfrom
sybers:fix/add-missing-app-tooltips
Feb 3, 2026
Merged

fix(ui): add missing AppTooltip usages#883
danielroe merged 3 commits into
npmx-dev:mainfrom
sybers:fix/add-missing-app-tooltips

Conversation

@sybers

Copy link
Copy Markdown
Contributor

Some icons were not using tooltips but an html title attr instead, it was the case for the "install size (i)" and the "create new project (i)".

This PR fixes these two tooltips !

Here are a few screenshots (in French 🥖)

CleanShot 2026-02-03 at 22 09 26@2xCleanShot 2026-02-03 at 22 11 44@2x

@vercel

vercelBot commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devErrorErrorFeb 3, 2026 10:16pm
npmx.devReadyReadyPreview, CommentFeb 3, 2026 10:16pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
npmx-lunariaIgnoredIgnoredFeb 3, 2026 10:16pm

Request Review

@syberssybers changed the title fix(client): add missing AppTooltip usagesfix(ui): add missing AppTooltip usagesFeb 3, 2026
@codecov

codecovBot commented Feb 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
app/components/Terminal/Install.vue0.00%1 Missing and 1 partial ⚠️
app/pages/package/[...package].vue0.00%0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitaiBot commented Feb 3, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Replaces inline title attributes on information icons with a TooltipApp wrapper in multiple components (app/components/Terminal/Install.vue and app/pages/package/[...package].vue), changing how tooltip text is rendered while keeping the same SR-only content. Updates the tooltip base component (app/components/Tooltip/Base.vue) CSS class from whitespace-nowrap to whitespace-pre-line to allow line wrapping and preserve line breaks. No changes to exported/public APIs or underlying data.

Suggested reviewers

  • knowler
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe PR description accurately describes the changeset: replacing HTML title attributes with AppTooltip components for two icons ('install size' and 'create new project'), with supporting screenshots.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment threadapp/components/Tooltip/Base.vue Outdated
@sybers

Copy link
Copy Markdown
ContributorAuthor

Not sure what I should do with the coverage issue here, is there a test that needs to be added/updated ?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sybers@danielroe