Skip to content

fix(i18n): add translation for 'likes' key - #948

Closed
Pascalmh wants to merge 4 commits into
npmx-dev:mainfrom
Pascalmh:patch-1
Closed

fix(i18n): add translation for 'likes' key#948
Pascalmh wants to merge 4 commits into
npmx-dev:mainfrom
Pascalmh:patch-1

Conversation

@Pascalmh

@PascalmhPascalmh commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

When hovering over the "Likes"-Icon on the Package-Page the package.links.like key is not translated.

image

After the fix:

image

@vercel

vercelBot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentFeb 4, 2026 3:36pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewFeb 4, 2026 3:36pm
npmx-lunariaIgnoredIgnoredFeb 4, 2026 3:36pm

Request Review

@github-actions

github-actionsBot commented Feb 4, 2026

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

FileNote
lunaria/files/en-GB.jsonLocalization changed, will be marked as complete.
lunaria/files/en-US.jsonSource changed, localizations will be marked as outdated.
Warnings reference
IconDescription
🔄️The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai

coderabbitaiBot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Three translation files were updated to add a new localisation key. The key "like" with value "like" was added to the links object in i18n/locales/en.json, lunaria/files/en-GB.json, and lunaria/files/en-US.json. A trailing comma was added after the existing compare entry in each file to accommodate the new key. Each file shows 2 lines added and 1 line removed.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description clearly explains the issue: the package.links.like key was not being translated when hovering over the Likes icon on the Package page. The description includes before-and-after screenshots demonstrating the problem and the fix.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecovBot commented Feb 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment threadi18n/locales/en.json Outdated
Pascalmhand others added 2 commits February 4, 2026 16:33
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@wojtekmaj

Copy link
Copy Markdown
Contributor

I'd suggest going with #957 instead as an even more complete solution

@PascalmhPascalmh closed this Feb 5, 2026
@Pascalmh
Pascalmh deleted the patch-1 branch February 5, 2026 06:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Pascalmh@wojtekmaj