Skip to content

fix(i18n): add missing i18n strings for like button + tooltip - #957

Merged
danielroe merged 2 commits into
npmx-dev:mainfrom
nitodeco:fix/missing-like-toolltip
Feb 5, 2026
Merged

fix(i18n): add missing i18n strings for like button + tooltip#957
danielroe merged 2 commits into
npmx-dev:mainfrom
nitodeco:fix/missing-like-toolltip

Conversation

@nitodeco

@nitodeconitodeco commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

Fixes#956

Before:
package links like

After:
Like this package

Unlike this package

@vercel

vercelBot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentFeb 4, 2026 10:15pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewFeb 4, 2026 10:15pm
npmx-lunariaIgnoredIgnoredFeb 4, 2026 10:15pm

Request Review

@github-actions

github-actionsBot commented Feb 4, 2026

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

FileNote
lunaria/files/en-GB.jsonLocalization changed, will be marked as complete.
lunaria/files/en-US.jsonSource changed, localizations will be marked as outdated.
Warnings reference
IconDescription
🔄️The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov

codecovBot commented Feb 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
app/pages/package/[...package].vue0.00%7 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitaiBot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request wraps the package page like control in TooltipApp, moving the dynamic aria-label/title and heart icon class handling into the nested button. The tooltip text now toggles between localized like and unlike keys based on likesData.userHasLiked. New i18n entries (like, unlike) were added to i18n/locales/en.json, lunaria/files/en-GB.json, and lunaria/files/en-US.json. The optimistic update and fallback skeleton for likes remain unchanged.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description check✅ PassedThe PR description relates to the changeset by referencing issue #956 and showing before/after screenshots of the like button tooltip functionality.
Linked Issues check✅ PassedThe PR addresses all coding requirements from issue #956 by adding missing i18n strings for like/unlike states and wrapping the like button with a tooltip component.
Out of Scope Changes check✅ PassedAll changes directly address the linked issue requirement to add missing i18n translations and configure the like button tooltip; no unrelated modifications are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment threadapp/pages/package/[...package].vue
@danielroe
danielroe added this pull request to the merge queueFeb 5, 2026
Merged via the queue into npmx-dev:main with commit 3a67356Feb 5, 2026
15 of 16 checks passed
@nitodeco
nitodeco deleted the fix/missing-like-toolltip branch February 5, 2026 01:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Like-tooltip shows raw i18n string, not resolved i18n value

3 participants

@nitodeco@wojtekmaj@danielroe