remove trait-upcasting restriction on downstream users of provider - #4
Closed
yaahc wants to merge 1 commit into
Closed
remove trait-upcasting restriction on downstream users of provider#4yaahc wants to merge 1 commit into
yaahc wants to merge 1 commit into
Conversation
yaahcforce-pushed
the
messing-with-provider
branch
from
March 29, 2022 21:37
6e60282 to
8381174Comparenrc
commented
Apr 7, 2022
Owner
As discussed on the PR, using an explicit generic parameter rather than closures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing some fiddling on the provider impl PR1 while I review it @nrc, hope you don't mind. Pushing the commits here while I go through things incase you want to merge / cherry-pick them.
Footnotes
https://github.com/rust-lang/rust/pull/91970↩