Add the Provider api to core::any by nrc · Pull Request #91970 · rust-lang/rust

nrc · 2021-12-15T16:25:14Z

This is an implementation of RFC 3192~~(which is yet to be merged, thus why this is a draft PR)~~. It adds an API for type-driven requests and provision of data from trait objects. A primary use case is for the Error trait, though that is not implemented in this PR. The only major difference to the RFC is that the functionality is added to the any module, rather than being in a sibling provide_any module (as discussed in the RFC thread).

~~Still todo: improve documentation on items, including adding examples.~~

cc @yaahc

rust-highfive · 2021-12-15T16:25:17Z

r? @scottmcm

(rust-highfive has picked a reviewer for you, use r? to override)

bors · 2022-02-01T20:25:12Z

☔ The latest upstream changes (presumably #93548) made this pull request unmergeable. Please resolve the merge conflicts.

scottmcm

Sorry for taking a while for getting to this.

While some of the comments I'm confident in, others I'm not tied to at all. As always, feel free to push back on anything you feel differently about.

nrc · 2022-05-11T09:13:19Z

@scottmcm thanks for the review, they were very useful comments. I think I have addressed the comments, please take another look!

TimDiekmann

Clippy gives two suggestions, I added them as a review. 🙂

Signed-off-by: Nick Cameron <nrc@ncameron.org>

… is not required Signed-off-by: Nick Cameron <nrc@ncameron.org>

Signed-off-by: Nick Cameron <nrc@ncameron.org>

nrc · 2022-06-06T11:19:55Z

Comments addressed

scottmcm · 2022-06-09T20:06:35Z

Thanks for the updates! Things look good to me.

@bors r+

(And sorry for taking a while to rereview after the changes.)

bors · 2022-06-09T20:06:37Z

📌 Commit 6629010 has been approved by scottmcm

bors · 2022-06-10T01:11:02Z

⌛ Testing commit 6629010 with merge e9aff9c...

bors · 2022-06-10T03:55:09Z

☀️ Test successful - checks-actions
Approved by: scottmcm
Pushing e9aff9c to master...

rust-timer · 2022-06-10T05:12:05Z

Finished benchmarking commit (e9aff9c): comparison url.

Instruction count

Primary benchmarks: 🎉 relevant improvement found
Secondary benchmarks: 😿 relevant regression found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	0.3%	0.3%	1
Improvements 🎉 (primary)	-1.0%	-1.0%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-1.0%	-1.0%	1

Max RSS (memory usage)

Results

Primary benchmarks: 😿 relevant regression found
Secondary benchmarks: 🎉 relevant improvements found

	mean¹	max	count²
Regressions 😿 (primary)	2.3%	2.3%	1
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-3.0%	-3.8%	3
All 😿🎉 (primary)	2.3%	2.3%	1

Cycles

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: 😿 relevant regression found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.1%	2.1%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

nrc added T-libs-api [DEPRECATED; DO NOT USE] A-error-handling Area: Error handling PG-error-handling Project group: Error handling (https://github.com/rust-lang/project-error-handling) labels Dec 15, 2021

rust-highfive assigned scottmcm Dec 15, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 15, 2021

This comment has been minimized.
Sign in to view

nrc force-pushed the provide-any branch from 3ff72c9 to 7156c07Compare December 16, 2021 09:19

This comment has been minimized.
Sign in to view

nrc force-pushed the provide-any branch from 7156c07 to 916d7b0Compare December 16, 2021 09:37

This comment has been minimized.
Sign in to view

nrc force-pushed the provide-any branch from 916d7b0 to ffda73cCompare January 17, 2022 10:41

This comment has been minimized.
Sign in to view

nrc force-pushed the provide-any branch from ffda73c to e6997a3Compare January 17, 2022 13:49

yaahc mentioned this pull request Jan 18, 2022
Add provide_any module to core rust-lang/rfcs#3192
Merged

bstrie mentioned this pull request Jan 19, 2022
Proposal: use anyhow crate and pass extra context to error messages enarx/enarx#726
Closed

scottmcm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2022

nrc force-pushed the provide-any branch from e6997a3 to 97c9099Compare February 25, 2022 17:35

yaahc reviewed Mar 22, 2022
View reviewed changes

Comment threadlibrary/core/src/any.rs Outdated
Comment threadlibrary/core/src/any.rs

yaahc mentioned this pull request Mar 29, 2022
remove trait-upcasting restriction on downstream users of provider nrc/rust#4
Closed

nrc force-pushed the provide-any branch from 525d0f6 to 4f6c9eeCompare April 12, 2022 09:50

This comment has been minimized.
Sign in to view

nrc force-pushed the provide-any branch from 135c86c to 31fb97aCompare April 12, 2022 21:25

yaahc mentioned this pull request Apr 13, 2022
Tracking Issue for Provider API #96024
Open
7 tasks

scottmcm requested changes May 6, 2022
View reviewed changes

scottmcm mentioned this pull request May 7, 2022
Tracking issue for explicit_generic_args_with_impl_trait#83701
Closed
3 tasks

nrc force-pushed the provide-any branch from 9bc8a0d to 294f0faCompare May 11, 2022 09:12

Dylan-DPC added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 14, 2022

TimDiekmann reviewed May 30, 2022
View reviewed changes

Comment threadlibrary/core/src/any.rs Outdated
Comment threadlibrary/core/src/any.rs Outdated

nrc added 7 commits June 6, 2022 12:10

Add the Provider api to core::any
bb5db85
Signed-off-by: Nick Cameron <nrc@ncameron.org>

Modify the signature of the request_* methods so that trait_upcasting…
57d027d
… is not required Signed-off-by: Nick Cameron <nrc@ncameron.org>

Update docs
17730e6
Signed-off-by: Nick Cameron <nrc@ncameron.org>

Add examples to docs
e82368d
Signed-off-by: Nick Cameron <nrc@ncameron.org>

Add tracking issue number
2e0ca25
Signed-off-by: Nick Cameron <nrc@ncameron.org>

Add some more tests
843f90c
Signed-off-by: Nick Cameron <nrc@ncameron.org>

Address reviewer comments
6629010
Signed-off-by: Nick Cameron <nrc@ncameron.org>

nrc force-pushed the provide-any branch from 294f0fa to 6629010Compare June 6, 2022 11:19

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 10, 2022

bors merged commit e9aff9c into rust-lang:masterJun 10, 2022

rustbot added this to the 1.63.0 milestone Jun 10, 2022

This was referenced Jun 10, 2022
Add slice methods for indexing via an array of indices. #83608
Merged
Std module docs improvements #93162
Merged
Add Iterator::map_windows#94667
Merged

yaahc mentioned this pull request Jul 15, 2022
Move Error trait into core rust-lang/project-error-handling#3
Open

Uh oh!

Uh oh!

Conversation

nrc commented Dec 15, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Dec 15, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors commented Feb 1, 2022

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

scottmcm left a comment

Choose a reason for hiding this comment

Uh oh!

nrc commented May 11, 2022

Uh oh!

TimDiekmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nrc commented Jun 6, 2022

Uh oh!

scottmcm commented Jun 9, 2022

Uh oh!

bors commented Jun 9, 2022

Uh oh!

bors commented Jun 10, 2022

Uh oh!

bors commented Jun 10, 2022

Uh oh!

rust-timer commented Jun 10, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

nrc commented Dec 15, 2021•
edited
Loading