Skip to content

fix(dev): end websocket connections gracefully - #1001

Merged
danielroe merged 1 commit into
mainfrom
fix/windows-reset
Aug 9, 2025
Merged

fix(dev): end websocket connections gracefully#1001
danielroe merged 1 commit into
mainfrom
fix/windows-reset

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolves#994

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

particularly in windows (but there seems nothing windows-specific) about the situation, an unhandledRejection is thrown when the dev server keeps trying to connect to the vite websocket whilst nuxt is restarting.

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Stats — create-nuxt size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
495.89 MB → 5.89 MB (+119 B)+0.00%
Changeset
FileΔSize
home/runner/work/cli/cli/packages/nuxi/src/commands/dev.ts📈 +119 B (+1.04%)11.2 kB → 11.31 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

AssetFile Size% Changed
chunks/dev.mjs28.33 kB → 28.45 kB (+119 B)+0.41%

Smaller

No assets were smaller

Unchanged

AssetFile Size% Changed
index.mjs1.07 kB0%
chunks/multipart-parser.mjs5.11 kB0%
chunks/multipart-parser2.mjs4.58 kB0%
chunks/add.mjs6.89 kB0%
chunks/analyze.mjs3.35 kB0%
chunks/build.mjs2.04 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs811 B0%
chunks/devtools.mjs764 B0%
chunks/generate.mjs492 B0%
chunks/info.mjs4.43 kB0%
chunks/index.mjs274 B0%
chunks/prepare.mjs1.04 kB0%
chunks/preview.mjs3.58 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs2.06 kB0%
chunks/upgrade.mjs6.28 kB0%
chunks/prompt.mjs42.91 kB0%
chunks/satisfies.mjs116 B0%
chunks/index2.mjs198.56 kB0%
chunks/jiti.mjs305 B0%
chunks/index3.mjs71.97 kB0%
chunks/add2.mjs12.08 kB0%
chunks/search.mjs45.85 kB0%
chunks/xdg-open.mjs25.32 kB0%
chunks/node.mjs145.67 kB0%
chunks/index4.mjs1.23 kB0%
chunks/index5.mjs5.85 kB0%
chunks/index6.mjs6.24 kB0%
chunks/index7.mjs50.51 kB0%
chunks/index8.mjs904.05 kB0%
shared/create-nuxt.BjKacOJS.mjs953.25 kB0%
shared/create-nuxt.B5etFa0_.mjs792 B0%
shared/create-nuxt.i-p7pJoy.mjs294 B0%
shared/create-nuxt.CA5-6h3I.mjs3.9 kB0%
shared/create-nuxt.BSm0_9Hr.mjs107 B0%
shared/create-nuxt.Do3dooQS.mjs108.11 kB0%
shared/create-nuxt.BsKntdQB.mjs18.91 kB0%
shared/create-nuxt.DVEvgfxa.mjs1.17 MB0%
shared/create-nuxt.nZ2QeROu.mjs4.07 kB0%
shared/create-nuxt.D6gsH0zX.mjs836 B0%
shared/create-nuxt.B19oI1r4.mjs945 B0%
shared/create-nuxt.DZ0mjkKC.mjs18.08 kB0%
shared/create-nuxt.DGw492ZO.mjs2.02 MB0%
shared/create-nuxt.BjhZEm2-.mjs1.75 kB0%
shared/create-nuxt.Ctv7HgDH.mjs4.06 kB0%
shared/create-nuxt.Vk1IrVtB.mjs26.96 kB0%
shared/create-nuxt.4t9faemh.mjs43.64 kB0%

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Stats — nuxt-cli size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
3297.39 kB → 97.5 kB (+119 B)+0.12%
Changeset
FileΔSize
home/runner/work/cli/cli/packages/nuxi/src/commands/dev.ts📈 +119 B (+1.04%)11.2 kB → 11.31 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

AssetFile Size% Changed
chunks/dev.mjs11.2 kB → 11.31 kB (+119 B)+1.04%

Smaller

No assets were smaller

Unchanged

AssetFile Size% Changed
dev/index.mjs0 B0%
index.mjs236 B0%
chunks/index.mjs14.44 kB0%
chunks/analyze.mjs3.35 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs815 B0%
chunks/devtools.mjs763 B0%
chunks/generate.mjs492 B0%
chunks/build.mjs2.04 kB0%
chunks/info.mjs4.44 kB0%
chunks/index2.mjs273 B0%
chunks/add.mjs10.17 kB0%
chunks/search.mjs2.96 kB0%
chunks/prepare.mjs1.04 kB0%
chunks/preview.mjs3.58 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs2.06 kB0%
chunks/upgrade.mjs6.28 kB0%
chunks/init.mjs12.15 kB0%
chunks/add2.mjs6.89 kB0%
shared/cli.B9AmABr3.mjs39 B0%
shared/cli.Dz2be-Ai.mjs792 B0%
shared/cli.BEUGgaW4.mjs294 B0%
shared/cli.BSm0_9Hr.mjs107 B0%
shared/cli.At9IMXtr.mjs1.23 kB0%
shared/cli.pLQ0oPGc.mjs836 B0%
shared/cli.qKvs7FJ2.mjs945 B0%
shared/cli.D-5JezqI.mjs78 B0%
shared/cli.jA1DRKbi.mjs1.04 kB0%
shared/cli.DLBhTNQQ.mjs1.8 kB0%
shared/cli.IymQnHF9.mjs5.57 kB0%

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Stats — nuxi size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
585.46 MB → 5.46 MB (+119 B)+0.00%
Changeset
FileΔSize
src/commands/dev.ts📈 +119 B (+1.04%)11.2 kB → 11.31 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

AssetFile Size% Changed
chunks/dev.mjs28.33 kB → 28.45 kB (+119 B)+0.41%

Smaller

No assets were smaller

Unchanged

AssetFile Size% Changed
index.mjs247 B0%
dev/index.mjs925 B0%
chunks/add.mjs6.89 kB0%
chunks/analyze.mjs3.35 kB0%
chunks/build.mjs2.04 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs780 B0%
chunks/devtools.mjs764 B0%
chunks/generate.mjs492 B0%
chunks/info.mjs4.43 kB0%
chunks/init.mjs668.18 kB0%
chunks/index.mjs274 B0%
chunks/prepare.mjs1.04 kB0%
chunks/preview.mjs3.58 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs2.06 kB0%
chunks/upgrade.mjs6.28 kB0%
chunks/satisfies.mjs116 B0%
chunks/main.mjs15.3 kB0%
chunks/prompt.mjs42.91 kB0%
chunks/index2.mjs198.56 kB0%
chunks/jiti.mjs305 B0%
chunks/index3.mjs71.97 kB0%
chunks/multipart-parser.mjs5.11 kB0%
chunks/add2.mjs12.08 kB0%
chunks/search.mjs45.85 kB0%
chunks/xdg-open.mjs25.32 kB0%
chunks/node.mjs145.67 kB0%
chunks/index4.mjs1.23 kB0%
chunks/index5.mjs5.85 kB0%
chunks/multipart-parser2.mjs4.58 kB0%
chunks/index6.mjs904.05 kB0%
shared/nuxi.HaPdOS2b.mjs19.33 kB0%
shared/nuxi.DQjfoGl0.mjs57.22 kB0%
shared/nuxi.CTyTlDmo.mjs18.91 kB0%
shared/nuxi.BXGZ9qFF.mjs792 B0%
shared/nuxi.C_u-rG9b.mjs294 B0%
shared/nuxi.DUZ_WukQ.mjs2.57 kB0%
shared/nuxi.8mhVoXwa.mjs916.43 kB0%
shared/nuxi.D2_bzAv0.mjs1.54 kB0%
shared/nuxi.DQbQuzNE.mjs4.07 kB0%
shared/nuxi.BSm0_9Hr.mjs107 B0%
shared/nuxi.CrvQqJcE.mjs836 B0%
shared/nuxi.BiWTNJI4.mjs945 B0%
shared/nuxi.umkfBzIJ.mjs18.08 kB0%
shared/nuxi.CSWGOxQ4.mjs10.56 kB0%
shared/nuxi.BAGoDD49.mjs1.05 kB0%
shared/nuxi.BoQ074Vk.mjs2.02 MB0%
shared/nuxi.BjhZEm2-.mjs1.75 kB0%
shared/nuxi.uGuG0uDx.mjs4.06 kB0%
shared/nuxi.DU9QXUOf.mjs26.96 kB0%
shared/nuxi.BzZJv2UC.mjs123.67 kB0%
shared/nuxi.QWnQy_ku.mjs5.75 kB0%
shared/nuxi.D3mADRf9.mjs14.73 kB0%
shared/nuxi.BLb4POFS.mjs42.47 kB0%
shared/nuxi.Do0aYBCO.mjs5.46 kB0%
shared/nuxi.4t9faemh.mjs43.64 kB0%

@pkg-pr-new

pkg-pr-newBot commented Aug 9, 2025

Copy link
Copy Markdown

nuxt-cli-playground

npm i https://pkg.pr.new/create-nuxt@1001
npm i https://pkg.pr.new/nuxi@1001
npm i https://pkg.pr.new/@nuxt/cli@1001

commit: 7970c2e

@codspeed-hq

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #1001 will not alter performance

Comparing fix/windows-reset (7970c2e) with main (6b80c59)

Summary

✅ 2 untouched benchmarks

@danielroe
danielroe marked this pull request as ready for review August 9, 2025 14:09
@danielroe
danielroe merged commit 5ed6a60 into mainAug 9, 2025
14 checks passed
@danielroe
danielroe deleted the fix/windows-reset branch August 9, 2025 14:09
@github-actionsgithub-actionsBot mentioned this pull request Aug 9, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ERROR [unhandledRejection] read ECONNRESET in dev environment

1 participant

@danielroe