Skip to content

fix(upgrade): do not use cache when getting nuxt version - #1002

Merged
danielroe merged 2 commits into
mainfrom
fix/cached-upgrade
Aug 9, 2025
Merged

fix(upgrade): do not use cache when getting nuxt version#1002
danielroe merged 2 commits into
mainfrom
fix/cached-upgrade

Conversation

@danielroe

@danielroedanielroe commented Aug 9, 2025•
edited
Loading

Copy link
Copy Markdown
Member

📚 Description

saw this reported somewhere (can't recall) - basically, because pkg-types caches the version of a dependency, when we update it will always report the same version as now installed

I've also de-duplicated the getNuxtVersion code which was shared with module utils

related: #996

@github-actions

github-actionsBot commented Aug 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Bundle Stats — nuxt-cli size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
32 → 3397.5 kB → 97.25 kB (-258 B)-0.26%
Changeset
FileΔSize
home/runner/work/cli/cli/packages/nuxi/src/utils/versions.ts🆕 +351 B0 B → 351 B
home/runner/work/cli/cli/packages/nuxi/src/commands/upgrade.ts📉 -271 B (-4.21%)6.28 kB → 6.01 kB
home/runner/work/cli/cli/packages/nuxi/src/commands/module/_utils.ts📉 -338 B (-31.74%)1.04 kB → 727 B
View detailed bundle breakdown

Added

AssetFile Size% Changed
shared/cli.Cr-OCgdO.mjs0 B → 727 B (+727 B)-
shared/cli.DHenkA1C.mjs0 B → 351 B (+351 B)-

Removed

AssetFile Size% Changed
shared/cli.jA1DRKbi.mjs1.04 kB → 0 B (-1.04 kB)-100%

Bigger

No assets were bigger

Smaller

AssetFile Size% Changed
chunks/upgrade.mjs6.28 kB → 6.01 kB (-271 B)-4.21%

Unchanged

AssetFile Size% Changed
dev/index.mjs0 B0%
index.mjs236 B0%
chunks/index.mjs14.44 kB0%
chunks/analyze.mjs3.35 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs815 B0%
chunks/dev.mjs11.31 kB0%
chunks/devtools.mjs763 B0%
chunks/generate.mjs492 B0%
chunks/build.mjs2.04 kB0%
chunks/info.mjs4.44 kB0%
chunks/index2.mjs273 B0%
chunks/add.mjs10.17 kB0%
chunks/search.mjs2.96 kB0%
chunks/prepare.mjs1.04 kB0%
chunks/preview.mjs3.58 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs2.06 kB0%
chunks/init.mjs12.15 kB0%
chunks/add2.mjs6.89 kB0%
shared/cli.B9AmABr3.mjs39 B0%
shared/cli.Dz2be-Ai.mjs792 B0%
shared/cli.BEUGgaW4.mjs294 B0%
shared/cli.BSm0_9Hr.mjs107 B0%
shared/cli.At9IMXtr.mjs1.23 kB0%
shared/cli.pLQ0oPGc.mjs836 B0%
shared/cli.qKvs7FJ2.mjs945 B0%
shared/cli.D-5JezqI.mjs78 B0%
shared/cli.DLBhTNQQ.mjs1.8 kB0%
shared/cli.IymQnHF9.mjs5.57 kB0%

@github-actions

github-actionsBot commented Aug 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Bundle Stats — create-nuxt size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
49 → 505.89 MB → 5.89 MB (-258 B)-0.00%
Changeset
FileΔSize
home/runner/work/cli/cli/packages/nuxi/src/utils/versions.ts🆕 +365 B0 B → 365 B
home/runner/work/cli/cli/packages/nuxi/src/commands/upgrade.ts📉 -271 B (-4.21%)6.28 kB → 6.01 kB
home/runner/work/cli/cli/packages/nuxi/src/commands/module/_utils.ts📉 -352 B (-32.41%)1.06 kB → 734 B
View detailed bundle breakdown

Added

AssetFile Size% Changed
shared/create-nuxt.RtVqAU5m.mjs0 B → 3.72 kB (+3.72 kB)-
shared/create-nuxt.BuM2wstx.mjs0 B → 365 B (+365 B)-

Removed

AssetFile Size% Changed
shared/create-nuxt.Ctv7HgDH.mjs4.06 kB → 0 B (-4.06 kB)-100%

Bigger

No assets were bigger

Smaller

AssetFile Size% Changed
chunks/upgrade.mjs6.28 kB → 6.01 kB (-271 B)-4.21%

Unchanged

AssetFile Size% Changed
index.mjs1.07 kB0%
chunks/multipart-parser.mjs5.11 kB0%
chunks/multipart-parser2.mjs4.58 kB0%
chunks/add.mjs6.89 kB0%
chunks/analyze.mjs3.35 kB0%
chunks/build.mjs2.04 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs811 B0%
chunks/dev.mjs28.45 kB0%
chunks/devtools.mjs764 B0%
chunks/generate.mjs492 B0%
chunks/info.mjs4.43 kB0%
chunks/index.mjs274 B0%
chunks/prepare.mjs1.04 kB0%
chunks/preview.mjs3.58 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs2.06 kB0%
chunks/prompt.mjs42.91 kB0%
chunks/satisfies.mjs116 B0%
chunks/index2.mjs198.56 kB0%
chunks/jiti.mjs305 B0%
chunks/index3.mjs71.97 kB0%
chunks/add2.mjs12.08 kB0%
chunks/search.mjs45.85 kB0%
chunks/xdg-open.mjs25.32 kB0%
chunks/node.mjs145.67 kB0%
chunks/index4.mjs1.23 kB0%
chunks/index5.mjs5.85 kB0%
chunks/index6.mjs6.24 kB0%
chunks/index7.mjs50.51 kB0%
chunks/index8.mjs904.05 kB0%
shared/create-nuxt.BjKacOJS.mjs953.25 kB0%
shared/create-nuxt.B5etFa0_.mjs792 B0%
shared/create-nuxt.i-p7pJoy.mjs294 B0%
shared/create-nuxt.CA5-6h3I.mjs3.9 kB0%
shared/create-nuxt.BSm0_9Hr.mjs107 B0%
shared/create-nuxt.Do3dooQS.mjs108.11 kB0%
shared/create-nuxt.BsKntdQB.mjs18.91 kB0%
shared/create-nuxt.DVEvgfxa.mjs1.17 MB0%
shared/create-nuxt.nZ2QeROu.mjs4.07 kB0%
shared/create-nuxt.D6gsH0zX.mjs836 B0%
shared/create-nuxt.B19oI1r4.mjs945 B0%
shared/create-nuxt.DZ0mjkKC.mjs18.08 kB0%
shared/create-nuxt.DGw492ZO.mjs2.02 MB0%
shared/create-nuxt.BjhZEm2-.mjs1.75 kB0%
shared/create-nuxt.Vk1IrVtB.mjs26.96 kB0%
shared/create-nuxt.4t9faemh.mjs43.64 kB0%

@github-actions

github-actionsBot commented Aug 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Bundle Stats — nuxi size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
58 → 595.46 MB → 5.46 MB (-258 B)-0.00%
Changeset
FileΔSize
src/utils/versions.ts🆕 +365 B0 B → 365 B
src/commands/upgrade.ts📉 -271 B (-4.21%)6.28 kB → 6.01 kB
src/commands/module/_utils.ts📉 -352 B (-32.41%)1.06 kB → 734 B
View detailed bundle breakdown

Added

AssetFile Size% Changed
shared/nuxi.Jdh1a7T5.mjs0 B → 3.72 kB (+3.72 kB)-
shared/nuxi.BcK1uW4h.mjs0 B → 365 B (+365 B)-

Removed

AssetFile Size% Changed
shared/nuxi.uGuG0uDx.mjs4.06 kB → 0 B (-4.06 kB)-100%

Bigger

No assets were bigger

Smaller

AssetFile Size% Changed
chunks/upgrade.mjs6.28 kB → 6.01 kB (-271 B)-4.21%

Unchanged

AssetFile Size% Changed
index.mjs247 B0%
dev/index.mjs925 B0%
chunks/add.mjs6.89 kB0%
chunks/analyze.mjs3.35 kB0%
chunks/build.mjs2.04 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs780 B0%
chunks/dev.mjs28.45 kB0%
chunks/devtools.mjs764 B0%
chunks/generate.mjs492 B0%
chunks/info.mjs4.43 kB0%
chunks/init.mjs668.18 kB0%
chunks/index.mjs274 B0%
chunks/prepare.mjs1.04 kB0%
chunks/preview.mjs3.58 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs2.06 kB0%
chunks/satisfies.mjs116 B0%
chunks/main.mjs15.3 kB0%
chunks/prompt.mjs42.91 kB0%
chunks/index2.mjs198.56 kB0%
chunks/jiti.mjs305 B0%
chunks/index3.mjs71.97 kB0%
chunks/multipart-parser.mjs5.11 kB0%
chunks/add2.mjs12.08 kB0%
chunks/search.mjs45.85 kB0%
chunks/xdg-open.mjs25.32 kB0%
chunks/node.mjs145.67 kB0%
chunks/index4.mjs1.23 kB0%
chunks/index5.mjs5.85 kB0%
chunks/multipart-parser2.mjs4.58 kB0%
chunks/index6.mjs904.05 kB0%
shared/nuxi.HaPdOS2b.mjs19.33 kB0%
shared/nuxi.DQjfoGl0.mjs57.22 kB0%
shared/nuxi.CTyTlDmo.mjs18.91 kB0%
shared/nuxi.BXGZ9qFF.mjs792 B0%
shared/nuxi.C_u-rG9b.mjs294 B0%
shared/nuxi.DUZ_WukQ.mjs2.57 kB0%
shared/nuxi.8mhVoXwa.mjs916.43 kB0%
shared/nuxi.D2_bzAv0.mjs1.54 kB0%
shared/nuxi.DQbQuzNE.mjs4.07 kB0%
shared/nuxi.BSm0_9Hr.mjs107 B0%
shared/nuxi.CrvQqJcE.mjs836 B0%
shared/nuxi.BiWTNJI4.mjs945 B0%
shared/nuxi.umkfBzIJ.mjs18.08 kB0%
shared/nuxi.CSWGOxQ4.mjs10.56 kB0%
shared/nuxi.BAGoDD49.mjs1.05 kB0%
shared/nuxi.BoQ074Vk.mjs2.02 MB0%
shared/nuxi.BjhZEm2-.mjs1.75 kB0%
shared/nuxi.DU9QXUOf.mjs26.96 kB0%
shared/nuxi.BzZJv2UC.mjs123.67 kB0%
shared/nuxi.QWnQy_ku.mjs5.75 kB0%
shared/nuxi.D3mADRf9.mjs14.73 kB0%
shared/nuxi.BLb4POFS.mjs42.47 kB0%
shared/nuxi.Do0aYBCO.mjs5.46 kB0%
shared/nuxi.4t9faemh.mjs43.64 kB0%

@pkg-pr-new

pkg-pr-newBot commented Aug 9, 2025•
edited
Loading

Copy link
Copy Markdown

nuxt-cli-playground

npm i https://pkg.pr.new/create-nuxt@1002

npm i https://pkg.pr.new/nuxi@1002

npm i https://pkg.pr.new/@nuxt/cli@1002

commit: 54d3e47

@codspeed-hq

codspeed-hqBot commented Aug 9, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #1002 will not alter performance

Comparing fix/cached-upgrade (54d3e47) with main (5ed6a60)

Summary

✅ 2 untouched benchmarks

@danielroe
danielroe merged commit d98e41d into mainAug 9, 2025
14 checks passed
@danielroe
danielroe deleted the fix/cached-upgrade branch August 9, 2025 14:48
@github-actionsgithub-actionsBot mentioned this pull request Aug 9, 2025
Merged
@EazashEazash mentioned this pull request Sep 17, 2025
Merged
6 tasks
@coderabbitaicoderabbitaiBot mentioned this pull request Jul 26, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@danielroe