Skip to content

fix: prioritise @nuxt/kit from nuxt dependencies - #929

Merged
danielroe merged 1 commit into
mainfrom
fix/kit-version
Jun 27, 2025
Merged

fix: prioritise @nuxt/kit from nuxt dependencies#929
danielroe merged 1 commit into
mainfrom
fix/kit-version

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

currently we might pick an older version of nuxt/kit if a module has installed it and it's available locally.

this ensures we prefer the version of kit matching nuxt. (newer versions of kit, if installed, might be deduplicated by package manager but should 'flow down', so this is safer - and should also be more performant)

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Stats — create-nuxt size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
495.88 MB → 5.88 MB (-135 B)-0.00%
Changeset
FileΔSize
home/runner/work/cli/cli/packages/nuxi/src/utils/kit.ts📉 -135 B (-12.50%)1.05 kB → 945 B
View detailed bundle breakdown

Added

AssetFile Size% Changed
shared/create-nuxt.C4mQdlco.mjs0 B → 945 B (+945 B)-
shared/create-nuxt.CLkBPnlR.mjs0 B → 792 B (+792 B)-

Removed

AssetFile Size% Changed
shared/create-nuxt.0VtSoDeL.mjs1.05 kB → 0 B (-1.05 kB)-100%
shared/create-nuxt.GQ4ySyuL.mjs792 B → 0 B (-792 B)-100%

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

AssetFile Size% Changed
index.mjs1.07 kB0%
chunks/multipart-parser.mjs5.11 kB0%
chunks/multipart-parser2.mjs4.58 kB0%
chunks/add.mjs6.89 kB0%
chunks/analyze.mjs3.27 kB0%
chunks/build.mjs1.96 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs811 B0%
chunks/dev.mjs27.24 kB0%
chunks/devtools.mjs764 B0%
chunks/generate.mjs472 B0%
chunks/info.mjs4.38 kB0%
chunks/index.mjs274 B0%
chunks/prepare.mjs984 B0%
chunks/preview.mjs3.5 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs1.78 kB0%
chunks/upgrade.mjs6.28 kB0%
chunks/prompt.mjs42.91 kB0%
chunks/satisfies.mjs116 B0%
chunks/index2.mjs194.26 kB0%
chunks/jiti.mjs305 B0%
chunks/index3.mjs71.97 kB0%
chunks/add2.mjs12.08 kB0%
chunks/search.mjs45.85 kB0%
chunks/xdg-open.mjs25.32 kB0%
chunks/node.mjs145.67 kB0%
chunks/index4.mjs1.23 kB0%
chunks/index5.mjs5.85 kB0%
chunks/index6.mjs6.24 kB0%
chunks/index7.mjs50.51 kB0%
chunks/index8.mjs898.9 kB0%
shared/create-nuxt.B71Ptx3t.mjs963.78 kB0%
shared/create-nuxt.BzVnAJ6D.mjs294 B0%
shared/create-nuxt.BZEC9aF-.mjs3.9 kB0%
shared/create-nuxt.BSm0_9Hr.mjs107 B0%
shared/create-nuxt.BHNcDoGS.mjs108.11 kB0%
shared/create-nuxt.DWN1j4sa.mjs18.91 kB0%
shared/create-nuxt.DzJUR39Z.mjs1.17 MB0%
shared/create-nuxt.DgkXlNAq.mjs4.07 kB0%
shared/create-nuxt.DrUPYlIo.mjs836 B0%
shared/create-nuxt.BGYNhO8g.mjs15.27 kB0%
shared/create-nuxt.Be-Kjlkt.mjs2.02 MB0%
shared/create-nuxt.BjhZEm2-.mjs1.75 kB0%
shared/create-nuxt.CNhf76gk.mjs4.06 kB0%
shared/create-nuxt.Vk1IrVtB.mjs26.96 kB0%
shared/create-nuxt.4t9faemh.mjs43.64 kB0%

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Stats — nuxt-cli size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
3290.29 kB → 90.16 kB (-135 B)-0.15%
Changeset
FileΔSize
home/runner/work/cli/cli/packages/nuxi/src/utils/kit.ts📉 -135 B (-12.50%)1.05 kB → 945 B
View detailed bundle breakdown

Added

AssetFile Size% Changed
shared/cli.qKvs7FJ2.mjs0 B → 945 B (+945 B)-
shared/cli.Dz2be-Ai.mjs0 B → 792 B (+792 B)-

Removed

AssetFile Size% Changed
shared/cli.BrKZotr9.mjs1.05 kB → 0 B (-1.05 kB)-100%
shared/cli.Dvb-m6bf.mjs792 B → 0 B (-792 B)-100%

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

AssetFile Size% Changed
dev/index.mjs0 B0%
index.mjs236 B0%
chunks/index.mjs11.43 kB0%
chunks/analyze.mjs3.27 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs815 B0%
chunks/dev.mjs10.09 kB0%
chunks/devtools.mjs763 B0%
chunks/generate.mjs472 B0%
chunks/build.mjs1.96 kB0%
chunks/info.mjs4.39 kB0%
chunks/index2.mjs273 B0%
chunks/add.mjs10.17 kB0%
chunks/search.mjs2.96 kB0%
chunks/prepare.mjs984 B0%
chunks/preview.mjs3.5 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs1.78 kB0%
chunks/upgrade.mjs6.28 kB0%
chunks/init.mjs9.85 kB0%
chunks/add2.mjs6.89 kB0%
shared/cli.B9AmABr3.mjs39 B0%
shared/cli.BEUGgaW4.mjs294 B0%
shared/cli.BSm0_9Hr.mjs107 B0%
shared/cli.At9IMXtr.mjs1.23 kB0%
shared/cli.pLQ0oPGc.mjs836 B0%
shared/cli.P0cplz3M.mjs78 B0%
shared/cli.jA1DRKbi.mjs1.04 kB0%
shared/cli.BLVI_04J.mjs1.8 kB0%
shared/cli.yHMpVeHl.mjs5.42 kB0%

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Stats — nuxi size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
585.46 MB → 5.46 MB (-135 B)-0.00%
Changeset
FileΔSize
src/utils/kit.ts📉 -135 B (-12.50%)1.05 kB → 945 B
View detailed bundle breakdown

Added

AssetFile Size% Changed
shared/nuxi.BiWTNJI4.mjs0 B → 945 B (+945 B)-
shared/nuxi.DzMZtGWH.mjs0 B → 792 B (+792 B)-

Removed

AssetFile Size% Changed
shared/nuxi.dlymdmbV.mjs1.05 kB → 0 B (-1.05 kB)-100%
shared/nuxi.DKSCJgDw.mjs792 B → 0 B (-792 B)-100%

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

AssetFile Size% Changed
index.mjs247 B0%
dev/index.mjs896 B0%
chunks/add.mjs6.89 kB0%
chunks/analyze.mjs3.27 kB0%
chunks/build.mjs1.96 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs780 B0%
chunks/dev.mjs27.24 kB0%
chunks/devtools.mjs764 B0%
chunks/generate.mjs472 B0%
chunks/info.mjs4.38 kB0%
chunks/init.mjs665.88 kB0%
chunks/index.mjs274 B0%
chunks/prepare.mjs984 B0%
chunks/preview.mjs3.5 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs1.78 kB0%
chunks/upgrade.mjs6.28 kB0%
chunks/satisfies.mjs116 B0%
chunks/main.mjs15.3 kB0%
chunks/prompt.mjs42.91 kB0%
chunks/jiti.mjs305 B0%
chunks/index2.mjs194.26 kB0%
chunks/index3.mjs71.97 kB0%
chunks/multipart-parser.mjs5.11 kB0%
chunks/add2.mjs12.08 kB0%
chunks/search.mjs45.85 kB0%
chunks/xdg-open.mjs25.32 kB0%
chunks/node.mjs145.67 kB0%
chunks/index4.mjs1.23 kB0%
chunks/index5.mjs5.85 kB0%
chunks/multipart-parser2.mjs4.58 kB0%
chunks/index6.mjs898.9 kB0%
shared/nuxi.DFIyyeua.mjs19.18 kB0%
shared/nuxi.Dh2ZdpAd.mjs57.22 kB0%
shared/nuxi.CTyTlDmo.mjs18.91 kB0%
shared/nuxi.BtDT0y5R.mjs294 B0%
shared/nuxi.Cm5apyPX.mjs2.57 kB0%
shared/nuxi.Db0skjkt.mjs915.23 kB0%
shared/nuxi.D2_bzAv0.mjs1.54 kB0%
shared/nuxi.DtQ0anGB.mjs4.07 kB0%
shared/nuxi.BSm0_9Hr.mjs107 B0%
shared/nuxi.DMyZmNH9.mjs836 B0%
shared/nuxi.BMIgfYLN.mjs15.26 kB0%
shared/nuxi.DRfkfsvA.mjs25.34 kB0%
shared/nuxi.D5KtpA0t.mjs984 B0%
shared/nuxi.wc1-AWrO.mjs2.02 MB0%
shared/nuxi.BjhZEm2-.mjs1.75 kB0%
shared/nuxi.pQKP70qC.mjs4.06 kB0%
shared/nuxi.DU9QXUOf.mjs26.96 kB0%
shared/nuxi.BzZJv2UC.mjs123.67 kB0%
shared/nuxi.QWnQy_ku.mjs5.75 kB0%
shared/nuxi.CvGKll9s.mjs12.8 kB0%
shared/nuxi.BLb4POFS.mjs42.47 kB0%
shared/nuxi.Do0aYBCO.mjs5.46 kB0%
shared/nuxi.4t9faemh.mjs43.64 kB0%

@pkg-pr-new

Copy link
Copy Markdown

nuxt-cli-playground

npm i https://pkg.pr.new/create-nuxt@929
npm i https://pkg.pr.new/nuxi@929
npm i https://pkg.pr.new/@nuxt/cli@929

commit: cfa2ccb

@codspeed-hq

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #929 will not alter performance

Comparing fix/kit-version (cfa2ccb) with main (e5ef49e)

Summary

✅ 2 untouched benchmarks

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@danielroe