Skip to content

fix(dev): ensure we listen on port if _PORT is set - #940

Merged
danielroe merged 3 commits into
mainfrom
fix/dev-test
Jul 7, 2025
Merged

fix(dev): ensure we listen on port if _PORT is set#940
danielroe merged 3 commits into
mainfrom
fix/dev-test

Conversation

@danielroe

@danielroedanielroe commented Jul 7, 2025

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

A regression from #921, this ensures if _PORT is set that we don't create a socket but instead listen on that port.

@danielroedanielroe self-assigned this Jul 7, 2025
@codspeed-hq

codspeed-hqBot commented Jul 7, 2025•
edited
Loading

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #940 will not alter performance

Comparing fix/dev-test (b550ed3) with main (d265e6f)

Summary

✅ 2 untouched benchmarks

@pkg-pr-new

pkg-pr-newBot commented Jul 7, 2025•
edited
Loading

Copy link
Copy Markdown

nuxt-cli-playground

npm i https://pkg.pr.new/create-nuxt@940

npm i https://pkg.pr.new/nuxi@940

npm i https://pkg.pr.new/@nuxt/cli@940

commit: b550ed3

@github-actions

github-actionsBot commented Jul 7, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Bundle Stats — nuxt-cli size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
3294.27 kB → 94.39 kB (+123 B)+0.13%
Changeset
FileΔSize
home/runner/work/cli/cli/packages/nuxi/src/dev/index.ts📈 +123 B (+4.44%)2.7 kB → 2.82 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

AssetFile Size% Changed
chunks/index.mjs14.57 kB → 14.69 kB (+123 B)+0.82%

Smaller

No assets were smaller

Unchanged

AssetFile Size% Changed
dev/index.mjs0 B0%
index.mjs236 B0%
chunks/analyze.mjs3.27 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs815 B0%
chunks/dev.mjs10.89 kB0%
chunks/devtools.mjs763 B0%
chunks/generate.mjs472 B0%
chunks/build.mjs1.96 kB0%
chunks/info.mjs4.44 kB0%
chunks/index2.mjs273 B0%
chunks/add.mjs10.17 kB0%
chunks/search.mjs2.96 kB0%
chunks/prepare.mjs984 B0%
chunks/preview.mjs3.5 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs1.91 kB0%
chunks/upgrade.mjs6.28 kB0%
chunks/init.mjs9.85 kB0%
chunks/add2.mjs6.89 kB0%
shared/cli.B9AmABr3.mjs39 B0%
shared/cli.Dz2be-Ai.mjs792 B0%
shared/cli.BEUGgaW4.mjs294 B0%
shared/cli.BSm0_9Hr.mjs107 B0%
shared/cli.At9IMXtr.mjs1.23 kB0%
shared/cli.pLQ0oPGc.mjs836 B0%
shared/cli.qKvs7FJ2.mjs945 B0%
shared/cli.P0cplz3M.mjs78 B0%
shared/cli.jA1DRKbi.mjs1.04 kB0%
shared/cli.BLVI_04J.mjs1.8 kB0%
shared/cli.yHMpVeHl.mjs5.42 kB0%

@github-actions

github-actionsBot commented Jul 7, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Bundle Stats — nuxi size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
585.46 MB → 5.46 MB (+125 B)+0.00%
Changeset
FileΔSize
src/dev/index.ts📈 +125 B (+4.48%)2.72 kB → 2.84 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

AssetFile Size% Changed
chunks/index2.mjs197.58 kB → 197.7 kB (+125 B)+0.06%

Smaller

No assets were smaller

Unchanged

AssetFile Size% Changed
index.mjs247 B0%
dev/index.mjs925 B0%
chunks/add.mjs6.89 kB0%
chunks/analyze.mjs3.27 kB0%
chunks/build.mjs1.96 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs780 B0%
chunks/dev.mjs28.03 kB0%
chunks/devtools.mjs764 B0%
chunks/generate.mjs472 B0%
chunks/info.mjs4.43 kB0%
chunks/init.mjs665.87 kB0%
chunks/index.mjs274 B0%
chunks/prepare.mjs984 B0%
chunks/preview.mjs3.5 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs1.91 kB0%
chunks/upgrade.mjs6.28 kB0%
chunks/satisfies.mjs116 B0%
chunks/main.mjs15.3 kB0%
chunks/prompt.mjs42.91 kB0%
chunks/jiti.mjs305 B0%
chunks/index3.mjs71.97 kB0%
chunks/multipart-parser.mjs5.11 kB0%
chunks/add2.mjs12.08 kB0%
chunks/search.mjs45.85 kB0%
chunks/xdg-open.mjs25.32 kB0%
chunks/node.mjs145.67 kB0%
chunks/index4.mjs1.23 kB0%
chunks/index5.mjs5.85 kB0%
chunks/multipart-parser2.mjs4.58 kB0%
chunks/index6.mjs898.9 kB0%
shared/nuxi.DFIyyeua.mjs19.18 kB0%
shared/nuxi.Dh2ZdpAd.mjs57.22 kB0%
shared/nuxi.CTyTlDmo.mjs18.91 kB0%
shared/nuxi.DzMZtGWH.mjs792 B0%
shared/nuxi.BtDT0y5R.mjs294 B0%
shared/nuxi.Cm5apyPX.mjs2.57 kB0%
shared/nuxi.Db0skjkt.mjs915.23 kB0%
shared/nuxi.D2_bzAv0.mjs1.54 kB0%
shared/nuxi.DtQ0anGB.mjs4.07 kB0%
shared/nuxi.BSm0_9Hr.mjs107 B0%
shared/nuxi.DMyZmNH9.mjs836 B0%
shared/nuxi.BiWTNJI4.mjs945 B0%
shared/nuxi.CjPgFUSq.mjs15.27 kB0%
shared/nuxi.ChutbOY_.mjs25.34 kB0%
shared/nuxi.D5KtpA0t.mjs984 B0%
shared/nuxi._Un-q2ql.mjs2.02 MB0%
shared/nuxi.BjhZEm2-.mjs1.75 kB0%
shared/nuxi.BEgIcxrx.mjs4.06 kB0%
shared/nuxi.DU9QXUOf.mjs26.96 kB0%
shared/nuxi.BzZJv2UC.mjs123.67 kB0%
shared/nuxi.QWnQy_ku.mjs5.75 kB0%
shared/nuxi.CbyJ5osS.mjs13.45 kB0%
shared/nuxi.BLb4POFS.mjs42.47 kB0%
shared/nuxi.Do0aYBCO.mjs5.46 kB0%
shared/nuxi.4t9faemh.mjs43.64 kB0%

@github-actions

github-actionsBot commented Jul 7, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Bundle Stats — create-nuxt size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
495.89 MB → 5.89 MB (+125 B)+0.00%
Changeset
FileΔSize
home/runner/work/cli/cli/packages/nuxi/src/dev/index.ts📈 +125 B (+4.48%)2.72 kB → 2.84 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

AssetFile Size% Changed
chunks/index2.mjs197.58 kB → 197.7 kB (+125 B)+0.06%

Smaller

No assets were smaller

Unchanged

AssetFile Size% Changed
index.mjs1.07 kB0%
chunks/multipart-parser.mjs5.11 kB0%
chunks/multipart-parser2.mjs4.58 kB0%
chunks/add.mjs6.89 kB0%
chunks/analyze.mjs3.27 kB0%
chunks/build.mjs1.96 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs811 B0%
chunks/dev.mjs28.03 kB0%
chunks/devtools.mjs764 B0%
chunks/generate.mjs472 B0%
chunks/info.mjs4.43 kB0%
chunks/index.mjs274 B0%
chunks/prepare.mjs984 B0%
chunks/preview.mjs3.5 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs1.91 kB0%
chunks/upgrade.mjs6.28 kB0%
chunks/prompt.mjs42.91 kB0%
chunks/satisfies.mjs116 B0%
chunks/jiti.mjs305 B0%
chunks/index3.mjs71.97 kB0%
chunks/add2.mjs12.08 kB0%
chunks/search.mjs45.85 kB0%
chunks/xdg-open.mjs25.32 kB0%
chunks/node.mjs145.67 kB0%
chunks/index4.mjs1.23 kB0%
chunks/index5.mjs5.85 kB0%
chunks/index6.mjs6.24 kB0%
chunks/index7.mjs50.51 kB0%
chunks/index8.mjs898.9 kB0%
shared/create-nuxt.B3STrcyM.mjs964.43 kB0%
shared/create-nuxt.BGY4dUiI.mjs792 B0%
shared/create-nuxt.Bls702kr.mjs294 B0%
shared/create-nuxt.CTZIz834.mjs3.9 kB0%
shared/create-nuxt.BSm0_9Hr.mjs107 B0%
shared/create-nuxt.DX9WOARL.mjs108.11 kB0%
shared/create-nuxt.C_rHbSeB.mjs18.91 kB0%
shared/create-nuxt.Drn2Mj-1.mjs1.17 MB0%
shared/create-nuxt.bOUheP_L.mjs4.07 kB0%
shared/create-nuxt.DbuVfATn.mjs836 B0%
shared/create-nuxt.BGD2CGTI.mjs945 B0%
shared/create-nuxt.CssRAp0b.mjs15.27 kB0%
shared/create-nuxt.DThhmweU.mjs2.02 MB0%
shared/create-nuxt.BjhZEm2-.mjs1.75 kB0%
shared/create-nuxt.BEnMq1Re.mjs4.06 kB0%
shared/create-nuxt.Vk1IrVtB.mjs26.96 kB0%
shared/create-nuxt.4t9faemh.mjs43.64 kB0%

@danielroe
danielroe merged commit 50b1fcf into mainJul 7, 2025
@danielroe
danielroe deleted the fix/dev-test branch July 7, 2025 10:07
@github-actionsgithub-actionsBot mentioned this pull request Jul 7, 2025
Closed
@danielroedanielroe mentioned this pull request Jul 14, 2025
Merged
@EazashEazash mentioned this pull request Sep 17, 2025
Merged
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@danielroedanielroe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@danielroe