Skip to content

fix: don't use sockets if provider is stackblitz - #949

Merged
danielroe merged 3 commits into
nuxt:mainfrom
OrbisK:stackblitz-dev-socket
Jul 9, 2025
Merged

fix: don't use sockets if provider is stackblitz#949
danielroe merged 3 commits into
nuxt:mainfrom
OrbisK:stackblitz-dev-socket

Conversation

@OrbisK

@OrbisKOrbisK commented Jul 9, 2025

Copy link
Copy Markdown
Member

🔗 Linked issue

fixes#948fixesnuxt/nuxt#32571

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR disables the socket usage on stackblitz. It does also allow opting out of sockets via NUXT_SOCKET=0

@OrbisK
OrbisK requested a review from danielroe as a code ownerJuly 9, 2025 15:11
@pkg-pr-new

pkg-pr-newBot commented Jul 9, 2025

Copy link
Copy Markdown

nuxt-cli-playground

npm i https://pkg.pr.new/create-nuxt@949
npm i https://pkg.pr.new/nuxi@949
npm i https://pkg.pr.new/@nuxt/cli@949

commit: 39b535c

@codecov-commenter

codecov-commenter commented Jul 9, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@048ad16). Learn more about missing BASE report.

Files with missing linesPatch %Lines
packages/nuxi/src/commands/dev.ts0.00%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #949 +/- ##
=======================================
Coverage ? 12.50% =======================================
Files ? 74 Lines ? 3901 Branches ? 112 =======================================
Hits ? 488 Misses ? 3379 Partials ? 34 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hqBot commented Jul 9, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #949 will not alter performance

Comparing OrbisK:stackblitz-dev-socket (39b535c) with main (048ad16)

Summary

✅ 2 untouched benchmarks

@OrbisKOrbisK changed the title wip: dont use sockets to test stackblitz dev serverfix: don't use sockets if provider is stackblitzJul 9, 2025
@OrbisKOrbisK changed the title fix: don't use sockets if provider is stackblitzWIP: fix: don't use sockets if provider is stackblitzJul 9, 2025
@OrbisKOrbisK changed the title WIP: fix: don't use sockets if provider is stackblitzfix: don't use sockets if provider is stackblitzJul 9, 2025
@danielroe
danielroe merged commit ddb6d80 into nuxt:mainJul 9, 2025
@github-actionsgithub-actionsBot mentioned this pull request Jul 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nuxt dev | V4 stackblitz crashes with Failed to parse http message V4 stackblitz crashes with Failed to parse http message

3 participants

@OrbisK@codecov-commenter@danielroe