Skip to content

fix(dev): temporarily refactor to use previous socket url handling - #957

Merged
danielroe merged 1 commit into
mainfrom
fix/socket-url
Jul 14, 2025
Merged

fix(dev): temporarily refactor to use previous socket url handling#957
danielroe merged 1 commit into
mainfrom
fix/socket-url

Conversation

@danielroe

@danielroedanielroe commented Jul 14, 2025•
edited
Loading

Copy link
Copy Markdown
Member

This reverts commit c7c4dd1.

🔗 Linked issue

resolves#956

📚 Description

this temporarily reverts #952 - we'll identify the issue later if this solves it, but I'm temporarily without access to windows

cc: @pi0

@github-actions

github-actionsBot commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

Bundle Stats — nuxi size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
585.47 MB → 5.47 MB (-1.02 kB)-0.02%
Changeset
FileΔSize
src/dev/socket.ts📈 +468 B (+30.81%)1.48 kB → 1.94 kB
src/commands/dev.ts📉 -7 B (-0.06%)10.96 kB → 10.96 kB
node_modules/get-port-please/dist/index.mjs📉 -1.47 kB (-17.72%)8.29 kB → 6.82 kB
View detailed bundle breakdown

Added

AssetFile Size% Changed
shared/nuxi.mckSyPJc.mjs0 B → 914.96 kB (+914.96 kB)-
shared/nuxi.B9b6BodX.mjs0 B → 2.57 kB (+2.57 kB)-

Removed

AssetFile Size% Changed
shared/nuxi.Cit_PhVF.mjs916.43 kB → 0 B (-916.43 kB)-100%
shared/nuxi.D7O6R7TO.mjs2.57 kB → 0 B (-2.57 kB)-100%

Bigger

AssetFile Size% Changed
chunks/index2.mjs197.3 kB → 197.76 kB (+468 B)+0.23%

Smaller

AssetFile Size% Changed
chunks/dev.mjs28.1 kB → 28.09 kB (-7 B)-0.02%

Unchanged

AssetFile Size% Changed
index.mjs247 B0%
dev/index.mjs925 B0%
chunks/add.mjs6.89 kB0%
chunks/analyze.mjs3.35 kB0%
chunks/build.mjs2.04 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs780 B0%
chunks/devtools.mjs764 B0%
chunks/generate.mjs492 B0%
chunks/info.mjs4.43 kB0%
chunks/init.mjs665.87 kB0%
chunks/index.mjs274 B0%
chunks/prepare.mjs1.04 kB0%
chunks/preview.mjs3.58 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs2.06 kB0%
chunks/upgrade.mjs6.28 kB0%
chunks/satisfies.mjs116 B0%
chunks/main.mjs15.3 kB0%
chunks/prompt.mjs42.91 kB0%
chunks/jiti.mjs305 B0%
chunks/index3.mjs71.97 kB0%
chunks/multipart-parser.mjs5.11 kB0%
chunks/add2.mjs12.08 kB0%
chunks/search.mjs45.85 kB0%
chunks/xdg-open.mjs25.32 kB0%
chunks/node.mjs145.67 kB0%
chunks/index4.mjs1.23 kB0%
chunks/index5.mjs5.85 kB0%
chunks/multipart-parser2.mjs4.58 kB0%
chunks/index6.mjs904.05 kB0%
shared/nuxi.BeuZslWE.mjs19.31 kB0%
shared/nuxi.Dh2ZdpAd.mjs57.22 kB0%
shared/nuxi.CTyTlDmo.mjs18.91 kB0%
shared/nuxi.DzMZtGWH.mjs792 B0%
shared/nuxi.BtDT0y5R.mjs294 B0%
shared/nuxi.D2_bzAv0.mjs1.54 kB0%
shared/nuxi.DtQ0anGB.mjs4.07 kB0%
shared/nuxi.BSm0_9Hr.mjs107 B0%
shared/nuxi.DMyZmNH9.mjs836 B0%
shared/nuxi.BiWTNJI4.mjs945 B0%
shared/nuxi.CbFGhqp3.mjs16.04 kB0%
shared/nuxi.ChutbOY_.mjs25.34 kB0%
shared/nuxi.BAGoDD49.mjs1.05 kB0%
shared/nuxi.B5t53vrk.mjs2.02 MB0%
shared/nuxi.BjhZEm2-.mjs1.75 kB0%
shared/nuxi.BEgIcxrx.mjs4.06 kB0%
shared/nuxi.DU9QXUOf.mjs26.96 kB0%
shared/nuxi.BzZJv2UC.mjs123.67 kB0%
shared/nuxi.QWnQy_ku.mjs5.75 kB0%
shared/nuxi.CbyJ5osS.mjs13.45 kB0%
shared/nuxi.BLb4POFS.mjs42.47 kB0%
shared/nuxi.Do0aYBCO.mjs5.46 kB0%
shared/nuxi.4t9faemh.mjs43.64 kB0%

@github-actions

github-actionsBot commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

Bundle Stats — nuxt-cli size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
3294.69 kB → 95.14 kB (+462 B)+0.48%
Changeset
FileΔSize
home/runner/work/cli/cli/packages/nuxi/src/dev/socket.ts📈 +462 B (+30.45%)1.48 kB → 1.93 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

AssetFile Size% Changed
chunks/index.mjs14.3 kB → 14.75 kB (+462 B)+3.15%

Smaller

No assets were smaller

Unchanged

AssetFile Size% Changed
dev/index.mjs0 B0%
index.mjs236 B0%
chunks/analyze.mjs3.35 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs815 B0%
chunks/dev.mjs10.96 kB0%
chunks/devtools.mjs763 B0%
chunks/generate.mjs492 B0%
chunks/build.mjs2.04 kB0%
chunks/info.mjs4.44 kB0%
chunks/index2.mjs273 B0%
chunks/add.mjs10.17 kB0%
chunks/search.mjs2.96 kB0%
chunks/prepare.mjs1.04 kB0%
chunks/preview.mjs3.58 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs2.06 kB0%
chunks/upgrade.mjs6.28 kB0%
chunks/init.mjs9.85 kB0%
chunks/add2.mjs6.89 kB0%
shared/cli.B9AmABr3.mjs39 B0%
shared/cli.Dz2be-Ai.mjs792 B0%
shared/cli.BEUGgaW4.mjs294 B0%
shared/cli.BSm0_9Hr.mjs107 B0%
shared/cli.At9IMXtr.mjs1.23 kB0%
shared/cli.pLQ0oPGc.mjs836 B0%
shared/cli.qKvs7FJ2.mjs945 B0%
shared/cli.CVtBY1Lh.mjs78 B0%
shared/cli.jA1DRKbi.mjs1.04 kB0%
shared/cli.CTOLcVu5.mjs1.8 kB0%
shared/cli.Cq2v8K7t.mjs5.55 kB0%

@github-actions

github-actionsBot commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

Bundle Stats — create-nuxt size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
495.9 MB → 5.9 MB (-1.02 kB)-0.02%
Changeset
FileΔSize
home/runner/work/cli/cli/packages/nuxi/src/dev/socket.ts📈 +468 B (+30.81%)1.48 kB → 1.94 kB
home/runner/work/cli/cli/packages/nuxi/src/commands/dev.ts📉 -7 B (-0.06%)10.96 kB → 10.96 kB
node_modules/get-port-please/dist/index.mjs📉 -1.47 kB (-17.72%)8.29 kB → 6.82 kB
View detailed bundle breakdown

Added

AssetFile Size% Changed
shared/create-nuxt.DGR-4y38.mjs0 B → 2.02 MB (+2.02 MB)-
shared/create-nuxt.Bg0CMW0t.mjs0 B → 1.17 MB (+1.17 MB)-
shared/create-nuxt.DRvPBIzb.mjs0 B → 964.65 kB (+964.65 kB)-
shared/create-nuxt.BIXH7Bes.mjs0 B → 108.11 kB (+108.11 kB)-
shared/create-nuxt.Byn3C0-h.mjs0 B → 18.91 kB (+18.91 kB)-
shared/create-nuxt.CoBiRFJS.mjs0 B → 16.04 kB (+16.04 kB)-
shared/create-nuxt.b7bOylbM.mjs0 B → 4.07 kB (+4.07 kB)-
shared/create-nuxt.CNQ_Go7v.mjs0 B → 4.06 kB (+4.06 kB)-
shared/create-nuxt.CRlkEjAN.mjs0 B → 3.9 kB (+3.9 kB)-
shared/create-nuxt.CHAMNw_s.mjs0 B → 945 B (+945 B)-
shared/create-nuxt.DwUKavpp.mjs0 B → 836 B (+836 B)-
shared/create-nuxt.CgWUcMnt.mjs0 B → 792 B (+792 B)-
shared/create-nuxt.COKOwZS2.mjs0 B → 294 B (+294 B)-

Removed

AssetFile Size% Changed
shared/create-nuxt.C1ym98hn.mjs2.02 MB → 0 B (-2.02 MB)-100%
shared/create-nuxt.DpE8NP1h.mjs1.17 MB → 0 B (-1.17 MB)-100%
shared/create-nuxt.DBkt0TXV.mjs964.65 kB → 0 B (-964.65 kB)-100%
shared/create-nuxt.DHX9Nl7I.mjs108.11 kB → 0 B (-108.11 kB)-100%
shared/create-nuxt.GJ1_xsrQ.mjs18.91 kB → 0 B (-18.91 kB)-100%
shared/create-nuxt.BH95KLiY.mjs16.04 kB → 0 B (-16.04 kB)-100%
shared/create-nuxt.Ci1bUFb0.mjs4.07 kB → 0 B (-4.07 kB)-100%
shared/create-nuxt.CmFgxZg2.mjs4.06 kB → 0 B (-4.06 kB)-100%
shared/create-nuxt.nsclUCNA.mjs3.9 kB → 0 B (-3.9 kB)-100%
shared/create-nuxt.BxL3n5M4.mjs945 B → 0 B (-945 B)-100%
shared/create-nuxt.jCQ4HHM_.mjs836 B → 0 B (-836 B)-100%
shared/create-nuxt.BjKNMbca.mjs792 B → 0 B (-792 B)-100%
shared/create-nuxt.BGXWA1Eb.mjs294 B → 0 B (-294 B)-100%

Bigger

AssetFile Size% Changed
chunks/index2.mjs197.3 kB → 197.76 kB (+468 B)+0.23%

Smaller

AssetFile Size% Changed
chunks/dev.mjs28.1 kB → 28.09 kB (-7 B)-0.02%

Unchanged

AssetFile Size% Changed
index.mjs1.07 kB0%
chunks/multipart-parser.mjs5.11 kB0%
chunks/multipart-parser2.mjs4.58 kB0%
chunks/add.mjs6.89 kB0%
chunks/analyze.mjs3.35 kB0%
chunks/build.mjs2.04 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs811 B0%
chunks/devtools.mjs764 B0%
chunks/generate.mjs492 B0%
chunks/info.mjs4.43 kB0%
chunks/index.mjs274 B0%
chunks/prepare.mjs1.04 kB0%
chunks/preview.mjs3.58 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs2.06 kB0%
chunks/upgrade.mjs6.28 kB0%
chunks/prompt.mjs42.91 kB0%
chunks/satisfies.mjs116 B0%
chunks/jiti.mjs305 B0%
chunks/index3.mjs71.97 kB0%
chunks/add2.mjs12.08 kB0%
chunks/search.mjs45.85 kB0%
chunks/xdg-open.mjs25.32 kB0%
chunks/node.mjs145.67 kB0%
chunks/index4.mjs1.23 kB0%
chunks/index5.mjs5.85 kB0%
chunks/index6.mjs6.24 kB0%
chunks/index7.mjs50.51 kB0%
chunks/index8.mjs904.05 kB0%
shared/create-nuxt.BSm0_9Hr.mjs107 B0%
shared/create-nuxt.BjhZEm2-.mjs1.75 kB0%
shared/create-nuxt.Vk1IrVtB.mjs26.96 kB0%
shared/create-nuxt.4t9faemh.mjs43.64 kB0%

@pkg-pr-new

pkg-pr-newBot commented Jul 14, 2025

Copy link
Copy Markdown

nuxt-cli-playground

npm i https://pkg.pr.new/create-nuxt@957

npm i https://pkg.pr.new/nuxi@957

npm i https://pkg.pr.new/@nuxt/cli@957

commit: e41d065

@codspeed-hq

codspeed-hqBot commented Jul 14, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #957 will improve performances by 13.13%

Comparing fix/socket-url (e41d065) with main (11330aa)

Summary

⚡ 1 improvements
✅ 1 untouched benchmarks

Benchmarks breakdown

BenchmarkBASEHEADChange
⚡makes requests to dev server99.3 ms87.7 ms+13.13%

@danielroe
danielroe marked this pull request as ready for review July 14, 2025 20:09
@danielroe
danielroe merged commit d2c200e into mainJul 14, 2025
14 checks passed
@danielroe
danielroe deleted the fix/socket-url branch July 14, 2025 22:29
@github-actionsgithub-actionsBot mentioned this pull request Jul 14, 2025
Merged
@OrbisK

OrbisK commented Jul 15, 2025

Copy link
Copy Markdown
Member

I'm temporarily without access to windows

I think you dont need windows. This does even reproduce in github codespaces.

@danielroedanielroe mentioned this pull request Jul 20, 2025
Merged
@EazashEazash mentioned this pull request Sep 17, 2025
Merged
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

nuxt dev | Cannot start nuxt: Invalid URL

2 participants

@danielroe@OrbisK