Skip to content

refactor!: spell extensions correctly - #1204

Merged
Tahul merged 1 commit into
nuxt:mainfrom
harlan-zw:fix/spell-extensions-correctly
Jun 3, 2022
Merged

refactor!: spell extensions correctly#1204
Tahul merged 1 commit into
nuxt:mainfrom
harlan-zw:fix/spell-extensions-correctly

Conversation

@harlan-zw

@harlan-zwharlan-zw commented Jun 3, 2022

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The key is spelled incorrectly, as someone who is adding a custom transformer I'd prefer not to have misspelled keys in my code.

BREAKING CHANGE: custom transformers should rename key extentions to extensions

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

BREAKING CHANGE: custom transformers should rename key `extentions` to `extensions`
@netlify

netlifyBot commented Jun 3, 2022

Copy link
Copy Markdown

‼️ Deploy request for nuxt-content rejected.

NameLink
🔨 Latest commit4a68090

@Tahul

Tahul commented Jun 3, 2022

Copy link
Copy Markdown
Contributor

I'll let @farnabaz double-check this one but this LGTM. 😄

I don't think a lot of people actually uses custom transformers in their own projects yet, so even if this adds a breaking change it is fine to me to push this ASAP.

Thank you so much @harlan-zw

@Tahul
Tahul requested a review from farnabazJune 3, 2022 12:05
@Tahul
Tahul merged commit adc0143 into nuxt:mainJun 3, 2022
@pi0

pi0 commented Jun 3, 2022

Copy link
Copy Markdown
Member

Nice catch @harlan-zw. But are you going to release content v3 for it ?! It could be a soft fix with typo fallback until next semver-major.

@harlan-zw

Copy link
Copy Markdown
ContributorAuthor

Nice catch @harlan-zw. But are you going to release content v3 for it ?! It could be a soft fix with typo fallback until next semver-major.

Thanks for the review @pi0, you're absolutey right. A soft fix would have been a better option. I'll avoid these type of PRs in the future 👍

@pi0

pi0 commented Jun 4, 2022

Copy link
Copy Markdown
Member

No worries! Is current change released? If not we might have a chance to avoid breaking.

harlan-zw added a commit to harlan-zw/nuxt-content-fork that referenced this pull request Jun 5, 2022
@farnabazfarnabaz mentioned this pull request Aug 12, 2022
farnabaz pushed a commit that referenced this pull request Sep 7, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@harlan-zw@Tahul@pi0@atinux@farnabaz