Uh oh!
There was an error while loading. Please reload this page.
refactor!: spell extensions correctly - #1204
Conversation
BREAKING CHANGE: custom transformers should rename key `extentions` to `extensions`
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 4a68090 |
Tahul
commented
Jun 3, 2022
I'll let @farnabaz double-check this one but this LGTM. 😄 I don't think a lot of people actually uses custom transformers in their own projects yet, so even if this adds a breaking change it is fine to me to push this ASAP. Thank you so much @harlan-zw |
pi0
commented
Jun 3, 2022
Nice catch @harlan-zw. But are you going to release content v3 for it ?! It could be a soft fix with typo fallback until next semver-major. |
harlan-zw
commented
Jun 4, 2022
Thanks for the review @pi0, you're absolutey right. A soft fix would have been a better option. I'll avoid these type of PRs in the future 👍 |
pi0
commented
Jun 4, 2022
No worries! Is current change released? If not we might have a chance to avoid breaking. |
This reverts commit adc0143.
🔗 Linked issue
❓ Type of change
📚 Description
The key is spelled incorrectly, as someone who is adding a custom transformer I'd prefer not to have misspelled keys in my code.
BREAKING CHANGE: custom transformers should rename key
extentionstoextensions📝 Checklist