Uh oh!
There was an error while loading. Please reload this page.
fix(transformers): opt-in to correct extensions spelling - #1213
fix(transformers): opt-in to correct extensions spelling#1213harlan-zw wants to merge 4 commits into
extensions spelling#1213Conversation
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 2733907 |
…king-change-extensions
harlan-zw
commented
Jun 5, 2022
Hm I wanted to revert the other commit but have done something wrong 😬 |
harlan-zw
commented
Jun 5, 2022
Okay should be good |
Tahul
commented
Jun 7, 2022
That you a lot @harlan-zw 🙂 Should've renamed the original PR, this is my bad! The new test is a great addition as well! |
I would just like to double-check with @atinux and @farnabaz about keeping that I think no one (or very few people) yet used these features, avoiding preserving that kind of dead code could be great... even if I understand the concerns about semantic versioning. |
farnabaz
commented
Jun 7, 2022
I agree that no one yet used this feature, also we do not have good documentation about parsers and transformers. Transformers are mainly used internally, We did not expose types and a helper to create custom transformers yet. So I see no harm in dropping misspelled key. It will be good if we create/expose util to define transformers. like |
Tahul
left a comment
There was a problem hiding this comment.
Could you please remove the @deprecated keys and support for previous implementation?
I would like to preserve the test-case there, but not the support for older implementations (point about this in discussion with @farnabaz above).
I'll make a seperate pr for the test case if not needed 👍 |
harlan-zw
commented
Jun 8, 2022
Great idea |
🔗 Linked issue
Related #1204 (comment)
❓ Type of change
📚 Description
This is an alternative solution to the fix for mispelled extensions, this PR reverts the breaking change commit of #1204 (comment). We prefer to use a soft breaking change to avoid having to bump majors.
I've also included a test for a custom transformer here using the deprecated key.
📝 Checklist