Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): resolve tsconfig.json for vue-tsc type checker - #6069

Merged
pi0 merged 4 commits into
nuxt:mainfrom
mhfeizi:main
Jul 25, 2022
Merged

fix(vite): resolve tsconfig.json for vue-tsc type checker#6069
pi0 merged 4 commits into
nuxt:mainfrom
mhfeizi:main

Conversation

@mhfeizi

@mhfeizimhfeizi commented Jul 22, 2022

Copy link
Copy Markdown
Contributor

🔗 Linked issue

nuxt/nuxt#14379

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Jul 22, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitdbc7c94
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62de6dc05d2828000881f52d
😎 Deploy Previewhttps://deploy-preview-6069--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

danielroe
danielroe reviewed Jul 22, 2022
View reviewed changes
Comment threadpackages/vite/src/server.ts Outdated
danielroe
danielroe reviewed Jul 22, 2022
View reviewed changes
Comment threadpackages/vite/src/server.ts Outdated
@danielroe

danielroe commented Jul 25, 2022•
edited
Loading

Copy link
Copy Markdown
Member

@mhfeizi So I can test this PR, would you be able to give a reproduction of the original issue in nuxt/nuxt#14379?

pi0
pi0 approved these changes Jul 25, 2022
View reviewed changes
@pi0pi0 changed the title fix(vite): typeCheck is not works when app is in sub directoryfix(vite): resolve tsconfig.json for vue-tsc type checkerJul 25, 2022
@pi0
pi0 merged commit cccafd6 into nuxt:mainJul 25, 2022
@farnabazfarnabaz mentioned this pull request Jan 19, 2023
Closed
@danielroedanielroe mentioned this pull request Jul 25, 2022
Merged
7 tasks
@pi0pi0 mentioned this pull request Aug 5, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@danielroedanielroedanielroe left review comments
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mhfeizi@danielroe@pi0