Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

build(vite): add missing pkg-types dependency - #6128

Merged
pi0 merged 1 commit into
mainfrom
build/add-dep
Jul 25, 2022
Merged

build(vite): add missing pkg-types dependency#6128
pi0 merged 1 commit into
mainfrom
build/add-dep

Conversation

@danielroe

@danielroedanielroe commented Jul 25, 2022•
edited
Loading

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14416

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Likely an upstream issue to fix in unbuild also (can track in unjs/unbuild#97 - cc: @pi0). But we should not be inlining pkg-types in any case (introduced in #6069).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Jul 25, 2022
@danielroe
danielroe requested a review from pi0July 25, 2022 14:27
@danielroedanielroe self-assigned this Jul 25, 2022
@netlify

netlifyBot commented Jul 25, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit157f39d
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62dea84f0ea0bf000977cb3d

@pi0pi0 changed the title build: add pkg-types dep (prevents inlining)build(vite): add missing pkg-types dependencyJul 25, 2022
@pi0
pi0 merged commit 133723f into mainJul 25, 2022
@pi0
pi0 deleted the build/add-dep branch July 25, 2022 15:18
@pi0pi0 mentioned this pull request Aug 5, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pi0pi0Awaiting requested review from pi0

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working❗ p4-importantPriority 4: bugs that violate documented behavior, or significantly impact perf

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Broken @nuxt/vite-builder

2 participants

@danielroe@pi0