Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): clear vite-node runner cache after each render - #6154

Merged
pi0 merged 1 commit into
mainfrom
fix/vite-node-cache
Jul 26, 2022
Merged

fix(nuxt): clear vite-node runner cache after each render#6154
pi0 merged 1 commit into
mainfrom
fix/vite-node-cache

Conversation

@antfu

@antfuantfu commented Jul 26, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

nuxt/nuxt#13994

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Otherwise, the cache will be preseved across builds

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Jul 26, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitac5b81b
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62dfe6ef1b9b7f0009dd8f34
😎 Deploy Previewhttps://deploy-preview-6154--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfuantfu mentioned this pull request Jan 19, 2023
4 tasks
pi0
pi0 approved these changes Jul 26, 2022
@pi0

pi0 commented Jul 26, 2022

Copy link
Copy Markdown
Member

Do you have any plans to make the cache more persistent? In case of no rebuilds, i think we are just loosing cache possibility this way.

@pi0pi0 changed the title fix(vite-node): clear cache after each renderfix(nuxt): clear vite-node runner cache after each renderJul 26, 2022
@pi0
pi0 merged commit a585086 into mainJul 26, 2022
@pi0
pi0 deleted the fix/vite-node-cache branch July 26, 2022 13:13
@antfu

Copy link
Copy Markdown
MemberAuthor

Yeah I will make future improvements to only invalidate based on what files are changed. However, that requires some complexity to communicate between the process. The first step is #6156, and I will experiment with solutions in later PRs as improvements.

@antfuantfu mentioned this pull request Aug 4, 2022
7 tasks
@pi0pi0 mentioned this pull request Aug 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@antfu@pi0@danielroe