Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(bridge): use useMeta in bridge projects - #664

Merged
pi0 merged 14 commits into
mainfrom
feat/usemeta-bridge
Oct 6, 2021
Merged

feat(bridge): use useMeta in bridge projects#664
pi0 merged 14 commits into
mainfrom
feat/usemeta-bridge

Conversation

@danielroe

@danielroedanielroe commented Oct 6, 2021

Copy link
Copy Markdown
Member

🔗 Linked issue

nuxt/bridge#102

❓ Type of change

  • Enhancement (improving an existing functionality like performance)

📚 Description

This PR backports useMeta (currently using vueuse/head) to nuxt2. Because vueuse/head depends on vue3, we also a include a nuxt.app shim and a vue module that exports composition api functions.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added enhancement New feature or request bridge labels Oct 6, 2021
@danielroedanielroe self-assigned this Oct 6, 2021
@danielroe
feat(bridge): use useMeta in bridge projects
958ccad
* includes `nuxt.app` shim and `vue` module that exports composition api functions
@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Oct 6, 2021•
edited
Loading

Copy link
Copy Markdown

Deploying with Cloudflare Pages Cloudflare Pages

Latest commit:f1ba4ad
Status:⚡️ Build in progress...

View logs

@pi0pi0 mentioned this pull request Apr 13, 2022
Closed
14 tasks
pi0
pi0 reviewed Oct 6, 2021
View reviewed changes
Comment threadpackages/bridge/src/meta.ts Outdated
Comment threadpackages/bridge/src/meta.ts Outdated
Comment threadpackages/nuxt3/src/meta/runtime/plugin.ts
@danielroedanielroe removed the wip label Oct 6, 2021
pi0
pi0 reviewed Oct 6, 2021
View reviewed changes
Comment threadpackages/bridge/src/runtime/capi.plugin.mjs Outdated
pi0
pi0 reviewed Oct 6, 2021
View reviewed changes
Comment threadpackages/bridge/src/module.ts Outdated
@danielroe@pi0
refactor: change meta module options syntax
ec3ab1a
Co-authored-by: Pooya Parsa <pyapar@gmail.com>
pi0
pi0 reviewed Oct 6, 2021
View reviewed changes
Comment threadpackages/bridge/src/meta.ts Outdated
@danielroe@pi0
Update packages/bridge/src/meta.ts
9156bf4
Co-authored-by: pooya parsa <pyapar@gmail.com>
@pi0
pi0 merged commit a07b67c into mainOct 6, 2021
@pi0
pi0 deleted the feat/usemeta-bridge branch October 6, 2021 12:37
@danielroedanielroe mentioned this pull request Sep 1, 2022
Merged
7 tasks
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbridgeenhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0