Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

refactor(nuxt): remove unused meta:register hook - #7130

Merged
pi0 merged 1 commit into
mainfrom
fix/stale-hook
Sep 1, 2022
Merged

refactor(nuxt): remove unused meta:register hook#7130
pi0 merged 1 commit into
mainfrom
fix/stale-hook

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

https://github.com/nuxt/framework/discussions/7125

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This removes a hook that was only used for Nuxt Bridge integration: #664.

It might be useful to reconsider adding back some kind of hook implementation in future but for now it's unused and can be removed.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Sep 1, 2022
@danielroe
danielroe requested a review from pi0September 1, 2022 08:43
@danielroedanielroe self-assigned this Sep 1, 2022
@netlify

netlifyBot commented Sep 1, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit1f4ed27
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6310709d9d480900092dc47d
😎 Deploy Previewhttps://deploy-preview-7130--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0pi0 changed the title fix(nuxt): remove unused meta:register hookrefactor(nuxt): remove unused meta:register hookSep 1, 2022
@pi0
pi0 merged commit 6fbbf8c into mainSep 1, 2022
@pi0
pi0 deleted the fix/stale-hook branch September 1, 2022 09:08
@pi0

pi0 commented Sep 1, 2022

Copy link
Copy Markdown
Member

Thanks.

@pi0pi0 mentioned this pull request Sep 1, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0