Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): warmup server entries with ssr condition - #6649

Merged
pi0 merged 2 commits into
mainfrom
fix/vite-ssr-warmup
Aug 15, 2022
Merged

fix(vite): warmup server entries with ssr condition#6649
pi0 merged 2 commits into
mainfrom
fix/vite-ssr-warmup

Conversation

@pi0

@pi0pi0 commented Aug 15, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

#6647

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Without this fix, we were actually adding some overhead to transform server assets without ssr condition.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Aug 15, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit6a9de1f
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62fa6e2d9da9d1000845ec4b

@pi0
pi0 requested a review from antfuAugust 15, 2022 15:34
@pi0pi0 mentioned this pull request Aug 15, 2022
7 tasks
@pi0
pi0 merged commit 58c4753 into mainAug 15, 2022
@pi0
pi0 deleted the fix/vite-ssr-warmup branch August 15, 2022 16:03
@pi0pi0 mentioned this pull request Aug 26, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pi0@antfu@danielroe