Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): pass ssr condition to getModuleByUrl - #7260

Merged
pi0 merged 1 commit into
mainfrom
fix/warmup-condition
Sep 5, 2022
Merged

fix(vite): pass ssr condition to getModuleByUrl#7260
pi0 merged 1 commit into
mainfrom
fix/warmup-condition

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

#6649

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds a missing condition to getModuleByUrl

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working vite 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Sep 5, 2022
@danielroe
danielroe requested a review from pi0September 5, 2022 20:47
@danielroedanielroe self-assigned this Sep 5, 2022
@netlify

netlifyBot commented Sep 5, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit5d0ad28
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63166053387f350008090cc1

pi0
pi0 approved these changes Sep 5, 2022

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@pi0pi0 changed the title fix: pass ssr condition to getModuleByUrlfix(vite): pass ssr condition to getModuleByUrlSep 5, 2022
@pi0
pi0 merged commit d115b01 into mainSep 5, 2022
@pi0
pi0 deleted the fix/warmup-condition branch September 5, 2022 20:52
This was referenced Sep 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressingvite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0