Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(nuxi): auto-generate .npmrc and setting for pnpm - #7407

Merged
pi0 merged 7 commits into
nuxt:mainfrom
kecrily:chore/pnpm
Nov 11, 2022
Merged

feat(nuxi): auto-generate .npmrc and setting for pnpm#7407
pi0 merged 7 commits into
nuxt:mainfrom
kecrily:chore/pnpm

Conversation

@kecrily

Copy link
Copy Markdown
Contributor

🔗 Linked issue

ref nuxt/nuxt#14146

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Before we support using pnpm without --shamefully-hoist, let's automatically generate .npmrc for an out-of-the-box experience. Remove it after support.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Sep 11, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit6f5bdb1
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/636d26c071251100088e9e50
😎 Deploy Previewhttps://deploy-preview-7407--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0

pi0 commented Sep 12, 2022

Copy link
Copy Markdown
Member

I really love the idea of this PR! But I think which-pm-runs only works when running nuxi init with pnpm and in docs we also use npx which could be misleading if someone uses npx + pnpm install.

@kecrily

Copy link
Copy Markdown
ContributorAuthor

This is really a problem. Maybe we can clarify this in the documentation?

@pi0
pi0force-pushed the main branch 2 times, most recently from 247e18b to c98e5c7CompareSeptember 14, 2022 10:41
pi0
pi0 approved these changes Nov 10, 2022
@danielroedanielroe changed the title chore: auto gengerate .npmrc and setting for pnpmfeat: auto-generate .npmrc and setting for pnpmNov 10, 2022
@danielroedanielroe changed the title feat: auto-generate .npmrc and setting for pnpmfeat(nuxi): auto-generate .npmrc and setting for pnpmNov 10, 2022
@pi0
pi0 merged commit 2f53495 into nuxt:mainNov 11, 2022
@pi0pi0 mentioned this pull request Nov 15, 2022
danielroe pushed a commit that referenced this pull request Jan 21, 2023
Co-authored-by: Pooya Parsa <pooya@pi0.io>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kecrily@pi0@danielroe