Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxi): include workspaceDir in tsconfig include - #7726

Merged
pi0 merged 5 commits into
mainfrom
fix/workspace-tsconfig
Sep 22, 2022
Merged

fix(nuxi): include workspaceDir in tsconfig include#7726
pi0 merged 5 commits into
mainfrom
fix/workspace-tsconfig

Conversation

@danielroe

@danielroedanielroe commented Sep 21, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

In some cases, such as module development, we want to be able to use types for things like #app in a workspace rather than just within the nuxt root directory. This allows extending a tsconfig.json in a parent directory (e.g. https://github.com/nuxt/starter/blob/module/tsconfig.json#L2).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added enhancement New feature or request cli labels Sep 21, 2022
@danielroe
danielroe requested a review from pi0September 21, 2022 14:23
@danielroedanielroe self-assigned this Sep 21, 2022
@codesandbox

codesandboxBot commented Sep 21, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Sep 21, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitf34003a
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/632b27aa65dcf70009870450
😎 Deploy Previewhttps://deploy-preview-7726--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroedanielroe added bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Sep 21, 2022
dargmuesli
dargmuesli approved these changes Sep 21, 2022
View reviewed changes

@dargmueslidargmuesli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Adds "../../**/*" to the playground/.nuxt/tsconfig.json's includes as intended.

pi0
pi0 approved these changes Sep 22, 2022
View reviewed changes
@pi0
pi0 merged commit 230af9c into mainSep 22, 2022
@pi0
pi0 deleted the fix/workspace-tsconfig branch September 22, 2022 13:50
@danielroedanielroe mentioned this pull request Oct 9, 2022
Merged
@cuebitcuebit mentioned this pull request Jan 19, 2023
Closed
@danielroedanielroe mentioned this pull request Oct 17, 2022
Merged
7 tasks
@dargmueslidargmuesli mentioned this pull request Jan 19, 2023
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@dargmueslidargmueslidargmuesli approved these changes
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't workingclienhancementNew feature or request🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielroe@dargmuesli@pi0