Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxi): remove workspaceDir from tsconfig include - #8256

Merged
pi0 merged 1 commit into
mainfrom
fix/workspace-ts
Oct 17, 2022
Merged

fix(nuxi): remove workspaceDir from tsconfig include#8256
pi0 merged 1 commit into
mainfrom
fix/workspace-ts

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#15165

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

By default we include workspace in include paths (#7726) but this may lead to over-type-checking in monorepos. This PR reverts this behaviour and puts it behind an option which can be enabled by default in module author template.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working dx labels Oct 17, 2022
@danielroe
danielroe requested a review from pi0October 17, 2022 15:26
@danielroedanielroe self-assigned this Oct 17, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 17, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit80d29dc
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/634d743bd67cfd00087a1f0f

@danielroedanielroe changed the title fix(nuxi): include workspaceDir in tsconfig includefix(nuxi): remove workspaceDir from tsconfig includeOct 17, 2022
pi0
pi0 approved these changes Oct 17, 2022
@pi0
pi0 merged commit 931ebec into mainOct 17, 2022
@pi0
pi0 deleted the fix/workspace-ts branch October 17, 2022 17:53
@pi0pi0 mentioned this pull request Oct 18, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't workingdx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3.0.0-rc.12 typecheck runs throughout monorepo

2 participants

@danielroe@pi0